forked from mirrors/gecko-dev
56be5080d2
The only thing that can explain this is the WM_UPDATEUISTATE state getting out of sync in a way that we think we need to unconditionally show focus indicators for a window. I tried to first make this less error prone (see patch above) but digging more into these messages, I'm pretty sure we just don't need all this code. See: * https://devblogs.microsoft.com/oldnewthing/20130516-00/?p=4343 * https://devblogs.microsoft.com/oldnewthing/20130517-00/?p=4323 In particular, this is intended to be a windows feature to not show keyboard indicators on dialogs until you use the keyboard. But that's how Gecko dialogs behave already due to how :focus-visible behaves as per: https://searchfox.org/mozilla-central/rev/43ee5e789b079e94837a21336e9ce2420658fd19/toolkit/components/prompts/src/CommonDialog.jsm#319 I haven't been able to repro this state, but sounds believable that it could happen after opening a native dialog or so on? The purpose of this code is to implement the 'Underline access keys' in the Keyboard Accessibility control panel of windows. There's an easier way of tracking this, via the SPI_GETKEYBOARDCUES SPI, documented in: https://learn.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-systemparametersinfoa Hook that into LookAndFeel rather than using custom IPC and so on. Differential Revision: https://phabricator.services.mozilla.com/D165578
96 lines
3.2 KiB
C++
96 lines
3.2 KiB
C++
/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#ifndef nsPIWindowRoot_h__
|
|
#define nsPIWindowRoot_h__
|
|
|
|
#include "nsISupports.h"
|
|
#include "mozilla/dom/EventTarget.h"
|
|
|
|
class nsPIDOMWindowOuter;
|
|
class nsIControllers;
|
|
class nsIController;
|
|
class nsINode;
|
|
class nsIRemoteTab;
|
|
|
|
#define NS_IWINDOWROOT_IID \
|
|
{ \
|
|
0xb8724c49, 0xc398, 0x4f9b, { \
|
|
0x82, 0x59, 0x87, 0x27, 0xa6, 0x47, 0xdd, 0x0f \
|
|
} \
|
|
}
|
|
|
|
class nsPIWindowRoot : public mozilla::dom::EventTarget {
|
|
public:
|
|
NS_DECLARE_STATIC_IID_ACCESSOR(NS_IWINDOWROOT_IID)
|
|
|
|
bool IsRootWindow() const final { return true; }
|
|
|
|
NS_IMPL_FROMEVENTTARGET_HELPER(nsPIWindowRoot, IsRootWindow())
|
|
|
|
virtual nsPIDOMWindowOuter* GetWindow() = 0;
|
|
|
|
// get and set the node that is the context of a popup menu
|
|
virtual already_AddRefed<nsINode> GetPopupNode() = 0;
|
|
virtual void SetPopupNode(nsINode* aNode) = 0;
|
|
|
|
/**
|
|
* @param aForVisibleWindow true if caller needs controller which is
|
|
* associated with visible window.
|
|
*/
|
|
virtual nsresult GetControllerForCommand(const char* aCommand,
|
|
bool aForVisibleWindow,
|
|
nsIController** aResult) = 0;
|
|
|
|
/**
|
|
* @param aForVisibleWindow true if caller needs controllers which are
|
|
* associated with visible window.
|
|
*/
|
|
virtual nsresult GetControllers(bool aForVisibleWindow,
|
|
nsIControllers** aResult) = 0;
|
|
|
|
virtual void GetEnabledDisabledCommands(
|
|
nsTArray<nsCString>& aEnabledCommands,
|
|
nsTArray<nsCString>& aDisabledCommands) = 0;
|
|
|
|
virtual void SetParentTarget(mozilla::dom::EventTarget* aTarget) = 0;
|
|
virtual mozilla::dom::EventTarget* GetParentTarget() = 0;
|
|
|
|
// Stores a weak reference to the browser.
|
|
virtual void AddBrowser(nsIRemoteTab* aBrowser) = 0;
|
|
virtual void RemoveBrowser(nsIRemoteTab* aBrowser) = 0;
|
|
|
|
using BrowserEnumerator = void (*)(nsIRemoteTab* aTab, void* aArg);
|
|
|
|
// Enumerate all stored browsers that for which the weak reference is valid.
|
|
virtual void EnumerateBrowsers(BrowserEnumerator aEnumFunc, void* aArg) = 0;
|
|
};
|
|
|
|
namespace mozilla::dom {
|
|
|
|
inline nsPIWindowRoot* EventTarget::GetAsWindowRoot() {
|
|
return IsRootWindow() ? static_cast<nsPIWindowRoot*>(this) : nullptr;
|
|
}
|
|
|
|
inline const nsPIWindowRoot* EventTarget::GetAsWindowRoot() const {
|
|
return IsRootWindow() ? static_cast<const nsPIWindowRoot*>(this) : nullptr;
|
|
}
|
|
|
|
inline nsPIWindowRoot* EventTarget::AsWindowRoot() {
|
|
MOZ_DIAGNOSTIC_ASSERT(IsRootWindow());
|
|
return static_cast<nsPIWindowRoot*>(this);
|
|
}
|
|
|
|
inline const nsPIWindowRoot* EventTarget::AsWindowRoot() const {
|
|
MOZ_DIAGNOSTIC_ASSERT(IsRootWindow());
|
|
return static_cast<const nsPIWindowRoot*>(this);
|
|
}
|
|
|
|
} // namespace mozilla::dom
|
|
|
|
NS_DEFINE_STATIC_IID_ACCESSOR(nsPIWindowRoot, NS_IWINDOWROOT_IID)
|
|
|
|
#endif // nsPIWindowRoot_h__
|