fune/modules/libpref
Manuel Bucher 0da5cdc8ad Bug 1747230 - Fix IsUpgradeDowngradeEndlessLoop blocking legitimate redirects when redirecting to different query parameters a=dmeehan
This changes where the IsUpgradeDowngradeEndlessLoop check triggers.
Before this patch, it triggered during the redirect caused by the https
upgrade. With this patch, it triggers during the downgrade for http
redirects. META and JS redirect are still detected during upgrade.
This should be fixed as a follow up (See Bug 1896691).
Downgrade in this context means same url, except with the scheme http
instead of https.

Different query parameters normally lead to different responses by web servers.
Don't consider the '#ref' part of the uri, because it doesn't get send to
the server and therefore can't change the server response.

We can't use the redirect chain anymore, because the query parameters
are trimmed since Bug 1715785.

This also removes the config option dom.security.https_only_check_path_upgrade_downgrade_endless_loop,
because it adds unnecessary complexity. Removing it for this patch is
easier.

https-only, https-first and httpssvc_https_upgrade tests had to be
modified, because they depended on the incorrect handling of query
strings in loop detection.

Original Revision: https://phabricator.services.mozilla.com/D193672

Differential Revision: https://phabricator.services.mozilla.com/D214977
2024-06-27 13:01:12 +00:00
..
docs
init Bug 1747230 - Fix IsUpgradeDowngradeEndlessLoop blocking legitimate redirects when redirecting to different query parameters a=dmeehan 2024-06-27 13:01:12 +00:00
parser
test Bug 1842549 - Remove dom.mutation-events.cssom.disabled pref r=smaug 2024-06-04 18:38:22 +00:00
components.conf
greprefs.js
moz.build Bug 1894703 - Add the new preference to the static preference list r=padenot 2024-05-23 08:14:17 +00:00
nsIPrefBranch.idl Bug 1883217 - Remove unused defines in IDL files r=webdriver-reviewers,necko-reviewers,credential-management-reviewers,places-reviewers,dom-core,Standard8,valentin,mccr8,sgalich 2024-03-06 19:04:25 +00:00
nsIPrefLocalizedString.idl Bug 1883217 - Remove unused defines in IDL files r=webdriver-reviewers,necko-reviewers,credential-management-reviewers,places-reviewers,dom-core,Standard8,valentin,mccr8,sgalich 2024-03-06 19:04:25 +00:00
nsIPrefService.idl Bug 1054947 - Also check prefs.js last modified time before showing profile reset notification after a long absence, a=RyanVM 2024-06-20 18:26:52 +00:00
nsIRelativeFilePref.idl
nsRelativeFilePref.h
Preferences.cpp Bug 1054947 - Also check prefs.js last modified time before showing profile reset notification after a long absence, a=RyanVM 2024-06-20 18:26:52 +00:00
Preferences.h Bug 1054947 - Also check prefs.js last modified time before showing profile reset notification after a long absence, a=RyanVM 2024-06-20 18:26:52 +00:00
SharedPrefMap.cpp
SharedPrefMap.h
StaticPrefsBase.h