forked from mirrors/gecko-dev
e930b89c34
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
58 lines
1.7 KiB
JavaScript
58 lines
1.7 KiB
JavaScript
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
"use strict";
|
|
|
|
let { EventEmitter } = ChromeUtils.import("resource:///modules/syncedtabs/EventEmitter.jsm");
|
|
|
|
var EXPORTED_SYMBOLS = [
|
|
"SyncedTabsDeckStore",
|
|
];
|
|
|
|
/**
|
|
* SyncedTabsDeckStore
|
|
*
|
|
* This store keeps track of the deck view state, including the panels and which
|
|
* one is selected. The view listens for change events on the store, which are
|
|
* triggered whenever the state changes. If it's a small change, the state
|
|
* will have `isUpdatable` set to true so the view can skip rerendering the whole
|
|
* DOM.
|
|
*/
|
|
function SyncedTabsDeckStore() {
|
|
EventEmitter.call(this);
|
|
this._panels = [];
|
|
}
|
|
|
|
Object.assign(SyncedTabsDeckStore.prototype, EventEmitter.prototype, {
|
|
_change(isUpdatable = false) {
|
|
let panels = this._panels.map(panel => {
|
|
return {id: panel, selected: panel === this._selectedPanel};
|
|
});
|
|
this.emit("change", {panels, isUpdatable});
|
|
},
|
|
|
|
/**
|
|
* Sets the selected panelId and triggers a change event.
|
|
* @param {String} panelId - ID of the panel to select.
|
|
*/
|
|
selectPanel(panelId) {
|
|
if (!this._panels.includes(panelId) || this._selectedPanel === panelId) {
|
|
return;
|
|
}
|
|
this._selectedPanel = panelId;
|
|
this._change(true);
|
|
},
|
|
|
|
/**
|
|
* Update the set of panels in the deck and trigger a change event.
|
|
* @param {Array} panels - an array of IDs for each panel in the deck.
|
|
*/
|
|
setPanels(panels) {
|
|
if (panels === this._panels) {
|
|
return;
|
|
}
|
|
this._panels = panels || [];
|
|
this._change();
|
|
},
|
|
});
|