forked from mirrors/gecko-dev
e930b89c34
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
79 lines
2.5 KiB
JavaScript
79 lines
2.5 KiB
JavaScript
/* -*- Mode: indent-tabs-mode: nil; js-indent-level: 2 -*- */
|
|
/* vim: set sts=2 sw=2 et tw=80: */
|
|
"use strict";
|
|
|
|
const {PageActions} = ChromeUtils.import("resource:///modules/PageActions.jsm");
|
|
const {AddonTestUtils} = ChromeUtils.import("resource://testing-common/AddonTestUtils.jsm");
|
|
|
|
const {
|
|
createAppInfo,
|
|
promiseShutdownManager,
|
|
promiseStartupManager,
|
|
} = AddonTestUtils;
|
|
|
|
AddonTestUtils.init(this);
|
|
AddonTestUtils.overrideCertDB();
|
|
|
|
createAppInfo("xpcshell@tests.mozilla.org", "XPCShell", "1", "58");
|
|
|
|
// This is copied and pasted from ExtensionPopups.jsm. It's used as the
|
|
// PageActions action ID. See ext-pageAction.js.
|
|
function makeWidgetId(id) {
|
|
id = id.toLowerCase();
|
|
// FIXME: This allows for collisions.
|
|
return id.replace(/[^a-z0-9_-]/g, "_");
|
|
}
|
|
|
|
// Tests that the pinnedToUrlbar property of the PageActions.Action object
|
|
// backing the extension's page action persists across app restarts.
|
|
add_task(async function testAppShutdown() {
|
|
let extensionData = {
|
|
useAddonManager: "permanent",
|
|
manifest: {
|
|
page_action: {
|
|
default_title: "test_ext_pageAction_shutdown.js",
|
|
browser_style: false,
|
|
},
|
|
},
|
|
};
|
|
|
|
// Simulate starting up the app.
|
|
PageActions.init();
|
|
await promiseStartupManager();
|
|
|
|
let extension = ExtensionTestUtils.loadExtension(extensionData);
|
|
await extension.startup();
|
|
|
|
// Get the PageAction.Action object. Its pinnedToUrlbar should have been
|
|
// initialized to true in ext-pageAction.js, when it's created.
|
|
let actionID = makeWidgetId(extension.id);
|
|
let action = PageActions.actionForID(actionID);
|
|
Assert.equal(action.pinnedToUrlbar, true);
|
|
|
|
// Simulate restarting the app without first unloading the extension.
|
|
await promiseShutdownManager();
|
|
PageActions._reset();
|
|
await promiseStartupManager();
|
|
await extension.awaitStartup();
|
|
|
|
// Get the action. Its pinnedToUrlbar should remain true.
|
|
action = PageActions.actionForID(actionID);
|
|
Assert.equal(action.pinnedToUrlbar, true);
|
|
|
|
// Now set its pinnedToUrlbar to false.
|
|
action.pinnedToUrlbar = false;
|
|
|
|
// Simulate restarting the app again without first unloading the extension.
|
|
await promiseShutdownManager();
|
|
PageActions._reset();
|
|
await promiseStartupManager();
|
|
await extension.awaitStartup();
|
|
|
|
// Get the action. Its pinnedToUrlbar should remain false.
|
|
action = PageActions.actionForID(actionID);
|
|
Assert.equal(action.pinnedToUrlbar, false);
|
|
|
|
// Now unload the extension and quit the app.
|
|
await extension.unload();
|
|
await promiseShutdownManager();
|
|
});
|