fune/browser/components/controlcenter/content
Johann Hofmann 5632d25ece Bug 1569467 - Avoid setting the "hidden" attribute on protections popup switch labels. r=nhnt11
We were hiding these labels by setting the "hidden" attribute by default and then, in CSS,
negating the effect of "hidden" by using `display: unset;`. Turns out this isn't a great
idea because doing this won't remove the "hidden" attribute, which some code relies on
to figure out whether the element is hidden. Like in this case PanelMultiview:
https://searchfox.org/mozilla-central/rev/0ffa9e372df56c95547fed9c3433ddec4fbf6f11/browser/components/customizableui/PanelMultiView.jsm#1402

Here it tries to find elements to process as part of descriptionHeightWorkaround,
and that skips this technically visible element because it still has the hidden attribute.

Luckily that's easy to fix.

Differential Revision: https://phabricator.services.mozilla.com/D40552

--HG--
extra : moz-landing-system : lando
2019-08-05 11:32:45 +00:00
..
identityPanel.inc.xul Bug 1569375 - Refactor browser panel CSS to reduce shadow DOM traversal after CE conversion. r=dao 2019-07-31 15:22:08 +00:00
protectionsPanel.inc.xul Bug 1569467 - Avoid setting the "hidden" attribute on protections popup switch labels. r=nhnt11 2019-08-05 11:32:45 +00:00