forked from mirrors/gecko-dev
cfb26bdf6f
If an external image shows up multiple times while using a different image rendering setting on each instance, we can erroneously call handler.lock() for each instance in parallel, thus defaulting to the last image rendering setting supplied for all instances in that batch. To work around this, we get rid of the concept of having RenderTextureHosts maintain and set the image rendering state, which results in a nice simplification. Then, when we go to actually bind an external image inside WebRender, we set the image rendering state at that point, so that regardless of how many instances of an external image are locked simultaneously, we always use the correct image rendering setting for a batch. Differential Revision: https://phabricator.services.mozilla.com/D158920
96 lines
3.1 KiB
C++
96 lines
3.1 KiB
C++
/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#include "RenderEGLImageTextureHost.h"
|
|
|
|
#include "mozilla/gfx/Logging.h"
|
|
#include "GLContextEGL.h"
|
|
#include "GLLibraryEGL.h"
|
|
|
|
namespace mozilla {
|
|
namespace wr {
|
|
|
|
RenderEGLImageTextureHost::RenderEGLImageTextureHost(EGLImage aImage,
|
|
EGLSync aSync,
|
|
gfx::IntSize aSize)
|
|
: mImage(aImage),
|
|
mSync(aSync),
|
|
mSize(aSize),
|
|
mTextureTarget(LOCAL_GL_TEXTURE_2D),
|
|
mTextureHandle(0) {
|
|
MOZ_COUNT_CTOR_INHERITED(RenderEGLImageTextureHost, RenderTextureHost);
|
|
}
|
|
|
|
RenderEGLImageTextureHost::~RenderEGLImageTextureHost() {
|
|
MOZ_COUNT_DTOR_INHERITED(RenderEGLImageTextureHost, RenderTextureHost);
|
|
DeleteTextureHandle();
|
|
}
|
|
|
|
wr::WrExternalImage RenderEGLImageTextureHost::Lock(uint8_t aChannelIndex,
|
|
gl::GLContext* aGL) {
|
|
MOZ_ASSERT(aChannelIndex == 0);
|
|
|
|
if (mGL.get() != aGL) {
|
|
if (mGL) {
|
|
// This should not happen. SharedSurface_EGLImage is created only in
|
|
// parent process.
|
|
MOZ_ASSERT_UNREACHABLE("Unexpected GL context");
|
|
return InvalidToWrExternalImage();
|
|
}
|
|
mGL = aGL;
|
|
}
|
|
|
|
if (!mImage || !mGL || !mGL->MakeCurrent()) {
|
|
return InvalidToWrExternalImage();
|
|
}
|
|
|
|
EGLint status = LOCAL_EGL_CONDITION_SATISFIED;
|
|
if (mSync) {
|
|
const auto& gle = gl::GLContextEGL::Cast(mGL);
|
|
const auto& egl = gle->mEgl;
|
|
MOZ_ASSERT(egl->IsExtensionSupported(gl::EGLExtension::KHR_fence_sync));
|
|
status = egl->fClientWaitSync(mSync, 0, LOCAL_EGL_FOREVER);
|
|
// We do not need to delete sync here. It is deleted by
|
|
// SharedSurface_EGLImage.
|
|
mSync = 0;
|
|
}
|
|
|
|
if (status != LOCAL_EGL_CONDITION_SATISFIED) {
|
|
MOZ_ASSERT(
|
|
status != 0,
|
|
"ClientWaitSync generated an error. Has mSync already been destroyed?");
|
|
return InvalidToWrExternalImage();
|
|
}
|
|
|
|
if (!mTextureHandle) {
|
|
mTextureTarget = mGL->GetPreferredEGLImageTextureTarget();
|
|
MOZ_ASSERT(mTextureTarget == LOCAL_GL_TEXTURE_2D ||
|
|
mTextureTarget == LOCAL_GL_TEXTURE_EXTERNAL);
|
|
|
|
mGL->fGenTextures(1, &mTextureHandle);
|
|
ActivateBindAndTexParameteri(mGL, LOCAL_GL_TEXTURE0, mTextureTarget,
|
|
mTextureHandle);
|
|
mGL->fEGLImageTargetTexture2D(mTextureTarget, mImage);
|
|
}
|
|
|
|
const auto uvs = GetUvCoords(mSize);
|
|
return NativeTextureToWrExternalImage(
|
|
mTextureHandle, uvs.first.x, uvs.first.y, uvs.second.x, uvs.second.y);
|
|
}
|
|
|
|
void RenderEGLImageTextureHost::Unlock() {}
|
|
|
|
void RenderEGLImageTextureHost::DeleteTextureHandle() {
|
|
if (mTextureHandle) {
|
|
// XXX recycle gl texture, since SharedSurface_EGLImage and
|
|
// RenderEGLImageTextureHost is not recycled.
|
|
mGL->fDeleteTextures(1, &mTextureHandle);
|
|
mTextureHandle = 0;
|
|
}
|
|
}
|
|
|
|
} // namespace wr
|
|
} // namespace mozilla
|