fune/gfx/webrender_bindings/RenderEGLImageTextureHost.h
Lee Salzman cfb26bdf6f Bug 1792527 - Explicitly bind mip filter for external textures inside WebRender. r=gw
If an external image shows up multiple times while using a different image rendering
setting on each instance, we can erroneously call handler.lock() for each instance in
parallel, thus defaulting to the last image rendering setting supplied for all instances
in that batch.

To work around this, we get rid of the concept of having RenderTextureHosts maintain and
set the image rendering state, which results in a nice simplification. Then, when we go
to actually bind an external image inside WebRender, we set the image rendering state
at that point, so that regardless of how many instances of an external image are locked
simultaneously, we always use the correct image rendering setting for a batch.

Differential Revision: https://phabricator.services.mozilla.com/D158920
2022-10-10 19:23:51 +00:00

46 lines
1.3 KiB
C++

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#ifndef MOZILLA_GFX_RENDEREGLIMAGETEXTUREHOST_H
#define MOZILLA_GFX_RENDEREGLIMAGETEXTUREHOST_H
#include "mozilla/layers/TextureHostOGL.h"
#include "RenderTextureHost.h"
namespace mozilla {
namespace wr {
// RenderEGLImageTextureHost is created only for SharedSurface_EGLImage that is
// created in parent process.
class RenderEGLImageTextureHost final : public RenderTextureHost {
public:
RenderEGLImageTextureHost(EGLImage aImage, EGLSync aSync, gfx::IntSize aSize);
wr::WrExternalImage Lock(uint8_t aChannelIndex, gl::GLContext* aGL) override;
void Unlock() override;
size_t Bytes() override {
// XXX: we don't have a format so we can't get bpp.
return mSize.width * mSize.height;
}
private:
virtual ~RenderEGLImageTextureHost();
void DeleteTextureHandle();
const EGLImage mImage;
EGLSync mSync;
const gfx::IntSize mSize;
RefPtr<gl::GLContext> mGL;
GLenum mTextureTarget;
GLuint mTextureHandle;
};
} // namespace wr
} // namespace mozilla
#endif // MOZILLA_GFX_RENDEREGLIMAGETEXTUREHOST_H