fune/dom/media/platforms/wrappers/MediaDataDecoderProxy.cpp
Jean-Yves Avenard 5be22726b0 Bug 1650696 - P4. Remove the expectation for a MediaDataDecoder to work on a specified TaskQueue. r=jolin
It will now be up to the caller to determine where the decoder is going to run. This allows to simplify the audio decoders so that they can run synchronously and be wrapped in a Wasm sandbox (which doesn't support multi-threading)

The structure guarantees that all MediaDataDecoder methods are called on the same thread it's been initialised.

To achieve this, wherever a MediaDataDecoder was created, we wrap it in a MediaDataDecoderProxy that ensures that all methods are running on the given thread.

We keep the behaviour of all methods in all MediaDataDecoder to assert that they are running on the expected thread for diagnostic purposes. It could go in the future.

Video decoders that could block excessingly the thread on which they are called are made to run on their own task queue.
The Apple decoder is mostly entirely asynchronous, with the exception of the drain method which could block.
We exclude the android and omx decoders are the framework they use is 100% asynchronous and already operate on another thread.

Differential Revision: https://phabricator.services.mozilla.com/D86929
2020-08-17 23:52:21 +00:00

137 lines
3.8 KiB
C++

/* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim:set ts=2 sw=2 sts=2 et cindent: */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#include "MediaDataDecoderProxy.h"
namespace mozilla {
RefPtr<MediaDataDecoder::InitPromise> MediaDataDecoderProxy::Init() {
MOZ_ASSERT(!mIsShutdown);
if (!mProxyThread) {
return mProxyDecoder->Init();
}
return InvokeAsync(mProxyThread, __func__, [self = RefPtr{this}] {
return self->mProxyDecoder->Init();
});
}
RefPtr<MediaDataDecoder::DecodePromise> MediaDataDecoderProxy::Decode(
MediaRawData* aSample) {
MOZ_ASSERT(!mIsShutdown);
if (!mProxyThread) {
return mProxyDecoder->Decode(aSample);
}
RefPtr<MediaRawData> sample = aSample;
return InvokeAsync(mProxyThread, __func__, [self = RefPtr{this}, sample] {
return self->mProxyDecoder->Decode(sample);
});
}
bool MediaDataDecoderProxy::CanDecodeBatch() const {
return mProxyDecoder->CanDecodeBatch();
}
RefPtr<MediaDataDecoder::DecodePromise> MediaDataDecoderProxy::DecodeBatch(
nsTArray<RefPtr<MediaRawData>>&& aSamples) {
MOZ_ASSERT(!mIsShutdown);
if (!mProxyThread) {
return mProxyDecoder->DecodeBatch(std::move(aSamples));
}
return InvokeAsync(
mProxyThread, __func__,
[self = RefPtr{this}, samples = std::move(aSamples)]() mutable {
return self->mProxyDecoder->DecodeBatch(std::move(samples));
});
}
RefPtr<MediaDataDecoder::FlushPromise> MediaDataDecoderProxy::Flush() {
MOZ_ASSERT(!mIsShutdown);
if (!mProxyThread) {
return mProxyDecoder->Flush();
}
return InvokeAsync(mProxyThread, __func__, [self = RefPtr{this}] {
return self->mProxyDecoder->Flush();
});
}
RefPtr<MediaDataDecoder::DecodePromise> MediaDataDecoderProxy::Drain() {
MOZ_ASSERT(!mIsShutdown);
if (!mProxyThread) {
return mProxyDecoder->Drain();
}
return InvokeAsync(mProxyThread, __func__, [self = RefPtr{this}] {
return self->mProxyDecoder->Drain();
});
}
RefPtr<ShutdownPromise> MediaDataDecoderProxy::Shutdown() {
MOZ_ASSERT(!mIsShutdown);
#if defined(DEBUG)
mIsShutdown = true;
#endif
if (!mProxyThread) {
return mProxyDecoder->Shutdown();
}
// We chain another promise to ensure that the proxied decoder gets destructed
// on the proxy thread.
return InvokeAsync(mProxyThread, __func__, [self = RefPtr{this}] {
RefPtr<ShutdownPromise> p = self->mProxyDecoder->Shutdown()->Then(
self->mProxyThread, __func__,
[self](const ShutdownPromise::ResolveOrRejectValue& aResult) {
self->mProxyDecoder = nullptr;
return ShutdownPromise::CreateAndResolveOrReject(aResult, __func__);
});
return p;
});
}
nsCString MediaDataDecoderProxy::GetDescriptionName() const {
MOZ_ASSERT(!mIsShutdown);
return mProxyDecoder->GetDescriptionName();
}
bool MediaDataDecoderProxy::IsHardwareAccelerated(
nsACString& aFailureReason) const {
MOZ_ASSERT(!mIsShutdown);
return mProxyDecoder->IsHardwareAccelerated(aFailureReason);
}
void MediaDataDecoderProxy::SetSeekThreshold(const media::TimeUnit& aTime) {
MOZ_ASSERT(!mIsShutdown);
if (!mProxyThread) {
mProxyDecoder->SetSeekThreshold(aTime);
return;
}
media::TimeUnit time = aTime;
mProxyThread->Dispatch(NS_NewRunnableFunction(
"MediaDataDecoderProxy::SetSeekThreshold", [self = RefPtr{this}, time] {
self->mProxyDecoder->SetSeekThreshold(time);
}));
}
bool MediaDataDecoderProxy::SupportDecoderRecycling() const {
MOZ_ASSERT(!mIsShutdown);
return mProxyDecoder->SupportDecoderRecycling();
}
MediaDataDecoder::ConversionRequired MediaDataDecoderProxy::NeedsConversion()
const {
MOZ_ASSERT(!mIsShutdown);
return mProxyDecoder->NeedsConversion();
}
} // namespace mozilla