forked from mirrors/gecko-dev
# ignore-this-changeset Differential Revision: https://phabricator.services.mozilla.com/D35940 --HG-- extra : source : d214f0c82813e5a8d3987debc490a2c11f1308ff
70 lines
2.1 KiB
JavaScript
70 lines
2.1 KiB
JavaScript
/**
|
|
* @fileoverview Reject use of non-zero values in setTimeout
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
// -----------------------------------------------------------------------------
|
|
// Rule Definition
|
|
// -----------------------------------------------------------------------------
|
|
|
|
var helpers = require("../helpers");
|
|
var testTypes = new Set(["browser", "xpcshell"]);
|
|
|
|
module.exports = {
|
|
meta: {
|
|
docs: {
|
|
description: "disallow setTimeout with non-zero values in tests",
|
|
category: "Best Practices",
|
|
},
|
|
schema: [],
|
|
},
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Public
|
|
// --------------------------------------------------------------------------
|
|
|
|
create(context) {
|
|
return {
|
|
CallExpression(node) {
|
|
// We don't want to run this on mochitest plain as it already
|
|
// prevents flaky setTimeout at runtime. This check is built-in
|
|
// to the rule itself as sometimes other tests can live alongside
|
|
// plain mochitests and so it can't be configured via eslintrc.
|
|
if (!testTypes.has(helpers.getTestType(context))) {
|
|
return;
|
|
}
|
|
|
|
let callee = node.callee;
|
|
if (callee.type === "MemberExpression") {
|
|
if (
|
|
callee.property.name !== "setTimeout" ||
|
|
callee.object.name !== "window" ||
|
|
node.arguments.length < 2
|
|
) {
|
|
return;
|
|
}
|
|
} else if (callee.type === "Identifier") {
|
|
if (callee.name !== "setTimeout" || node.arguments.length < 2) {
|
|
return;
|
|
}
|
|
} else {
|
|
return;
|
|
}
|
|
|
|
let timeout = node.arguments[1];
|
|
if (timeout.type !== "Literal" || timeout.value > 0) {
|
|
context.report(
|
|
node,
|
|
"listen for events instead of setTimeout() " +
|
|
"with arbitrary delay"
|
|
);
|
|
}
|
|
},
|
|
};
|
|
},
|
|
};
|