forked from mirrors/gecko-dev
5c7cdbd4ba
# ignore-this-changeset Differential Revision: https://phabricator.services.mozilla.com/D35940 --HG-- extra : source : d214f0c82813e5a8d3987debc490a2c11f1308ff
45 lines
1.4 KiB
JavaScript
45 lines
1.4 KiB
JavaScript
/**
|
|
* @fileoverview Use .includes instead of .indexOf
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
// -----------------------------------------------------------------------------
|
|
// Rule Definition
|
|
// -----------------------------------------------------------------------------
|
|
|
|
module.exports = function(context) {
|
|
// ---------------------------------------------------------------------------
|
|
// Public
|
|
// --------------------------------------------------------------------------
|
|
|
|
return {
|
|
BinaryExpression(node) {
|
|
if (
|
|
node.left.type != "CallExpression" ||
|
|
node.left.callee.type != "MemberExpression" ||
|
|
node.left.callee.property.type != "Identifier" ||
|
|
node.left.callee.property.name != "indexOf"
|
|
) {
|
|
return;
|
|
}
|
|
|
|
if (
|
|
(["!=", "!==", "==", "==="].includes(node.operator) &&
|
|
node.right.type == "UnaryExpression" &&
|
|
node.right.operator == "-" &&
|
|
node.right.argument.type == "Literal" &&
|
|
node.right.argument.value == 1) ||
|
|
([">=", "<"].includes(node.operator) &&
|
|
node.right.type == "Literal" &&
|
|
node.right.value == 0)
|
|
) {
|
|
context.report(node, "use .includes instead of .indexOf");
|
|
}
|
|
},
|
|
};
|
|
};
|