fune/browser/installer/windows/nsis
Adam Gashlin 6b6c4da4b5 Bug 1696772 - Don't use FILE_FLAG_DELETE_ON_CLOSE for multi-instance locks. r=nalexander,application-update-reviewers.
FILE_FLAG_DELETE_ON_CLOSE had the wrong semantics, rendering the lock
file unusable after it had been closed once.

Delete the lock file in the uninstaller as a simple alternative (given that
the lock file is not in a temporary location on Windows).

For a test I returned to the older form of
test_backgroundtask_update_sync_manager which initially exposed the issue:
It expects the background task to be able to detect the xpcshell instance
after running resetLock, which failed before this fix.
I also extended the original updateSyncManager test to run the second
copy twice, which also catches the issue.

Differential Revision: https://phabricator.services.mozilla.com/D109565
2021-03-24 20:36:06 +00:00
..
content
defines.nsi.in Bug 1691951 - Make Windows install not register "ftp" protocol handler. r=application-update-reviewers,bytesized 2021-02-22 17:52:24 +00:00
extensionsLocale.nsh
installer.nsi Bug 1660198 - Part 1: Write installation telemetry. r=bytesized 2021-01-28 18:28:20 +00:00
maintenanceservice_installer.nsi
shared.nsh Bug 1691951 - Make Windows install not register "ftp" protocol handler. r=application-update-reviewers,bytesized 2021-02-22 17:52:24 +00:00
stub.nsi
uninstaller.nsi Bug 1696772 - Don't use FILE_FLAG_DELETE_ON_CLOSE for multi-instance locks. r=nalexander,application-update-reviewers. 2021-03-24 20:36:06 +00:00
updater_append.ini