nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
fune/widget/tests
History
Markus Stange e4245a36ed Bug 1699792 - Fix a bug in the handling of dynamic collapsed/hidden attribute changes. r=harry 
In the case of nsStandaloneNativeMenu, the root nsMenuX has the nsStandaloneNativeMenu as its parent.
But the parent's NativeNSMenu() is the root nsMenuX's NativeNSMenu().
So when we were removing the collapsed="true" attribute from the root nsMenuX of an nsStandaloneNativeMenu,
`parentMenu` and `mNativeMenu` were the same object. So we would insert mNativeMenuItem into mNativeMenu (as a subitem),
and then also set mNativeMenuItem.submenu = mNativeMenu, creating a cyclic menu structure.

I've added a test for this scenario.
It turns out though that without this patch, the test doesn't actually fail, because the collapsed attribute
handling also calls SetRebuild(true). So while the test would briefly create the cyclic structure, this
bug would be corrected by the MenuOpened calls which would rebuild the menu contents, and then all the
checks from the test would still succeed.

Depends on D109113

Differential Revision: https://phabricator.services.mozilla.com/D109114
2021-03-23 13:40:24 +00:00
..
browser Bug 1677049 - Skip problematic mochitest-bc tests in TSan. r=Gankro,preferences-reviewers 2020-12-01 20:21:20 +00:00
gtest Bug 1676771 - Add a TouchResampler class. r=kats 2020-11-18 03:57:35 +00:00
unit Bug 1651774: Update mozilla/use-services rule for native Services implementation. r=Standard8 2020-11-06 18:58:33 +00:00
.eslintrc.js
bug586713_window.xhtml
chrome.ini Bug 1661132 - Make test_bug596600.xhtml wait proper event after syntheisizing native mousemove event r=smaug 2021-02-24 07:01:16 +00:00
empty_window.xhtml
file_bug596600.html
file_input_events_on_deactive_window.html
file_secure_input.html
mochitest.ini
moz.build Bug 1675313 - Don't update IMEState during composition when element.focus() is called. r=masayuki 2020-11-08 08:36:58 +00:00
native_menus_window.xhtml Bug 1656280 - Enable remaining ESLint rules for widget/test/*.xhtml files. r=mhowell 2020-10-26 17:37:26 +00:00
standalone_native_menu_window.xhtml Bug 1699792 - Fix a bug in the handling of dynamic collapsed/hidden attribute changes. r=harry 2021-03-23 13:40:24 +00:00
system_font_changes.xhtml Bug 1656280 - Enable remaining ESLint rules for widget/test/*.xhtml files. r=mhowell 2020-10-26 17:37:26 +00:00
taskbar_previews.xhtml Bug 1651774: Update mozilla/use-services rule for native Services implementation. r=Standard8 2020-11-06 18:58:33 +00:00
test_actionhint.html
test_AltGr_key_events_in_web_content_on_windows.html
test_alwaysontop_focus.xhtml
test_assign_event_data.html Bug 1688105 - Part 2: Get rid of dom.w3c_pointer_events.enabled; r=smaug 2021-01-25 16:22:44 +00:00
test_autocapitalize.html
test_bug343416.xhtml Bug 1656280 - Enable remaining ESLint rules for widget/test/*.xhtml files. r=mhowell 2020-10-26 17:37:26 +00:00
test_bug413277.html
test_bug428405.xhtml Bug 1651774: Update mozilla/use-services rule for native Services implementation. r=Standard8 2020-11-06 18:58:33 +00:00
test_bug429954.xhtml Bug 1651774: Update mozilla/use-services rule for native Services implementation. r=Standard8 2020-11-06 18:58:33 +00:00
test_bug444800.xhtml
test_bug466599.xhtml Bug 1689827 - Remove length parameter from JS callers of setTransferData. r=smaug 2021-02-01 12:05:12 +00:00
test_bug478536.xhtml
test_bug485118.xhtml Bug 1656280 - Enable remaining ESLint rules for widget/test/*.xhtml files. r=mhowell 2020-10-26 17:37:26 +00:00
test_bug517396.xhtml Bug 1651774: Update mozilla/use-services rule for native Services implementation. r=Standard8 2020-11-06 18:58:33 +00:00
test_bug522217.xhtml
test_bug538242.xhtml
test_bug565392.html
test_bug586713.xhtml
test_bug593307.xhtml
test_bug596600.xhtml Bug 1661132 - Make test_bug596600.xhtml wait proper event after syntheisizing native mousemove event r=smaug 2021-02-24 07:01:16 +00:00
test_bug673301.xhtml Bug 1689827 - Remove length parameter from JS callers of setTransferData. r=smaug 2021-02-01 12:05:12 +00:00
test_bug760802.xhtml Bug 1651774: Update mozilla/use-services rule for native Services implementation. r=Standard8 2020-11-06 18:58:33 +00:00
test_bug1123480.xhtml Bug 1689827 - Remove length parameter from JS callers of setTransferData. r=smaug 2021-02-01 12:05:12 +00:00
test_clipboard.xhtml Bug 1651774: Update mozilla/use-services rule for native Services implementation. r=Standard8 2020-11-06 18:58:33 +00:00
test_composition_text_querycontent.xhtml
test_imestate.html Bug 1683226 - part 2: Make HTMLEmbedElement and HTMLObjectElement stop overriding nsIContent::GetDesiredIMEState() r=smaug 2020-12-21 05:52:26 +00:00
test_input_events_on_deactive_window.xhtml Bug 1651774: Update mozilla/use-services rule for native Services implementation. r=Standard8 2020-11-06 18:58:33 +00:00
test_key_event_counts.xhtml Bug 1656280 - Enable remaining ESLint rules for widget/test/*.xhtml files. r=mhowell 2020-10-26 17:37:26 +00:00
test_keycodes.xhtml Bug 1651774: Update mozilla/use-services rule for native Services implementation. r=Standard8 2020-11-06 18:58:33 +00:00
test_keypress_event_with_alt_on_mac.html
test_mouse_event_with_control_on_mac.html Bug 1691622 - part 6: Merge synthesizeNativeMouseClick* with synthesizeNativeMouseEvent* r=smaug 2021-02-24 01:27:08 +00:00
test_mouse_scroll.xhtml Bug 1552168: Remove pref security.data_uri.unique_opaque_origin. r=smaug 2020-10-08 16:55:25 +00:00
test_native_key_bindings_mac.html
test_native_menus.xhtml
test_panel_mouse_coords.xhtml Bug 1691622 - part 11: Make mochitests stop using nsIDOMWindowUtils.sendNativeMouseEvent directly as far as possible r=smaug 2021-02-24 01:27:11 +00:00
test_picker_no_crash.html
test_platform_colors.xhtml
test_plugin_scroll_consistency.html
test_position_on_resize.xhtml
test_scrollbar_colors.html Bug 1695965 - Update test_scrollbar_colors expectations for windows+nnt. r=mstange 2021-03-02 19:20:18 +00:00
test_secure_input.html
test_sizemode_events.xhtml Bug 1656280 - Enable remaining ESLint rules for widget/test/*.xhtml files. r=mhowell 2020-10-26 17:37:26 +00:00
test_standalone_native_menu.xhtml
test_system_font_changes.xhtml
test_system_status_bar.xhtml
test_taskbar_progress.xhtml Bug 1651774: Update mozilla/use-services rule for native Services implementation. r=Standard8 2020-11-06 18:58:33 +00:00
test_transferable_overflow.xhtml Bug 1689827 - Remove length parameter from JS callers of setTransferData. r=smaug 2021-02-01 12:05:12 +00:00
test_wheeltransaction.xhtml
TestChromeMargin.cpp
utils.js
window_bug429954.xhtml
window_bug478536.xhtml Bug 1656280 - Enable remaining ESLint rules for widget/test/*.xhtml files. r=mhowell 2020-10-26 17:37:26 +00:00
window_bug522217.xhtml
window_bug538242.xhtml
window_bug593307_centerscreen.xhtml
window_bug593307_offscreen.xhtml
window_composition_text_querycontent.xhtml Bug 1678844 - Don't call SetInputContext on keyboard event. r=masayuki 2020-12-09 07:02:19 +00:00
window_imestate_iframes.html
window_mouse_scroll_win.html Bug 1552168: Remove pref security.data_uri.unique_opaque_origin. r=smaug 2020-10-08 16:55:25 +00:00
window_mouse_scroll_win_2.html Bug 1552168: Remove pref security.data_uri.unique_opaque_origin. r=smaug 2020-10-08 16:55:25 +00:00
window_picker_no_crash_child.html
window_state_windows.xhtml Bug 1651774: Update mozilla/use-services rule for native Services implementation. r=Standard8 2020-11-06 18:58:33 +00:00
window_wheeltransaction.xhtml Bug 1656280 - Enable remaining ESLint rules for widget/test/*.xhtml files. r=mhowell 2020-10-26 17:37:26 +00:00