forked from mirrors/gecko-dev
653eddd3d8
This fixes https://github.com/servo/servo/issues/861. @askeing, I've copied your work from https://github.com/askeing/servo_tidy and attributed the commit to you. My commit in this PR is Git housekeeping to preserve `tidy`'s history. If you'd like to make additional changes, I've given you and @shinglyu push access to my fork of Servo. Apologies if this is already familiar, but the workflow for pushing to my branch is: ``` $ git remote add edunham git@github.com:edunham/servo.git $ git checkout -b package-tidy $ git pull edunham package-tidy $ git push edunham package-tidy ``` Once this lands, I'll look at how to publish it to PyPI and automate that process. Please don't merge this yet; we still need to discuss how the change should work around https://github.com/servo/servo/blob/master/python/servo/testing_commands.py#L33 , as I've yet to figure out how to get the egg to actually expose its tests. Source-Repo: https://github.com/servo/servo Source-Revision: bfe54539d290cb287e59e8ba106a54a3fab6201a --HG-- rename : servo/python/tidy_self_test/__init__.py => servo/python/tidy/servo_tidy/__init__.py rename : servo/python/licenseck.py => servo/python/tidy/servo_tidy/licenseck.py rename : servo/python/tidy.py => servo/python/tidy/servo_tidy/tidy.py rename : servo/python/servo/__init__.py => servo/python/tidy/servo_tidy_tests/__init__.py rename : servo/python/tidy_self_test/incorrect_license.rs => servo/python/tidy/servo_tidy_tests/incorrect_license.rs rename : servo/python/tidy_self_test/long_line.rs => servo/python/tidy/servo_tidy_tests/long_line.rs rename : servo/python/tidy_self_test/rust_tidy.rs => servo/python/tidy/servo_tidy_tests/rust_tidy.rs rename : servo/python/tidy_self_test/spec.webidl => servo/python/tidy/servo_tidy_tests/spec.webidl rename : servo/python/tidy_self_test/speclink.rs => servo/python/tidy/servo_tidy_tests/speclink.rs rename : servo/python/tidy_self_test/test.toml => servo/python/tidy/servo_tidy_tests/test.toml rename : servo/python/tidy_self_test/tidy_self_test.py => servo/python/tidy/servo_tidy_tests/test_tidy.py rename : servo/python/tidy_self_test/tidy_self_test.py => servo/python/tidy/servo_tidy_tests/tidy_self_test.py rename : servo/python/tidy_self_test/whatwg_link.rs => servo/python/tidy/servo_tidy_tests/whatwg_link.rs rename : servo/python/tidy_self_test/wrong_space.rs => servo/python/tidy/servo_tidy_tests/wrong_space.rs
75 lines
3.9 KiB
Python
75 lines
3.9 KiB
Python
# Copyright 2013 The Servo Project Developers. See the COPYRIGHT
|
|
# file at the top-level directory of this distribution.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
|
# http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
|
# <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
|
# option. This file may not be copied, modified, or distributed
|
|
# except according to those terms.
|
|
|
|
import os
|
|
import unittest
|
|
from servo_tidy import tidy
|
|
|
|
|
|
def iterFile(name):
|
|
path = 'servo_tidy_tests/' if os.path.exists('servo_tidy_tests/') else 'python/tidy/servo_tidy_tests/'
|
|
return iter([os.path.join(path, name)])
|
|
|
|
|
|
class CheckTidiness(unittest.TestCase):
|
|
def test_spaces_correctnes(self):
|
|
errors = tidy.collect_errors_for_files(iterFile('wrong_space.rs'), [], [tidy.check_by_line])
|
|
self.assertEqual('trailing whitespace', errors.next()[2])
|
|
self.assertEqual('no newline at EOF', errors.next()[2])
|
|
self.assertEqual('tab on line', errors.next()[2])
|
|
self.assertEqual('CR on line', errors.next()[2])
|
|
|
|
def test_long_line(self):
|
|
errors = tidy.collect_errors_for_files(iterFile('long_line.rs'), [], [tidy.check_by_line])
|
|
self.assertEqual('Line is longer than 120 characters', errors.next()[2])
|
|
|
|
def test_whatwg_link(self):
|
|
errors = tidy.collect_errors_for_files(iterFile('whatwg_link.rs'), [], [tidy.check_by_line])
|
|
self.assertTrue('link to WHATWG may break in the future, use this format instead:' in errors.next()[2])
|
|
self.assertTrue('links to WHATWG single-page url, change to multi page:' in errors.next()[2])
|
|
|
|
def test_licence(self):
|
|
errors = tidy.collect_errors_for_files(iterFile('incorrect_license.rs'), [], [tidy.check_license])
|
|
self.assertEqual('incorrect license', errors.next()[2])
|
|
|
|
def test_rust(self):
|
|
errors = tidy.collect_errors_for_files(iterFile('rust_tidy.rs'), [], [tidy.check_rust])
|
|
self.assertEqual('use statement spans multiple lines', errors.next()[2])
|
|
self.assertEqual('missing space before }', errors.next()[2])
|
|
self.assertTrue('use statement is not in alphabetical order' in errors.next()[2])
|
|
self.assertEqual('encountered whitespace following a use statement', errors.next()[2])
|
|
self.assertTrue('mod declaration is not in alphabetical order' in errors.next()[2])
|
|
self.assertEqual('mod declaration spans multiple lines', errors.next()[2])
|
|
self.assertTrue('extern crate declaration is not in alphabetical order' in errors.next()[2])
|
|
self.assertEqual('missing space before ->', errors.next()[2])
|
|
self.assertEqual('missing space after ->', errors.next()[2])
|
|
self.assertEqual('missing space after :', errors.next()[2])
|
|
self.assertEqual('missing space before {', errors.next()[2])
|
|
self.assertEqual('missing space before =', errors.next()[2])
|
|
self.assertEqual('missing space after =', errors.next()[2])
|
|
self.assertEqual('missing space before -', errors.next()[2])
|
|
self.assertEqual('missing space before *', errors.next()[2])
|
|
self.assertEqual('missing space after =>', errors.next()[2])
|
|
self.assertEqual('extra space before :', errors.next()[2])
|
|
self.assertEqual('extra space before :', errors.next()[2])
|
|
self.assertEqual('use &[T] instead of &Vec<T>', errors.next()[2])
|
|
self.assertEqual('use &str instead of &String', errors.next()[2])
|
|
|
|
def test_webidl(self):
|
|
errors = tidy.collect_errors_for_files(iterFile('spec.webidl'), [tidy.check_webidl_spec], [])
|
|
self.assertEqual('No specification link found.', errors.next()[2])
|
|
|
|
def test_toml(self):
|
|
errors = tidy.collect_errors_for_files(iterFile('test.toml'), [tidy.check_toml], [])
|
|
self.assertEqual('found asterisk instead of minimum version number', errors.next()[2])
|
|
|
|
|
|
def do_tests():
|
|
suite = unittest.TestLoader().loadTestsFromTestCase(CheckTidiness)
|
|
unittest.TextTestRunner(verbosity=2).run(suite)
|