forked from mirrors/gecko-dev
91b071ed14
gfx::Color is currently misused in many places. The DrawTargets expect the color space to be in device space, e.g. what we are actually going to draw using. Everything sitting above generally deals with sRGB, as specified in CSS. Sometimes we missed the conversion from sRGB to device space when issuing draw calls, and similarly sometimes we converted the color to device space twice. This patch splits the type in two. sRGBColor and DeviceColor now represent sRGB and device color spaces respectively. DrawTarget only accepts DeviceColor, and one can get a DeviceColor from an sRGBColor via the ToDeviceColor helper API. The reftests now pass with color management enabled for everything (e.g. CSS) instead of just tagged raster images. There will be a follow up patch to enable color management everywhere by default on all supported platforms. Differential Revision: https://phabricator.services.mozilla.com/D64771 --HG-- extra : moz-landing-system : lando
38 lines
1.1 KiB
C++
38 lines
1.1 KiB
C++
/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#pragma once
|
|
|
|
#include "2D.h"
|
|
#include "TestBase.h"
|
|
|
|
#define DT_WIDTH 500
|
|
#define DT_HEIGHT 500
|
|
|
|
/* This general DrawTarget test class can be reimplemented by a child class
|
|
* with optional additional drawtarget-specific tests. And is intended to run
|
|
* on a 500x500 32 BPP drawtarget.
|
|
*/
|
|
class TestDrawTargetBase : public TestBase {
|
|
public:
|
|
void Initialized();
|
|
void FillCompletely();
|
|
void FillRect();
|
|
|
|
protected:
|
|
TestDrawTargetBase();
|
|
|
|
void RefreshSnapshot();
|
|
|
|
void VerifyAllPixels(const mozilla::gfx::DeviceColor& aColor);
|
|
void VerifyPixel(const mozilla::gfx::IntPoint& aPoint,
|
|
mozilla::gfx::DeviceColor& aColor);
|
|
|
|
uint32_t RGBAPixelFromColor(const mozilla::gfx::DeviceColor& aColor);
|
|
|
|
RefPtr<mozilla::gfx::DrawTarget> mDT;
|
|
RefPtr<mozilla::gfx::DataSourceSurface> mDataSnapshot;
|
|
};
|