forked from mirrors/gecko-dev
CLOSED TREE Backed out changeset e41f9295ee00 (bug 1396066) Backed out changeset 7a22efa8df6b (bug 1396066) Backed out changeset ed95eea7105c (bug 1396066) Backed out changeset 635746c88630 (bug 1396066) Backed out changeset 5b1997aeaead (bug 1396066) Backed out changeset 19c9ea492f5e (bug 1396066) Backed out changeset b9d8e4588584 (bug 1396066) Backed out changeset 87b44ea10407 (bug 1396066) Backed out changeset e5b9aed44133 (bug 1396066) MozReview-Commit-ID: K9q3MfPBc5E
390 lines
14 KiB
JavaScript
390 lines
14 KiB
JavaScript
/* Any copyright is dedicated to the Public Domain.
|
|
* http://creativecommons.org/publicdomain/zero/1.0/ */
|
|
|
|
/* This list allows pre-existing or 'unfixable' CSS issues to remain, while we
|
|
* detect newly occurring issues in shipping CSS. It is a list of objects
|
|
* specifying conditions under which an error should be ignored.
|
|
*
|
|
* Every property of the objects in it needs to consist of a regular expression
|
|
* matching the offending error. If an object has multiple regex criteria, they
|
|
* ALL need to match an error in order for that error not to cause a test
|
|
* failure. */
|
|
let whitelist = [
|
|
// CodeMirror is imported as-is, see bug 1004423.
|
|
{sourceName: /codemirror\.css$/i,
|
|
isFromDevTools: true},
|
|
// The debugger uses cross-browser CSS.
|
|
{sourceName: /devtools\/client\/debugger\/new\/debugger.css/i,
|
|
isFromDevTools: true},
|
|
// Reps uses cross-browser CSS.
|
|
{sourceName: /devtools-client-shared\/components\/reps\/reps.css/i,
|
|
isFromDevTools: true},
|
|
// PDFjs is futureproofing its pseudoselectors, and those rules are dropped.
|
|
{sourceName: /web\/viewer\.css$/i,
|
|
errorMessage: /Unknown pseudo-class.*(fullscreen|selection)/i,
|
|
isFromDevTools: false},
|
|
// PDFjs rules needed for compat with other UAs.
|
|
{sourceName: /web\/viewer\.css$/i,
|
|
errorMessage: /Unknown property.*appearance/i,
|
|
isFromDevTools: false},
|
|
// Tracked in bug 1004428.
|
|
{sourceName: /aboutaccounts\/(main|normalize)\.css$/i,
|
|
isFromDevTools: false},
|
|
// Highlighter CSS uses a UA-only pseudo-class, see bug 985597.
|
|
{sourceName: /highlighters\.css$/i,
|
|
errorMessage: /Unknown pseudo-class.*moz-native-anonymous/i,
|
|
isFromDevTools: true},
|
|
// Responsive Design Mode CSS uses a UA-only pseudo-class, see Bug 1241714.
|
|
{sourceName: /responsive-ua\.css$/i,
|
|
errorMessage: /Unknown pseudo-class.*moz-dropdown-list/i,
|
|
isFromDevTools: true},
|
|
|
|
{sourceName: /\b(contenteditable|EditorOverride|svg|forms|html|mathml|ua)\.css$/i,
|
|
errorMessage: /Unknown pseudo-class.*-moz-/i,
|
|
isFromDevTools: false},
|
|
{sourceName: /\b(html|mathml|ua)\.css$/i,
|
|
errorMessage: /Unknown property.*-moz-/i,
|
|
isFromDevTools: false},
|
|
// Reserved to UA sheets unless layout.css.overflow-clip-box.enabled flipped to true.
|
|
{sourceName: /(?:res|gre-resources)\/forms\.css$/i,
|
|
errorMessage: /Unknown property.*overflow-clip-box/i,
|
|
isFromDevTools: false},
|
|
// These variables are declared somewhere else, and error when we load the
|
|
// files directly. They're all marked intermittent because their appearance
|
|
// in the error console seems to not be consistent.
|
|
{sourceName: /jsonview\/css\/general\.css$/i,
|
|
intermittent: true,
|
|
errorMessage: /Property contained reference to invalid variable.*color/i,
|
|
isFromDevTools: true},
|
|
{sourceName: /webide\/skin\/logs\.css$/i,
|
|
intermittent: true,
|
|
errorMessage: /Property contained reference to invalid variable.*color/i,
|
|
isFromDevTools: true},
|
|
{sourceName: /webide\/skin\/logs\.css$/i,
|
|
intermittent: true,
|
|
errorMessage: /Property contained reference to invalid variable.*background/i,
|
|
isFromDevTools: true},
|
|
{sourceName: /devtools\/skin\/animationinspector\.css$/i,
|
|
intermittent: true,
|
|
errorMessage: /Property contained reference to invalid variable.*color/i,
|
|
isFromDevTools: true},
|
|
];
|
|
|
|
if (!Services.prefs.getBoolPref("full-screen-api.unprefix.enabled")) {
|
|
whitelist.push({
|
|
sourceName: /(?:res|gre-resources)\/(ua|html)\.css$/i,
|
|
errorMessage: /Unknown pseudo-class .*\bfullscreen\b/i,
|
|
isFromDevTools: false
|
|
});
|
|
}
|
|
|
|
// Platform can be "linux", "macosx" or "win". If omitted, the exception applies to all platforms.
|
|
let allowedImageReferences = [
|
|
// Bug 1302691
|
|
{file: "chrome://devtools/skin/images/dock-bottom-minimize@2x.png",
|
|
from: "chrome://devtools/skin/toolbox.css",
|
|
isFromDevTools: true},
|
|
{file: "chrome://devtools/skin/images/dock-bottom-maximize@2x.png",
|
|
from: "chrome://devtools/skin/toolbox.css",
|
|
isFromDevTools: true},
|
|
];
|
|
|
|
// Add suffix to stylesheets' URI so that we always load them here and
|
|
// have them parsed. Add a random number so that even if we run this
|
|
// test multiple times, it would be unlikely to affect each other.
|
|
const kPathSuffix = "?always-parse-css-" + Math.random();
|
|
|
|
/**
|
|
* Check if an error should be ignored due to matching one of the whitelist
|
|
* objects defined in whitelist
|
|
*
|
|
* @param aErrorObject the error to check
|
|
* @return true if the error should be ignored, false otherwise.
|
|
*/
|
|
function ignoredError(aErrorObject) {
|
|
for (let whitelistItem of whitelist) {
|
|
let matches = true;
|
|
for (let prop of ["sourceName", "errorMessage"]) {
|
|
if (whitelistItem.hasOwnProperty(prop) &&
|
|
!whitelistItem[prop].test(aErrorObject[prop] || "")) {
|
|
matches = false;
|
|
break;
|
|
}
|
|
}
|
|
if (matches) {
|
|
whitelistItem.used = true;
|
|
return true;
|
|
}
|
|
}
|
|
return false;
|
|
}
|
|
|
|
var gChromeReg = Cc["@mozilla.org/chrome/chrome-registry;1"]
|
|
.getService(Ci.nsIChromeRegistry);
|
|
var gChromeMap = new Map();
|
|
|
|
var resHandler = Services.io.getProtocolHandler("resource")
|
|
.QueryInterface(Ci.nsIResProtocolHandler);
|
|
var gResourceMap = [];
|
|
function trackResourcePrefix(prefix) {
|
|
let uri = Services.io.newURI("resource://" + prefix + "/");
|
|
gResourceMap.unshift([prefix, resHandler.resolveURI(uri)]);
|
|
}
|
|
trackResourcePrefix("gre");
|
|
trackResourcePrefix("app");
|
|
|
|
function getBaseUriForChromeUri(chromeUri) {
|
|
let chromeFile = chromeUri + "gobbledygooknonexistentfile.reallynothere";
|
|
let uri = Services.io.newURI(chromeFile);
|
|
let fileUri = gChromeReg.convertChromeURL(uri);
|
|
return fileUri.resolve(".");
|
|
}
|
|
|
|
function parseManifest(manifestUri) {
|
|
return fetchFile(manifestUri.spec).then(data => {
|
|
for (let line of data.split("\n")) {
|
|
let [type, ...argv] = line.split(/\s+/);
|
|
if (type == "content" || type == "skin") {
|
|
let chromeUri = `chrome://${argv[0]}/${type}/`;
|
|
gChromeMap.set(getBaseUriForChromeUri(chromeUri), chromeUri);
|
|
} else if (type == "resource") {
|
|
trackResourcePrefix(argv[0]);
|
|
}
|
|
}
|
|
});
|
|
}
|
|
|
|
function convertToCodeURI(fileUri) {
|
|
let baseUri = fileUri;
|
|
let path = "";
|
|
while (true) {
|
|
let slashPos = baseUri.lastIndexOf("/", baseUri.length - 2);
|
|
if (slashPos <= 0) {
|
|
// File not accessible from chrome protocol, try resource://
|
|
for (let res of gResourceMap) {
|
|
if (fileUri.startsWith(res[1]))
|
|
return fileUri.replace(res[1], "resource://" + res[0] + "/");
|
|
}
|
|
// Give up and return the original URL.
|
|
return fileUri;
|
|
}
|
|
path = baseUri.slice(slashPos + 1) + path;
|
|
baseUri = baseUri.slice(0, slashPos + 1);
|
|
if (gChromeMap.has(baseUri))
|
|
return gChromeMap.get(baseUri) + path;
|
|
}
|
|
}
|
|
|
|
function messageIsCSSError(msg) {
|
|
// Only care about CSS errors generated by our iframe:
|
|
if ((msg instanceof Ci.nsIScriptError) &&
|
|
msg.category.includes("CSS") &&
|
|
msg.sourceName.endsWith(kPathSuffix)) {
|
|
let sourceName = msg.sourceName.slice(0, -kPathSuffix.length);
|
|
let msgInfo = { sourceName, errorMessage: msg.errorMessage };
|
|
// Check if this error is whitelisted in whitelist
|
|
if (!ignoredError(msgInfo)) {
|
|
ok(false, `Got error message for ${sourceName}: ${msg.errorMessage}`);
|
|
return true;
|
|
}
|
|
info(`Ignored error for ${sourceName} because of filter.`);
|
|
}
|
|
return false;
|
|
}
|
|
|
|
let imageURIsToReferencesMap = new Map();
|
|
|
|
function processCSSRules(sheet) {
|
|
for (let rule of sheet.cssRules) {
|
|
if (rule instanceof CSSMediaRule) {
|
|
processCSSRules(rule);
|
|
continue;
|
|
}
|
|
if (!(rule instanceof CSSStyleRule))
|
|
continue;
|
|
|
|
// Extract urls from the css text.
|
|
// Note: CSSStyleRule.cssText always has double quotes around URLs even
|
|
// when the original CSS file didn't.
|
|
let urls = rule.cssText.match(/url\("[^"]*"\)/g);
|
|
if (!urls)
|
|
continue;
|
|
|
|
for (let url of urls) {
|
|
// Remove the url(" prefix and the ") suffix.
|
|
url = url.replace(/url\("(.*)"\)/, "$1");
|
|
if (url.startsWith("data:"))
|
|
continue;
|
|
|
|
// Make the url absolute and remove the ref.
|
|
let baseURI = Services.io.newURI(rule.parentStyleSheet.href);
|
|
url = Services.io.newURI(url, null, baseURI).specIgnoringRef;
|
|
|
|
// Store the image url along with the css file referencing it.
|
|
let baseUrl = baseURI.spec.split("?always-parse-css")[0];
|
|
if (!imageURIsToReferencesMap.has(url)) {
|
|
imageURIsToReferencesMap.set(url, new Set([baseUrl]));
|
|
} else {
|
|
imageURIsToReferencesMap.get(url).add(baseUrl);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
function chromeFileExists(aURI) {
|
|
let available = 0;
|
|
try {
|
|
let channel = NetUtil.newChannel({uri: aURI, loadUsingSystemPrincipal: true});
|
|
let stream = channel.open();
|
|
let sstream = Cc["@mozilla.org/scriptableinputstream;1"]
|
|
.createInstance(Ci.nsIScriptableInputStream);
|
|
sstream.init(stream);
|
|
available = sstream.available();
|
|
sstream.close();
|
|
} catch (e) {
|
|
if (e.result != Components.results.NS_ERROR_FILE_NOT_FOUND) {
|
|
dump("Checking " + aURI + ": " + e + "\n");
|
|
Cu.reportError(e);
|
|
}
|
|
}
|
|
return available > 0;
|
|
}
|
|
|
|
add_task(async function checkAllTheCSS() {
|
|
// Since we later in this test use Services.console.getMessageArray(),
|
|
// better to not have some messages from previous tests in the array.
|
|
Services.console.reset();
|
|
|
|
let appDir = Services.dirsvc.get("GreD", Ci.nsIFile);
|
|
// This asynchronously produces a list of URLs (sadly, mostly sync on our
|
|
// test infrastructure because it runs against jarfiles there, and
|
|
// our zipreader APIs are all sync)
|
|
let uris = await generateURIsFromDirTree(appDir, [".css", ".manifest"]);
|
|
|
|
// Create a clean iframe to load all the files into. This needs to live at a
|
|
// chrome URI so that it's allowed to load and parse any styles.
|
|
let testFile = getRootDirectory(gTestPath) + "dummy_page.html";
|
|
let HiddenFrame = Cu.import("resource://testing-common/HiddenFrame.jsm", {}).HiddenFrame;
|
|
let hiddenFrame = new HiddenFrame();
|
|
let win = await hiddenFrame.get();
|
|
let iframe = win.document.createElementNS("http://www.w3.org/1999/xhtml", "html:iframe");
|
|
win.document.documentElement.appendChild(iframe);
|
|
let iframeLoaded = BrowserTestUtils.waitForEvent(iframe, "load", true);
|
|
iframe.contentWindow.location = testFile;
|
|
await iframeLoaded;
|
|
let doc = iframe.contentWindow.document;
|
|
|
|
// Parse and remove all manifests from the list.
|
|
// NOTE that this must be done before filtering out devtools paths
|
|
// so that all chrome paths can be recorded.
|
|
let manifestPromises = [];
|
|
uris = uris.filter(uri => {
|
|
if (uri.pathQueryRef.endsWith(".manifest")) {
|
|
manifestPromises.push(parseManifest(uri));
|
|
return false;
|
|
}
|
|
return true;
|
|
});
|
|
// Wait for all manifest to be parsed
|
|
await Promise.all(manifestPromises);
|
|
|
|
// filter out either the devtools paths or the non-devtools paths:
|
|
let isDevtools = SimpleTest.harnessParameters.subsuite == "devtools";
|
|
let devtoolsPathBits = ["webide", "devtools"];
|
|
uris = uris.filter(uri => isDevtools == devtoolsPathBits.some(path => uri.spec.includes(path)));
|
|
|
|
let loadCSS = chromeUri => new Promise(resolve => {
|
|
let linkEl, onLoad, onError;
|
|
onLoad = e => {
|
|
processCSSRules(linkEl.sheet);
|
|
resolve();
|
|
linkEl.removeEventListener("load", onLoad);
|
|
linkEl.removeEventListener("error", onError);
|
|
};
|
|
onError = e => {
|
|
ok(false, "Loading " + linkEl.getAttribute("href") + " threw an error!");
|
|
resolve();
|
|
linkEl.removeEventListener("load", onLoad);
|
|
linkEl.removeEventListener("error", onError);
|
|
};
|
|
linkEl = doc.createElement("link");
|
|
linkEl.setAttribute("rel", "stylesheet");
|
|
linkEl.setAttribute("type", "text/css");
|
|
linkEl.addEventListener("load", onLoad);
|
|
linkEl.addEventListener("error", onError);
|
|
linkEl.setAttribute("href", chromeUri + kPathSuffix);
|
|
doc.head.appendChild(linkEl);
|
|
});
|
|
|
|
// We build a list of promises that get resolved when their respective
|
|
// files have loaded and produced no errors.
|
|
const kInContentCommonCSS = "chrome://global/skin/in-content/common.css";
|
|
let allPromises = uris.map((uri) => convertToCodeURI(uri.spec))
|
|
.filter((uri) => uri !== kInContentCommonCSS);
|
|
|
|
// Make sure chrome://global/skin/in-content/common.css is loaded before other
|
|
// stylesheets in order to guarantee the --in-content variables can be
|
|
// correctly referenced.
|
|
if (allPromises.length !== uris.length) {
|
|
await loadCSS(kInContentCommonCSS);
|
|
}
|
|
|
|
// Wait for all the files to have actually loaded:
|
|
allPromises = allPromises.map(loadCSS);
|
|
await Promise.all(allPromises);
|
|
|
|
// Check if all the files referenced from CSS actually exist.
|
|
for (let [image, references] of imageURIsToReferencesMap) {
|
|
if (!chromeFileExists(image)) {
|
|
for (let ref of references) {
|
|
let ignored = false;
|
|
for (let item of allowedImageReferences) {
|
|
if (image.endsWith(item.file) && ref.endsWith(item.from) &&
|
|
isDevtools == item.isFromDevTools &&
|
|
(!item.platforms || item.platforms.includes(AppConstants.platform))) {
|
|
item.used = true;
|
|
ignored = true;
|
|
break;
|
|
}
|
|
}
|
|
if (!ignored)
|
|
ok(false, "missing " + image + " referenced from " + ref);
|
|
}
|
|
}
|
|
}
|
|
|
|
let messages = Services.console.getMessageArray();
|
|
// Count errors (the test output will list actual issues for us, as well
|
|
// as the ok(false) in messageIsCSSError.
|
|
let errors = messages.filter(messageIsCSSError);
|
|
is(errors.length, 0, "All the styles (" + allPromises.length + ") loaded without errors.");
|
|
|
|
// Confirm that all whitelist rules have been used.
|
|
for (let item of whitelist) {
|
|
if (!item.used && isDevtools == item.isFromDevTools && !item.intermittent) {
|
|
ok(false, "Unused whitelist item. " +
|
|
(item.sourceName ? " sourceName: " + item.sourceName : "") +
|
|
(item.errorMessage ? " errorMessage: " + item.errorMessage : ""));
|
|
}
|
|
}
|
|
|
|
// Confirm that all file whitelist rules have been used.
|
|
for (let item of allowedImageReferences) {
|
|
if (!item.used && isDevtools == item.isFromDevTools &&
|
|
(!item.platforms || item.platforms.includes(AppConstants.platform))) {
|
|
ok(false, "Unused file whitelist item. " +
|
|
" file: " + item.file +
|
|
" from: " + item.from);
|
|
}
|
|
}
|
|
|
|
// Clean up to avoid leaks:
|
|
iframe.remove();
|
|
doc.head.innerHTML = "";
|
|
doc = null;
|
|
iframe = null;
|
|
win = null;
|
|
hiddenFrame.destroy();
|
|
hiddenFrame = null;
|
|
imageURIsToReferencesMap = null;
|
|
});
|