forked from mirrors/gecko-dev
<!-- Please describe your changes on the following line: --> Before this PR, every object reflected in CSSOM is in `Arc<RwLock<_>>` to enable safe (synchronized) mutable aliasing. Acquiring all these locks has significant cost during selector matching: * https://bugzilla.mozilla.org/show_bug.cgi?id=1311469 * https://bugzilla.mozilla.org/show_bug.cgi?id=1335941 * https://bugzilla.mozilla.org/show_bug.cgi?id=1339703 This PR introduce a mechanism to protect many objects with the same `RwLock` that only needs to be acquired once. In Stylo, there is one such lock per process (in a `lazy_static`), used for everything. I non-Stylo Servo, I originally intended to have one such lock per document (for author-origin stylesheets, and one per process for user-agent and user sytlesheets since they’re shared across documents, and never mutated anyway). However I failed to have the same document-specific (or pipeline-specific) `Arc` reachable from both `Document` nodes and `LayoutThread`. Recursively following callers lead me to include this `Arc` in `UnprivilegedPipelineContent`, but that needs to be serializable. So there is a second process-wide lock. This was previously #15998, closed accidentally. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: bb54f0a429de0e8b8861f8071b6cf82f73622664 --HG-- extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear extra : subtree_revision : 851230e57ac8775707df5f0f103be5feac81fc41
102 lines
3.9 KiB
Rust
102 lines
3.9 KiB
Rust
/* This Source Code Form is subject to the terms of the Mozilla Public
|
||
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
||
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
||
|
||
use cssparser::Parser;
|
||
use dom::bindings::codegen::Bindings::CSSMediaRuleBinding;
|
||
use dom::bindings::codegen::Bindings::CSSMediaRuleBinding::CSSMediaRuleMethods;
|
||
use dom::bindings::js::{MutNullableJS, Root};
|
||
use dom::bindings::reflector::{DomObject, reflect_dom_object};
|
||
use dom::bindings::str::DOMString;
|
||
use dom::cssconditionrule::CSSConditionRule;
|
||
use dom::cssrule::SpecificCSSRule;
|
||
use dom::cssstylesheet::CSSStyleSheet;
|
||
use dom::medialist::MediaList;
|
||
use dom::window::Window;
|
||
use dom_struct::dom_struct;
|
||
use std::sync::Arc;
|
||
use style::media_queries::parse_media_query_list;
|
||
use style::shared_lock::{Locked, ToCssWithGuard};
|
||
use style::stylesheets::MediaRule;
|
||
use style_traits::ToCss;
|
||
|
||
#[dom_struct]
|
||
pub struct CSSMediaRule {
|
||
cssconditionrule: CSSConditionRule,
|
||
#[ignore_heap_size_of = "Arc"]
|
||
mediarule: Arc<Locked<MediaRule>>,
|
||
medialist: MutNullableJS<MediaList>,
|
||
}
|
||
|
||
impl CSSMediaRule {
|
||
fn new_inherited(parent_stylesheet: &CSSStyleSheet, mediarule: Arc<Locked<MediaRule>>)
|
||
-> CSSMediaRule {
|
||
let guard = parent_stylesheet.shared_lock().read();
|
||
let list = mediarule.read_with(&guard).rules.clone();
|
||
CSSMediaRule {
|
||
cssconditionrule: CSSConditionRule::new_inherited(parent_stylesheet, list),
|
||
mediarule: mediarule,
|
||
medialist: MutNullableJS::new(None),
|
||
}
|
||
}
|
||
|
||
#[allow(unrooted_must_root)]
|
||
pub fn new(window: &Window, parent_stylesheet: &CSSStyleSheet,
|
||
mediarule: Arc<Locked<MediaRule>>) -> Root<CSSMediaRule> {
|
||
reflect_dom_object(box CSSMediaRule::new_inherited(parent_stylesheet, mediarule),
|
||
window,
|
||
CSSMediaRuleBinding::Wrap)
|
||
}
|
||
|
||
fn medialist(&self) -> Root<MediaList> {
|
||
self.medialist.or_init(|| {
|
||
let guard = self.cssconditionrule.shared_lock().read();
|
||
MediaList::new(self.global().as_window(),
|
||
self.cssconditionrule.parent_stylesheet(),
|
||
self.mediarule.read_with(&guard).media_queries.clone())
|
||
})
|
||
}
|
||
|
||
/// https://drafts.csswg.org/css-conditional-3/#the-cssmediarule-interface
|
||
pub fn get_condition_text(&self) -> DOMString {
|
||
let guard = self.cssconditionrule.shared_lock().read();
|
||
let rule = self.mediarule.read_with(&guard);
|
||
let list = rule.media_queries.read_with(&guard);
|
||
list.to_css_string().into()
|
||
}
|
||
|
||
/// https://drafts.csswg.org/css-conditional-3/#the-cssmediarule-interface
|
||
pub fn set_condition_text(&self, text: DOMString) {
|
||
let mut input = Parser::new(&text);
|
||
let new_medialist = parse_media_query_list(&mut input);
|
||
let mut guard = self.cssconditionrule.shared_lock().write();
|
||
|
||
// Clone an Arc because we can’t borrow `guard` twice at the same time.
|
||
|
||
// FIXME(SimonSapin): allow access to multiple objects with one write guard?
|
||
// Would need a set of usize pointer addresses or something,
|
||
// the same object is not accessed more than once.
|
||
let mqs = Arc::clone(&self.mediarule.write_with(&mut guard).media_queries);
|
||
|
||
*mqs.write_with(&mut guard) = new_medialist;
|
||
}
|
||
}
|
||
|
||
impl SpecificCSSRule for CSSMediaRule {
|
||
fn ty(&self) -> u16 {
|
||
use dom::bindings::codegen::Bindings::CSSRuleBinding::CSSRuleConstants;
|
||
CSSRuleConstants::MEDIA_RULE
|
||
}
|
||
|
||
fn get_css(&self) -> DOMString {
|
||
let guard = self.cssconditionrule.shared_lock().read();
|
||
self.mediarule.read_with(&guard).to_css_string(&guard).into()
|
||
}
|
||
}
|
||
|
||
impl CSSMediaRuleMethods for CSSMediaRule {
|
||
// https://drafts.csswg.org/cssom/#dom-cssgroupingrule-media
|
||
fn Media(&self) -> Root<MediaList> {
|
||
self.medialist()
|
||
}
|
||
}
|