fune/layout/forms/nsImageControlFrame.cpp
Ting-Yu Lin 03683daeeb Bug 1751473 Part 2 - Use CSSIntPoint instead of nsIntPoint in image event handling code. r=emilio
The old code operates in the CSS pixel coordinate, so we should use the type
system to express that. With this patch, nsImageControlFrame, nsImageFrame, and
nsImageMap now have no usage of nsIntPoint.

Differential Revision: https://phabricator.services.mozilla.com/D136647
2022-01-22 01:07:19 +00:00

151 lines
5.1 KiB
C++

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#include "nsImageFrame.h"
#include "mozilla/MouseEvents.h"
#include "mozilla/PresShell.h"
#include "nsIFormControlFrame.h"
#include "nsPresContext.h"
#include "nsGkAtoms.h"
#include "nsStyleConsts.h"
#include "nsLayoutUtils.h"
#include "nsIContent.h"
using namespace mozilla;
class nsImageControlFrame final : public nsImageFrame,
public nsIFormControlFrame {
public:
explicit nsImageControlFrame(ComputedStyle* aStyle,
nsPresContext* aPresContext);
~nsImageControlFrame() final;
void Init(nsIContent* aContent, nsContainerFrame* aParent,
nsIFrame* aPrevInFlow) final;
NS_DECL_QUERYFRAME
NS_DECL_FRAMEARENA_HELPERS(nsImageControlFrame)
void Reflow(nsPresContext*, ReflowOutput&, const ReflowInput&,
nsReflowStatus&) final;
nsresult HandleEvent(nsPresContext*, WidgetGUIEvent*, nsEventStatus*) final;
#ifdef ACCESSIBILITY
mozilla::a11y::AccType AccessibleType() final;
#endif
#ifdef DEBUG_FRAME_DUMP
nsresult GetFrameName(nsAString& aResult) const final {
return MakeFrameName(u"ImageControl"_ns, aResult);
}
#endif
Maybe<Cursor> GetCursor(const nsPoint&) final;
// nsIFormContromFrame
void SetFocus(bool aOn, bool aRepaint) final;
nsresult SetFormProperty(nsAtom* aName, const nsAString& aValue) final;
};
nsImageControlFrame::nsImageControlFrame(ComputedStyle* aStyle,
nsPresContext* aPresContext)
: nsImageFrame(aStyle, aPresContext, kClassID) {}
nsImageControlFrame::~nsImageControlFrame() = default;
nsIFrame* NS_NewImageControlFrame(PresShell* aPresShell,
ComputedStyle* aStyle) {
return new (aPresShell)
nsImageControlFrame(aStyle, aPresShell->GetPresContext());
}
NS_IMPL_FRAMEARENA_HELPERS(nsImageControlFrame)
void nsImageControlFrame::Init(nsIContent* aContent, nsContainerFrame* aParent,
nsIFrame* aPrevInFlow) {
nsImageFrame::Init(aContent, aParent, aPrevInFlow);
if (aPrevInFlow) {
return;
}
mContent->SetProperty(nsGkAtoms::imageClickedPoint, new CSSIntPoint(0, 0),
nsINode::DeleteProperty<CSSIntPoint>);
}
NS_QUERYFRAME_HEAD(nsImageControlFrame)
NS_QUERYFRAME_ENTRY(nsIFormControlFrame)
NS_QUERYFRAME_TAIL_INHERITING(nsImageFrame)
#ifdef ACCESSIBILITY
a11y::AccType nsImageControlFrame::AccessibleType() {
if (mContent->IsAnyOfHTMLElements(nsGkAtoms::button, nsGkAtoms::input)) {
return a11y::eHTMLButtonType;
}
return a11y::eNoType;
}
#endif
void nsImageControlFrame::Reflow(nsPresContext* aPresContext,
ReflowOutput& aDesiredSize,
const ReflowInput& aReflowInput,
nsReflowStatus& aStatus) {
DO_GLOBAL_REFLOW_COUNT("nsImageControlFrame");
DISPLAY_REFLOW(aPresContext, this, aReflowInput, aDesiredSize, aStatus);
MOZ_ASSERT(aStatus.IsEmpty(), "Caller should pass a fresh reflow status!");
return nsImageFrame::Reflow(aPresContext, aDesiredSize, aReflowInput,
aStatus);
}
nsresult nsImageControlFrame::HandleEvent(nsPresContext* aPresContext,
WidgetGUIEvent* aEvent,
nsEventStatus* aEventStatus) {
NS_ENSURE_ARG_POINTER(aEventStatus);
// Don't do anything if the event has already been handled by someone
if (nsEventStatus_eConsumeNoDefault == *aEventStatus) {
return NS_OK;
}
if (IsContentDisabled()) {
return nsIFrame::HandleEvent(aPresContext, aEvent, aEventStatus);
}
*aEventStatus = nsEventStatus_eIgnore;
if (aEvent->mMessage == eMouseUp &&
aEvent->AsMouseEvent()->mButton == MouseButton::ePrimary) {
// Store click point for HTMLInputElement::SubmitNamesValues
// Do this on MouseUp because the specs don't say and that's what IE does
auto* lastClickedPoint = static_cast<CSSIntPoint*>(
mContent->GetProperty(nsGkAtoms::imageClickedPoint));
if (lastClickedPoint) {
// normally lastClickedPoint is not null, as it's allocated in Init()
nsPoint pt = nsLayoutUtils::GetEventCoordinatesRelativeTo(
aEvent, RelativeTo{this});
*lastClickedPoint = TranslateEventCoords(pt);
}
}
return nsImageFrame::HandleEvent(aPresContext, aEvent, aEventStatus);
}
void nsImageControlFrame::SetFocus(bool aOn, bool aRepaint) {}
Maybe<nsIFrame::Cursor> nsImageControlFrame::GetCursor(const nsPoint&) {
StyleCursorKind kind = StyleUI()->Cursor().keyword;
if (kind == StyleCursorKind::Auto) {
kind = StyleCursorKind::Pointer;
}
return Some(Cursor{kind, AllowCustomCursorImage::Yes});
}
nsresult nsImageControlFrame::SetFormProperty(nsAtom* aName,
const nsAString& aValue) {
return NS_OK;
}