fune/xpcom/base/MemoryPressureLevelMac.h
Chris Peterson c5f254d17c Bug 1791961 - xpcom: Fix C++20 -Wambiguous-reversed-operator warnings. r=emilio
clang is warning that C++20 expects comparison operators to be commutative: `a == b` and `b == a` should resolve to the same comparison operator function. Warnings about the comparison of const and non-const objects can be fixed by making the comparison operator function const.

xpcom/base/AvailableMemoryWatcherMac.cpp:404:14 [-Wambiguous-reversed-operator] ISO C++20 considers use of overloaded operator '==' (with operand types 'mozilla::MacMemoryPressureLevel' and 'mozilla::MacMemoryPressureLevel') to be ambiguous despite there being a unique best viable function
xpcom/base/AvailableMemoryWatcherMac.cpp:568:24 [-Wambiguous-reversed-operator] ISO C++20 considers use of overloaded operator '==' (with operand types 'mozilla::MacMemoryPressureLevel' and 'mozilla::MacMemoryPressureLevel') to be ambiguous despite there being a unique best viable function

Depends on D179024

Differential Revision: https://phabricator.services.mozilla.com/D179025
2023-05-26 04:51:44 +00:00

77 lines
2.2 KiB
C++

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#ifndef mozilla_MemoryPressureLevelMac_h
#define mozilla_MemoryPressureLevelMac_h
namespace mozilla {
#if defined(XP_DARWIN)
// An internal representation of the Mac memory-pressure level constants.
class MacMemoryPressureLevel {
public:
// Order enum values so that higher integer values represent higher
// memory pressure levels allowing comparison operators to be used.
enum class Value {
eUnset,
eUnexpected,
eNormal,
eWarning,
eCritical,
};
MacMemoryPressureLevel() : mValue(Value::eUnset) {}
MOZ_IMPLICIT MacMemoryPressureLevel(Value aValue) : mValue(aValue) {}
bool operator==(const Value& aRhsValue) const { return mValue == aRhsValue; }
bool operator==(const MacMemoryPressureLevel& aRhs) const {
return mValue == aRhs.mValue;
}
// Implement '<' and derive the other comparators from it.
bool operator<(const MacMemoryPressureLevel& aRhs) const {
return mValue < aRhs.mValue;
}
bool operator>(const MacMemoryPressureLevel& aRhs) const {
return aRhs < *this;
}
bool operator<=(const MacMemoryPressureLevel& aRhs) const {
return !(aRhs < *this);
}
bool operator>=(const MacMemoryPressureLevel& aRhs) const {
return !(*this < aRhs);
}
Value GetValue() { return mValue; }
bool IsNormal() { return mValue == Value::eNormal; }
bool IsUnsetOrNormal() { return IsNormal() || (mValue == Value::eUnset); }
bool IsWarningOrAbove() {
return (mValue == Value::eWarning) || (mValue == Value::eCritical);
}
const char* ToString() {
switch (mValue) {
case Value::eUnset:
return "Unset";
case Value::eUnexpected:
return "Unexpected";
case Value::eNormal:
return "Normal";
case Value::eWarning:
return "Warning";
case Value::eCritical:
return "Critical";
}
}
private:
Value mValue;
};
#endif
} // namespace mozilla
#endif // mozilla_MemoryPressureLevelMac_h