fune/testing/web-platform/tests/css/css-pseudo/spelling-error-006-notref.html
Delan Azabani 70ded525e2 Bug 1799652 [wpt PR 36865] - CSS highlight painting: fix kFastSpellingGrammar with decorations, a=testonly
Automatic update from web-platform-tests
CSS highlight painting: fix kFastSpellingGrammar with decorations

CL:3759693 added a “fast spelling/grammar” mode that paints the text
normally then paints a squiggly line, when the spelling or grammar
pseudo in question has default styles. This was correct in terms of
painting order, but incorrect if any of the originating decorations
needed to be recolored to the pseudo ‘color’ (in this case equivalent
to the originating ‘color’).

CL:3780563 fixed that bug (while adding another new mode) by avoiding
kFastSpellingGrammar if there were any originating decorations, which
was the best we could do without highlight inheritance. Since there
were no longer any originating decorations to paint in that mode, we
removed the decoration painting calls in NGTextFragmentPainter too.

CL:3779861 reincluded text with originating decorations in the fast
spelling/grammar mode, adding the necessary check if they needed to
be recolored that was now possible. But we forgot to reintroduce the
decoration painting calls in NGTextFragmentPainter.

Fixed: 1381486
Change-Id: I73076fb2ccc183c59049ff567688c79dfd71a353
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4012538
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Delan Azabani <dazabani@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1068698}

--

wpt-commits: 1f0797d9413a563b9bdb95d7eed9988cf8aa2211
wpt-pr: 36865
2022-11-11 12:34:18 +00:00

8 lines
445 B
HTML

<!doctype html><meta charset="utf-8">
<title>CSS Pseudo-Elements Test: spelling error with originating decorations</title>
<link rel="author" name="Delan Azabani" href="mailto:dazabani@igalia.com">
<!-- TODO force spelling error without relying on UA under test having English spellchecking https://github.com/web-platform-tests/wpt/issues/30863 -->
<body contenteditable spellcheck lang="en">quikc
<script>
document.body.focus();
</script>