forked from mirrors/gecko-dev
882fa06e25
* Harden the new `hideAllViewsExcept()` to not do erroneous things if called when
the binding is already gone.
* Generalize things into `hideAllViewsExcept(thisOne)`:
- Clear `_viewShowing` in there and do the descriptionHeightWorkaround thing
in there too,
- For Photon panels, do all the 'current' attribute setting in there. To show
a panel during transition, I introduced the 'in-transition' attribute.
* I had to make sure not to over-eagerly dispatch 'ViewShowing' events, because
that confuses some,
* Move the temporary panel handling, which contains an ephemeral panelmultiview
instance, internally. This cleans up the hacky, duplicate PanelUI.js code nicely.
* Keep a local copy of `_transitionDetails` to ensure it's still there after transition,
* Harden `_cleanupTransitionPhase()` to only clear the phase that belongs to a
specific transition, _if_ that's passed in as an argument. This resolves any
potential raciness that might occur when `showSubView()` is called again mid-transition.
* Skip the UITour element visibility check when it's inside a panelview, because
too many things need to happen and that check is too simple to be useful in
that case.
MozReview-Commit-ID: 5HpJKs1Ny5j
--HG--
extra : rebase_source : b810e1de2dbd75932a42d68e751fdaecd9fee69a
88 lines
2.7 KiB
JavaScript
88 lines
2.7 KiB
JavaScript
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*/
|
|
"use strict";
|
|
|
|
let syncService = {};
|
|
Components.utils.import("resource://services-sync/service.js", syncService);
|
|
const service = syncService.Service;
|
|
const {UIState} = Components.utils.import("resource://services-sync/UIState.jsm", {});
|
|
|
|
let getState;
|
|
let originalSync;
|
|
let syncWasCalled = false;
|
|
|
|
// TODO: This test should probably be re-written, we don't really test much here.
|
|
add_task(async function testSyncRemoteTabsButtonFunctionality() {
|
|
info("Test the Sync Remote Tabs button in the panel");
|
|
storeInitialValues();
|
|
mockFunctions();
|
|
|
|
// Force UI update.
|
|
Services.obs.notifyObservers(null, UIState.ON_UPDATE);
|
|
|
|
// add the sync remote tabs button to the panel
|
|
CustomizableUI.addWidgetToArea("sync-button", CustomizableUI.AREA_FIXED_OVERFLOW_PANEL);
|
|
|
|
await waitForOverflowButtonShown();
|
|
|
|
// check the button's functionality
|
|
await document.getElementById("nav-bar").overflowable.show();
|
|
info("The panel menu was opened");
|
|
|
|
let syncRemoteTabsBtn = document.getElementById("sync-button");
|
|
let remoteTabsPanel = document.getElementById("PanelUI-remotetabs");
|
|
let viewShown = BrowserTestUtils.waitForEvent(remoteTabsPanel, "ViewShown");
|
|
ok(syncRemoteTabsBtn, "The sync remote tabs button was added to the Panel Menu");
|
|
// click the button - the panel should open.
|
|
syncRemoteTabsBtn.click();
|
|
await viewShown;
|
|
ok(remoteTabsPanel.getAttribute("current"), "Sync Panel is in view");
|
|
|
|
// Find and click the "setup" button.
|
|
let syncNowButton = document.getElementById("PanelUI-remotetabs-syncnow");
|
|
syncNowButton.click();
|
|
info("The sync now button was clicked");
|
|
|
|
await waitForCondition(() => syncWasCalled);
|
|
});
|
|
|
|
add_task(async function asyncCleanup() {
|
|
// reset the panel UI to the default state
|
|
await resetCustomization();
|
|
ok(CustomizableUI.inDefaultState, "The panel UI is in default state again.");
|
|
|
|
if (isOverflowOpen()) {
|
|
let panelHidePromise = promiseOverflowHidden(window);
|
|
PanelUI.overflowPanel.hidePopup();
|
|
await panelHidePromise;
|
|
}
|
|
|
|
restoreValues();
|
|
});
|
|
|
|
function mockFunctions() {
|
|
// mock UIState.get()
|
|
UIState.get = () => ({
|
|
status: UIState.STATUS_SIGNED_IN,
|
|
email: "user@mozilla.com"
|
|
});
|
|
|
|
// mock service.errorHandler.syncAndReportErrors()
|
|
service.errorHandler.syncAndReportErrors = mocked_syncAndReportErrors;
|
|
}
|
|
|
|
function mocked_syncAndReportErrors() {
|
|
syncWasCalled = true;
|
|
}
|
|
|
|
function restoreValues() {
|
|
UIState.get = getState;
|
|
service.syncAndReportErrors = originalSync;
|
|
}
|
|
|
|
function storeInitialValues() {
|
|
getState = UIState.get;
|
|
originalSync = service.syncAndReportErrors;
|
|
}
|