fune/tools/lint/test/test_ruff.py
Andrew Halberstadt 8a4d48a70d Bug 1811850 - [lint] Replace flake8 linter with ruff, r=linter-reviewers,sylvestre
Ruff is a very fast linter implemented in Rust and it can act as a drop-in
replacement for flake8. When running the same set of rules across all files
in mozilla-central (without mozlint), flake8 takes 900 seconds whereas ruff
takes 0.9 seconds.

Ruff also implements rules from other popular Python linters such as pylint,
isort and pyupgrade. There are even plans to implement feature parity with
black in the future. Ultimately, it can become our one stop shop for all Python
linting and formatting.

This stack will swap out all our Python lint tools for ruff (excluding black
for now).

Differential Revision: https://phabricator.services.mozilla.com/D172313
2023-03-17 01:53:58 +00:00

39 lines
873 B
Python

# -*- coding: utf-8 -*-
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
from pprint import pprint
from textwrap import dedent
import mozunit
LINTER = "ruff"
fixed = 0
def test_lint_fix(lint, create_temp_file):
contents = dedent(
"""
import distutils
print("hello!")
"""
)
path = create_temp_file(contents, "bad.py")
lint([path], fix=True)
assert fixed == 1
def test_lint_ruff(lint, paths):
results = lint(paths())
pprint(results, indent=2)
assert len(results) == 2
assert results[0].level == "error"
assert results[0].relpath == "bad.py"
assert "`distutils` imported but unused" in results[0].message
if __name__ == "__main__":
mozunit.main()