forked from mirrors/gecko-dev
6829a78aa2
This implements the weather suggestion result menu UI and builds on D174941. References: * [Spec]( https://www.figma.com/file/Hdi0oHB7trRcncyVAKZypO/accuweather-explorations?node-id=2421%3A62540&t=29w6wH3UYchqBxqX-1) (See "A11y review" in the sidebar) * [Clickable prototype](https://www.figma.com/proto/Hdi0oHB7trRcncyVAKZypO/accuweather-explorations?page-id=2192%3A42825&node-id=2394-52468&viewport=246%2C526%2C0.12&scaling=min-zoom&starting-point-node-id=2394%3A52468&show-proto-sidebar=1) (See "Revised 4/3" in the sidebar) There are a couple important points about the menu. First, one of the commands, "Report inaccurate location", is specific to weather suggestions, or at least location-based suggestions. I don't think it's a good idea to centralize all commands in UrlbarView, and in general I'd like to stop centralizing handling of different result types in the view and input, so I added a new provider method called `getResultCommands()`. Second, the spec calls for a menu separator and a submenu so the user can select a reason they don't want to see the result, so the return value of `getResultCommands()` is flexible enough to support those two things, and I modified `#populateResultMenu()` too. These new commands will be recorded in Glean engagement telemetry as new `engagement_type` values, same as "dismiss" and "help" currently are. This patch doesn't implement handling of two of the commands, "Report inaccurate location" and "Show less frequently", because I wanted to keep it focused on the fundamentals described above. Depends on D174941 Differential Revision: https://phabricator.services.mozilla.com/D174994 |
||
|---|---|---|
| .. | ||
| firefoxSuggest.ftl | ||
| interventions.ftl | ||
| preloaded-top-urls.json | ||
| quicksuggestOnboarding.css | ||
| quicksuggestOnboarding.html | ||
| quicksuggestOnboarding.js | ||
| quicksuggestOnboarding_magglass.svg | ||
| quicksuggestOnboarding_magglass_animation.svg | ||
| suggest-example.svg | ||
