fune/browser/components/customizableui/test/browser_widget_animation.js
Emilio Cobos Álvarez a14c746228 Bug 1805415 - Use activateItem() rather than click() to activate menuitems. r=Gijs,extension-reviewers,pip-reviewers,search-reviewers
Bug 1805414 will move menu event handling to the DOM.

With that change the current synthetic click behavior of XUL menuitems
breaks. On current central, we rely on nsMenuFrame::HandleEvent not
getting called at all for synthetic clicks, and instead we just fire a
command event synchronously here:

  https://searchfox.org/mozilla-central/rev/a0d4f8f112c5c792ae272bf6ce50763ddd23ffa2/dom/xul/nsXULElement.cpp#1071

After my patch the command event is fired properly (potentially
asynchronously too) by the regular menu activation machinery, which is
preferable.

 * They fire a command event synchronously (even though on some
   platforms like macOS activating a context menu item is async).

 * They use a totally different codepath from what a user does.

 * They don't deal with native menus, etc.

We have a proper API for this (activateItem) which takes a much more
closer codepath to what users do, requires that the menu is shown, etc.
Use that API instead for testing.

As a benefit, tests now do not need to close the context menu manually
when clicking on a menu item (because we trigger the same code path as
users clicking the menu).

Differential Revision: https://phabricator.services.mozilla.com/D164567
2022-12-15 03:11:55 +00:00

84 lines
2.4 KiB
JavaScript

/* Any copyright is dedicated to the Public Domain.
* http://creativecommons.org/publicdomain/zero/1.0/ */
"use strict";
gReduceMotionOverride = false;
function promiseWidgetAnimationOut(aNode) {
let animationNode = aNode;
if (
animationNode.tagName != "toolbaritem" &&
animationNode.tagName != "toolbarbutton"
) {
animationNode = animationNode.closest("toolbaritem");
}
if (animationNode.parentNode.id.startsWith("wrapper-")) {
animationNode = animationNode.parentNode;
}
return new Promise(resolve => {
animationNode.addEventListener(
"animationend",
function cleanupWidgetAnimationOut(e) {
if (
e.animationName == "widget-animate-out" &&
e.target.id == animationNode.id
) {
animationNode.removeEventListener(
"animationend",
cleanupWidgetAnimationOut
);
ok(true, "The widget`s animationend should have happened");
resolve();
}
}
);
});
}
function promiseOverflowAnimationEnd() {
return new Promise(resolve => {
let overflowButton = document.getElementById("nav-bar-overflow-button");
overflowButton.addEventListener(
"animationend",
function cleanupOverflowAnimationOut(event) {
if (event.animationName == "overflow-animation") {
overflowButton.removeEventListener(
"animationend",
cleanupOverflowAnimationOut
);
ok(
true,
"The overflow button`s animationend event should have happened"
);
resolve();
}
}
);
});
}
// Right-click on the stop/reload button, use the context menu to move it to the overflow menu.
// The button should animate out, and the overflow menu should animate upon adding.
add_task(async function() {
let stopReloadButton = document.getElementById("stop-reload-button");
let contextMenu = document.getElementById("toolbar-context-menu");
let shownPromise = popupShown(contextMenu);
EventUtils.synthesizeMouseAtCenter(stopReloadButton, {
type: "contextmenu",
button: 2,
});
await shownPromise;
contextMenu.activateItem(
contextMenu.querySelector(".customize-context-moveToPanel")
);
await Promise.all([
promiseWidgetAnimationOut(stopReloadButton),
promiseOverflowAnimationEnd(),
]);
ok(true, "The widget and overflow animations should have both happened.");
});
registerCleanupFunction(CustomizableUI.reset);