nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
fune/browser/components
History
Nick Alexander a4a59a2ce9 Bug 1805514 - Part 3: Allow JS opaque relaunch data and actions. r=nrishel 
This commit replaces two existing launch argument keys, `launchURL`
and `privilegedName`, with an opaque string of data.  Here opaque
means, "does not need to be inspected by the Windows notification
server DLL" (and in general, by the system backend components).

The existing `action` argument key was always intended for this
purpose but was not used in the first implementation.  Here, we make
`action` a stringified JSON object, which is easy for API consumers to
manage and generalizes to (mostly) arbitrary relaunch data.

This JSON object is a compound `notificationData` object containing
both:
- the consumer-provided `opaqueRelaunchData` (generally, an action);
- and implementation-provided details (the alert's name, if
  privileged, etc).
This compound object and the fact that everything transits as strings
makes everything a little more confusing than it really is.

The API to this opaque relaunch data is based on strings for
convenience.  It would be possible to manage JSON objects, perhaps by
using `nsIStructuredCloneContainer` to serialize "structured clone
encodable" JS objects across the process boundaries, but managing the
objects and container in that approach is much more effort than having
the API consumer stringify as desired.

In addition, this patch makes the notification server extract the
Firefox `action` data from the Windows toast `arguments` passed to the
server callback.  Since this fallback data is now provided to Firefox
at launch, there's no need to fetch it from the Windows notification
object; we simply need to know whether to pass through to a Windows
8.1 callback (`tagWasHandled=true`) or to act on the fallback data
(`tagWasHandled=false`).  This is simpler than teaching Firefox to
extract the arguments for toast itself or the appropriate action
button.

Differential Revision: https://phabricator.services.mozilla.com/D182314
2023-07-15 02:34:06 +00:00
..
about
aboutlogins Bug 1832895 - Replaced Vulnerable Password Alert Panel with the newly created corresponding lit component. r=credential-management-reviewers,mtigley 2023-07-10 19:32:42 +00:00
attribution Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu 2023-05-20 12:26:53 +00:00
build Bug 1834932 - Only define mac shell service component on cocoa toolkit. r=firefox-build-system-reviewers,nalexander 2023-05-30 20:00:31 +00:00
contextualidentity Bug 1837176 - Convert imports of httpd.js to consume the ES module directly. r=necko-reviewers,webcompat-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,robwu,issammani,bytesized,pbz,valentin 2023-07-12 13:38:34 +00:00
controlcenter/content Bug 1838183: Include HTTPS-First in current HTTPS-Only exemption options on site identity pane r=freddyb,fluent-reviewers 2023-07-11 11:07:24 +00:00
customizableui Bug 1842809 - Don't resize web content when Entering/Exiting Customize Mode r=emilio 2023-07-12 09:31:06 +00:00
doh Bug 1834176 - Convert consumers of NetUtil.jsm to import the ES module directly. r=arai,webdriver-reviewers,perftest-reviewers,valentin,extension-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,robwu,afinder,whimboo 2023-06-07 08:42:36 +00:00
downloads Bug 1837176 - Convert imports of httpd.js to consume the ES module directly. r=necko-reviewers,webcompat-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,robwu,issammani,bytesized,pbz,valentin 2023-07-12 13:38:34 +00:00
enterprisepolicies Bug 1838447 - Exclude EOL distribution IDs from enterprise telemetry. r=mstriemer 2023-06-22 14:55:24 +00:00
extensions Bug 1837176 - Convert imports of httpd.js to consume the ES module directly. r=necko-reviewers,webcompat-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,robwu,issammani,bytesized,pbz,valentin 2023-07-12 13:38:34 +00:00
firefoxview Bug 1821826 - Refactor FeatureCallout to support generic triggers. r=omc-reviewers,fxview-reviewers,tabbrowser-reviewers,dao,jprickett,sclements 2023-07-11 16:00:40 +00:00
installerprefs Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish 2023-05-20 12:26:49 +00:00
ion Bug 1836482 - Replace AddonManager.jsm imports with AddonManager.sys.mjs r=Standard8,webcompat-reviewers,twisniewski 2023-06-04 13:44:45 +00:00
messagepreview Bug 1826063 - Automatic fixes for enabling Prettier on production xhtml and html files. r=mossop,webdriver-reviewers,webcompat-reviewers,geckoview-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,fxview-reviewers,sgalich,nalexander,devtools-reviewers,sclements,denschub,robwu,owlish 2023-05-20 12:26:56 +00:00
migration Bug 1842605 - Handle errors in loading passwords from Safari CSV files. r=kpatenio,fluent-reviewers,bolsson 2023-07-13 20:55:05 +00:00
newtab Bug 1805514 - Part 1: Support launch_action in Windows native toast notifications. r=barret 2023-07-15 02:34:05 +00:00
originattributes Bug 1837176 - Convert imports of httpd.js to consume the ES module directly. r=necko-reviewers,webcompat-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,robwu,issammani,bytesized,pbz,valentin 2023-07-12 13:38:34 +00:00
pagedata Bug 1837176 - Convert imports of httpd.js to consume the ES module directly. r=necko-reviewers,webcompat-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,robwu,issammani,bytesized,pbz,valentin 2023-07-12 13:38:34 +00:00
places Bug 1840207 - The bookmarked-moved event needs all the details to do a remove+insert operation. r=daisuke 2023-07-03 08:55:51 +00:00
pocket Bug 1838478 - Remove topics from STP r=thecount 2023-07-05 16:32:36 +00:00
preferences Backed out changeset 88c664a821cb (bug 1628476) for causing multiple bc failures browser/* CLOSED TREE 2023-07-14 20:34:02 -04:00
privatebrowsing Bug 713713 - Expand BrowserWindowTracker.openWindow to cover the use cases of OpenBrowserWindow, and remove BrowserUIUtils.openNewBrowserWindow. r=mossop 2023-07-07 12:15:35 +00:00
prompts Bug 1840071 - Update references to Toolkit :: Notifications and Alerts in parts of the tree to use new components. r=hjones,nalexander,mtigley,saschanaz 2023-07-05 16:41:00 +00:00
protections Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,Gijs,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane,tabbrowser-reviewers 2023-06-14 17:16:39 +00:00
protocolhandler Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu 2023-05-20 12:26:53 +00:00
resistfingerprinting Bug 1841425 - Re-enable 32-bit Windows UA tests. r=necko-reviewers,jesup,cpeterson 2023-07-07 09:40:04 +00:00
safebrowsing/content/test Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu 2023-05-20 12:26:53 +00:00
screenshots Bug 1840269, nsFilePicker::GetFile can return a different object on each call, so only call it once, r=Gijs 2023-07-13 20:44:04 +00:00
search Bug 1816572 - Allow more time for Address Bar heuristic results to be returned. r=adw 2023-07-07 15:48:34 +00:00
sessionstore Bug 1792824 - Convert ObjectUtils.jsm to an ES module. r=barret,necko-reviewers,devtools-reviewers,kershaw 2023-07-12 08:07:23 +00:00
shell Bug 1787552 - Added check to see if taskbar pin already exists before pinning in PinCurrentAppToTaskbarWin10 r=nrishel 2023-06-12 22:13:53 +00:00
shopping Bug 1841086 - Page parent component to connect data to UI components. r=shopping-reviewers,jhirsch 2023-07-13 21:02:31 +00:00
storybook Bug 1842605 - Handle errors in loading passwords from Safari CSV files. r=kpatenio,fluent-reviewers,bolsson 2023-07-13 20:55:05 +00:00
syncedtabs Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements 2023-06-19 18:44:48 +00:00
tabunloader Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements 2023-06-19 18:44:48 +00:00
tests Bug 1839388 - Convert distribution.js to an ES module. r=mkaply 2023-06-22 07:22:13 +00:00
textrecognition Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu 2023-05-20 12:26:53 +00:00
touchbar Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements 2023-06-19 18:44:48 +00:00
translations Bug 1841341 - Only show one translation popup offering when restoring windows; r=nordzilla 2023-07-06 18:43:18 +00:00
uitour Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements 2023-06-19 18:44:48 +00:00
urlbar Bug 1843186: Append UTM parameter to Pocket suggestions r=dao 2023-07-13 21:20:01 +00:00
.eslintrc.js
BrowserComponents.manifest
BrowserContentHandler.sys.mjs Bug 1805514 - Part 3: Allow JS opaque relaunch data and actions. r=nrishel 2023-07-15 02:34:06 +00:00
BrowserGlue.sys.mjs Bug 1797806 - Implemented startup registry check for DisablePrivateBrowsing while EnterprisePolicies are uninitialized r=bhearsum,nalexander,mkaply 2023-06-28 21:04:37 +00:00
components.conf
distribution.sys.mjs Bug 1839388 - Convert distribution.js to an ES module. r=mkaply 2023-06-22 07:22:13 +00:00
metrics.yaml
moz.build Bug 1817084 - Remove old translations code; r=settings-reviewers,fluent-reviewers,nordzilla,mconley,flod 2023-06-23 13:36:13 +00:00
nsIBrowserHandler.idl
StartupRecorder.sys.mjs