forked from mirrors/gecko-dev
8b61489514
This fixes an invalid length being reported from `float32_array_to_slice` (which used the byte length), and also to generalize getting data from a JS array buffer view, to reduce code duplication. The pending type safety issues, like where we could send a `UInt16Array` where we expect a `Float32` one, should be solved by IDL bindings in some cases, like `uniform[n]fv` or `vertexAttrib[n]fv`, and with extra checks in others, like in the pending `texImage2D(..., ArrayBufferView)`. r? @jdm Source-Repo: https://github.com/servo/servo Source-Revision: 4ab1cdece6f594512a0ae9605ff5ebee630a70ca
109 lines
3.8 KiB
Rust
109 lines
3.8 KiB
Rust
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
use dom::bindings::codegen::Bindings::TextDecoderBinding;
|
|
use dom::bindings::codegen::Bindings::TextDecoderBinding::TextDecoderMethods;
|
|
use dom::bindings::conversions::array_buffer_view_data;
|
|
use dom::bindings::error::{Error, Fallible};
|
|
use dom::bindings::global::GlobalRef;
|
|
use dom::bindings::js::Root;
|
|
use dom::bindings::reflector::{Reflector, reflect_dom_object};
|
|
use dom::bindings::str::USVString;
|
|
use dom::bindings::trace::JSTraceable;
|
|
use encoding::Encoding;
|
|
use encoding::label::encoding_from_whatwg_label;
|
|
use encoding::types::{DecoderTrap, EncodingRef};
|
|
use js::jsapi::{JSContext, JSObject};
|
|
use std::borrow::ToOwned;
|
|
use util::str::DOMString;
|
|
|
|
#[dom_struct]
|
|
pub struct TextDecoder {
|
|
reflector_: Reflector,
|
|
#[ignore_heap_size_of = "Defined in rust-encoding"]
|
|
encoding: EncodingRef,
|
|
fatal: bool,
|
|
}
|
|
|
|
impl TextDecoder {
|
|
fn new_inherited(encoding: EncodingRef, fatal: bool) -> TextDecoder {
|
|
TextDecoder {
|
|
reflector_: Reflector::new(),
|
|
encoding: encoding,
|
|
fatal: fatal,
|
|
}
|
|
}
|
|
|
|
fn make_range_error() -> Fallible<Root<TextDecoder>> {
|
|
Err(Error::Range("The given encoding is not supported.".to_owned()))
|
|
}
|
|
|
|
pub fn new(global: GlobalRef, encoding: EncodingRef, fatal: bool) -> Root<TextDecoder> {
|
|
reflect_dom_object(box TextDecoder::new_inherited(encoding, fatal),
|
|
global,
|
|
TextDecoderBinding::Wrap)
|
|
}
|
|
|
|
/// https://encoding.spec.whatwg.org/#dom-textdecoder
|
|
pub fn Constructor(global: GlobalRef,
|
|
label: DOMString,
|
|
options: &TextDecoderBinding::TextDecoderOptions)
|
|
-> Fallible<Root<TextDecoder>> {
|
|
let encoding = match encoding_from_whatwg_label(&label) {
|
|
None => return TextDecoder::make_range_error(),
|
|
Some(enc) => enc
|
|
};
|
|
// The rust-encoding crate has WHATWG compatibility, so we are
|
|
// guaranteed to have a whatwg_name because we successfully got
|
|
// the encoding from encoding_from_whatwg_label.
|
|
// Use match + panic! instead of unwrap for better error message
|
|
match encoding.whatwg_name() {
|
|
None => panic!("Label {} fits valid encoding without valid name", label),
|
|
Some("replacement") => return TextDecoder::make_range_error(),
|
|
_ => ()
|
|
};
|
|
Ok(TextDecoder::new(global, encoding, options.fatal))
|
|
}
|
|
}
|
|
|
|
|
|
impl TextDecoderMethods for TextDecoder {
|
|
// https://encoding.spec.whatwg.org/#dom-textdecoder-encoding
|
|
fn Encoding(&self) -> DOMString {
|
|
DOMString::from(self.encoding.whatwg_name().unwrap())
|
|
}
|
|
|
|
// https://encoding.spec.whatwg.org/#dom-textdecoder-fatal
|
|
fn Fatal(&self) -> bool {
|
|
self.fatal
|
|
}
|
|
|
|
#[allow(unsafe_code)]
|
|
// https://encoding.spec.whatwg.org/#dom-textdecoder-decode
|
|
fn Decode(&self, _cx: *mut JSContext, input: Option<*mut JSObject>)
|
|
-> Fallible<USVString> {
|
|
let input = match input {
|
|
Some(input) => input,
|
|
None => return Ok(USVString("".to_owned())),
|
|
};
|
|
|
|
let data = match unsafe { array_buffer_view_data::<u8>(input) } {
|
|
Some(data) => data,
|
|
None => {
|
|
return Err(Error::Type("Argument to TextDecoder.decode is not an ArrayBufferView".to_owned()));
|
|
}
|
|
};
|
|
|
|
let trap = if self.fatal {
|
|
DecoderTrap::Strict
|
|
} else {
|
|
DecoderTrap::Replace
|
|
};
|
|
|
|
match self.encoding.decode(data, trap) {
|
|
Ok(s) => Ok(USVString(s)),
|
|
Err(_) => Err(Error::Type("Decoding failed".to_owned())),
|
|
}
|
|
}
|
|
}
|