forked from mirrors/gecko-dev
aace8a36d8
I'm sorry this is just one commit, I should have split it :( I will submit tests in another patch. - Vendored [react-router-dom](https://www.npmjs.com/package/react-router-dom) library. - Removed `getSelectedPageComponent` from `App` component and changed it to use React Router's `Route` components. - Made the sidebar links to point to proper URL's. Thanks to this we don't need a lot of code/props we were passing to these items to select the proper page. Some considerations over the implementation: - React Router's `Switch` is used to wrap our routes, to ensure only one is rendered. Right now is not strictly necessary, but I think it helps to clarify that the routes are _not_ nested. - We need to pass a `key` prop to the `RuntimePage` rendered in the route, so when we change the actual runtime shown, the page gets updated. - The action `selectPage` gets called on `componentWillMount`, so it doesn't change state while rendering. - When we reload the page and a device runtime is selected, we redirect to "This Firefox" page. (Click on this GIF to see navigation 👇) {F1100903} I'm sorry this has taken this long, it has been a bit of a headache 🙏 Differential Revision: https://phabricator.services.mozilla.com/D12147 --HG-- extra : moz-landing-system : lando
82 lines
3.2 KiB
JavaScript
82 lines
3.2 KiB
JavaScript
/* Any copyright is dedicated to the Public Domain.
|
|
http://creativecommons.org/publicdomain/zero/1.0/ */
|
|
|
|
"use strict";
|
|
|
|
/**
|
|
* Check that navigating from This Firefox to Connect and back to This Firefox works and
|
|
* does not leak.
|
|
*/
|
|
|
|
const TAB_URL_1 = "data:text/html,<title>TAB1</title>";
|
|
const TAB_URL_2 = "data:text/html,<title>TAB2</title>";
|
|
|
|
add_task(async function() {
|
|
info("Force all debug target panes to be expanded");
|
|
prepareCollapsibilitiesTest();
|
|
|
|
const { document, tab, window } = await openAboutDebugging();
|
|
const AboutDebugging = window.AboutDebugging;
|
|
|
|
const connectSidebarItem = findSidebarItemByText("Connect", document);
|
|
const connectLink = connectSidebarItem.querySelector(".js-sidebar-link");
|
|
ok(connectSidebarItem, "Found the Connect sidebar item");
|
|
|
|
const thisFirefoxSidebarItem = findSidebarItemByText("This Firefox", document);
|
|
const thisFirefoxLink = thisFirefoxSidebarItem.querySelector(".js-sidebar-link");
|
|
ok(thisFirefoxSidebarItem, "Found the ThisFirefox sidebar item");
|
|
ok(isSidebarItemSelected(thisFirefoxSidebarItem),
|
|
"ThisFirefox sidebar item is selected by default");
|
|
|
|
info("Open a new background tab TAB1");
|
|
const backgroundTab1 = await addTab(TAB_URL_1, { background: true });
|
|
|
|
info("Wait for the tab to appear in the debug targets with the correct name");
|
|
await waitUntil(() => findDebugTargetByText("TAB1", document));
|
|
|
|
await waitForRequestsToSettle(AboutDebugging.store);
|
|
info("Click on the Connect item in the sidebar");
|
|
connectLink.click();
|
|
|
|
info("Wait until Connect page is displayed");
|
|
await waitUntil(() => document.querySelector(".js-connect-page"));
|
|
// we need to wait here because the sidebar isn't updated after mounting the page
|
|
info("Wait until Connect sidebar item is selected");
|
|
await waitUntil(() => isSidebarItemSelected(connectSidebarItem));
|
|
ok(!document.querySelector(".js-runtime-page"), "Runtime page no longer rendered");
|
|
|
|
info("Open a new tab which should be listed when we go back to This Firefox");
|
|
const backgroundTab2 = await addTab(TAB_URL_2, { background: true });
|
|
|
|
info("Click on the ThisFirefox item in the sidebar");
|
|
thisFirefoxLink.click();
|
|
|
|
info("Wait until ThisFirefox page is displayed");
|
|
await waitUntil(() => document.querySelector(".js-runtime-page"));
|
|
ok(isSidebarItemSelected(thisFirefoxSidebarItem),
|
|
"ThisFirefox sidebar item is selected again");
|
|
ok(!document.querySelector(".js-connect-page"), "Connect page no longer rendered");
|
|
|
|
info("TAB2 should already be displayed in the debug targets");
|
|
await waitUntil(() => findDebugTargetByText("TAB2", document));
|
|
|
|
info("Remove first background tab");
|
|
await removeTab(backgroundTab1);
|
|
|
|
info("Check TAB1 disappears, meaning ThisFirefox client is correctly connected");
|
|
await waitUntil(() => !findDebugTargetByText("TAB1", document));
|
|
|
|
info("Remove second background tab");
|
|
await removeTab(backgroundTab2);
|
|
|
|
info("Check TAB2 disappears, meaning ThisFirefox client is correctly connected");
|
|
await waitUntil(() => !findDebugTargetByText("TAB2", document));
|
|
|
|
await waitForRequestsToSettle(AboutDebugging.store);
|
|
|
|
await removeTab(tab);
|
|
});
|
|
|
|
function isSidebarItemSelected(item) {
|
|
return item.classList.contains("js-sidebar-item-selected");
|
|
}
|