fune/image
Timothy Nikkel 21823adb7d Bug 1885209. Sanity check pixel format of internal icon type images. r=gfx-reviewers,nical
The page has

  <link rel="shortcut icon" type="image/x-icon" href="data:image/icon;base64,__png_data__">

When the Favicon service tries to decode that is passes "image/icon" as the mimetype to choose the decoder type and so we try to decode it as our internal icon format (not a format used in the wild, only used internal to get pass around icon data we retrieved from the OS). This passes in an invalid format type and hits the assert. In a non-debug build we fail to create the surface pipe later when we can't find a swizzle function. We only ever create these icon files with formats R8G8B8A8, OS_RGBA, or B8G8R8A8. The favicon still gets displayed so the favicon service must be trying something more complicated if that fails.

In the normal content image loading path we prefer to sniff the content type from the image data and if that fails fall back to the specified content type. So the test had be careful not to look like png (or any other) image format so that we actually tried to decode it as an icon.

Differential Revision: https://phabricator.services.mozilla.com/D204732
2024-05-21 00:41:56 +00:00
..
build Bug 1866010 p2. Update UpdateContentViewerRegistration to reflect nsIDocumentViewer's new name. r=emilio 2023-11-24 09:10:48 +00:00
decoders Bug 1885209. Sanity check pixel format of internal icon type images. r=gfx-reviewers,nical 2024-05-21 00:41:56 +00:00
encoders Bug 1872536 - Use MakeUniqueFallible for large buffers in image decoders/encoders. r=gfx-reviewers,lsalzman 2023-12-31 22:16:46 +00:00
test Bug 1885209. Sanity check pixel format of internal icon type images. r=gfx-reviewers,nical 2024-05-21 00:41:56 +00:00
AnimationFrameBuffer.cpp
AnimationFrameBuffer.h
AnimationParams.h
AnimationSurfaceProvider.cpp
AnimationSurfaceProvider.h
AutoRestoreSVGState.h
BlobSurfaceProvider.cpp Bug 1805599. Fix handling of invalidations in non-animated vector images that use the webrender imageprovider path. r=aosmond 2024-05-02 01:45:32 +00:00
BlobSurfaceProvider.h Bug 1805599. Fix handling of invalidations in non-animated vector images that use the webrender imageprovider path. r=aosmond 2024-05-02 01:45:32 +00:00
BMPHeaders.h
ClippedImage.cpp
ClippedImage.h
CopyOnWrite.h
DecodedSurfaceProvider.cpp Bug 1805599. Fix handling of invalidations in non-animated vector images that use the webrender imageprovider path. r=aosmond 2024-05-02 01:45:32 +00:00
DecodedSurfaceProvider.h
DecodePool.cpp
DecodePool.h
Decoder.cpp
Decoder.h
DecoderFactory.cpp
DecoderFactory.h
DecoderFlags.h
Downscaler.cpp
Downscaler.h
DownscalingFilter.h
DynamicImage.cpp
DynamicImage.h
FrameAnimator.cpp
FrameAnimator.h
FrameTimeout.h
FrozenImage.cpp
FrozenImage.h
ICOFileHeaders.h
IDecodingTask.cpp Bug 1880054. Simplify some imagelib event target code. r=gfx-reviewers,lsalzman 2024-02-25 04:54:33 +00:00
IDecodingTask.h Bug 1880054. Simplify some imagelib event target code. r=gfx-reviewers,lsalzman 2024-02-25 04:54:33 +00:00
Image.cpp Bug 1880054. Simplify some imagelib event target code. r=gfx-reviewers,lsalzman 2024-02-25 04:54:33 +00:00
Image.h
ImageBlocker.cpp Bug 1873474 - Use ImageBlocker directly instead of nsIContentPolicy::ShouldProcess in ImageDocument. r=smaug 2024-01-17 09:49:32 +00:00
ImageBlocker.h Bug 1873474 - Use ImageBlocker directly instead of nsIContentPolicy::ShouldProcess in ImageDocument. r=smaug 2024-01-17 09:49:32 +00:00
ImageCacheKey.cpp Bug 1873490, part 1 - Refactor the only external call to StorageDisabledByAntiTracking - r=anti-tracking-reviewers,timhuang 2024-01-12 17:03:20 +00:00
ImageCacheKey.h
ImageFactory.cpp
ImageFactory.h
ImageLogging.h
ImageMemoryReporter.cpp
ImageMemoryReporter.h
ImageMetadata.h
ImageOps.cpp
ImageOps.h
ImageRegion.h
ImageWrapper.cpp
ImageWrapper.h
ImgDrawResult.h
imgFrame.cpp
imgFrame.h
imgICache.idl
imgIContainer.idl
imgIContainerDebug.idl
imgIEncoder.idl
imgILoader.idl
imgINotificationObserver.idl
imgIRequest.idl Bug 1881863 - Part 1: Standardize on boolean over bool in xpidl, r=xpcom-reviewers,necko-reviewers,valentin,extension-reviewers,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,search-reviewers,anti-tracking-reviewers,places-reviewers,nalexander,emilio,zombie,sgalich,karlt,lina,Standard8 2024-04-04 18:45:21 +00:00
imgIScriptedNotificationObserver.idl
imgITools.idl
imgLoader.cpp Bug 1784496 - The necko consumers should use the priority's incremental flag r=necko-reviewers,kershaw 2024-05-15 08:18:42 +00:00
imgLoader.h Bug 1893402 - Part 2: Use minimum cache expiration time in image cache. r=tnikkel 2024-05-17 11:20:59 +00:00
imgRequest.cpp Bug 1895211. Get the image in imgRequest::OnStopRequest after calling OnDataAvailable because that might create the image. r=gfx-reviewers,nical 2024-05-17 23:26:18 +00:00
imgRequest.h Bug 1893402 - Part 2: Use minimum cache expiration time in image cache. r=tnikkel 2024-05-17 11:20:59 +00:00
imgRequestProxy.cpp
imgRequestProxy.h
imgTools.cpp Bug 1890216 - Fix Skia API usage in Gecko for m125 update. r=aosmond 2024-05-15 01:57:52 +00:00
imgTools.h
IProgressObserver.h Bug 1880054. Simplify some imagelib event target code. r=gfx-reviewers,lsalzman 2024-02-25 04:54:33 +00:00
ISurfaceProvider.h Bug 1805599. Fix handling of invalidations in non-animated vector images that use the webrender imageprovider path. r=aosmond 2024-05-02 01:45:32 +00:00
LookupResult.h
moz.build Bug 1859893 - batch 15 - migrate xpcshell.ini -> .toml. r=aryx,geckoview-reviewers,extension-reviewers,valentin,cookie-reviewers,pbz,owlish,robwu 2023-11-24 14:41:35 +00:00
MultipartImage.cpp Bug 1862059. Handle edge cases of svg images in multipart images. r=aosmond,gfx-reviewers 2024-01-02 07:13:01 +00:00
MultipartImage.h
nsIIconURI.idl Bug 1883217 - Remove unused defines in IDL files r=webdriver-reviewers,necko-reviewers,credential-management-reviewers,places-reviewers,dom-core,Standard8,valentin,mccr8,sgalich 2024-03-06 19:04:25 +00:00
Orientation.h
OrientedImage.cpp
OrientedImage.h
PlaybackType.h
ProgressTracker.cpp Bug 1880054. Simplify some imagelib event target code. r=gfx-reviewers,lsalzman 2024-02-25 04:54:33 +00:00
ProgressTracker.h Bug 1880054. Simplify some imagelib event target code. r=gfx-reviewers,lsalzman 2024-02-25 04:54:33 +00:00
RasterImage.cpp Bug 1890216 - Fix Skia API usage in Gecko for m125 update. r=aosmond 2024-05-15 01:57:52 +00:00
RasterImage.h
Resolution.h
ScriptedNotificationObserver.cpp
ScriptedNotificationObserver.h
ShutdownTracker.cpp
ShutdownTracker.h
SourceBuffer.cpp
SourceBuffer.h
StreamingLexer.h
SurfaceCache.cpp Bug 1805599. Fix handling of invalidations in non-animated vector images that use the webrender imageprovider path. r=aosmond 2024-05-02 01:45:32 +00:00
SurfaceCache.h Bug 1805599. Fix handling of invalidations in non-animated vector images that use the webrender imageprovider path. r=aosmond 2024-05-02 01:45:32 +00:00
SurfaceCacheUtils.cpp
SurfaceCacheUtils.h
SurfaceFilters.h
SurfaceFlags.h
SurfacePipe.cpp
SurfacePipe.h
SurfacePipeFactory.h
SVGDocumentWrapper.cpp Bug 1897055. Assert SVGDocumentWrapper::DestroyViewer is called on main thread. r=layout-reviewers,emilio 2024-05-16 08:22:31 +00:00
SVGDocumentWrapper.h Bug 1865480. Rename nsIContentViewer to nsIDocumentViewer. r=layout-reviewers,emilio 2023-11-21 12:45:59 +00:00
SVGDrawingCallback.h
SVGDrawingParameters.h
VectorImage.cpp Bug 1805599. Fix handling of invalidations in non-animated vector images that use the webrender imageprovider path. r=aosmond 2024-05-02 01:45:32 +00:00
VectorImage.h
WebRenderImageProvider.h Bug 1805599. Fix handling of invalidations in non-animated vector images that use the webrender imageprovider path. r=aosmond 2024-05-02 01:45:32 +00:00