nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
fune/toolkit/components
History
Manuel Bucher 5205854e55 Bug 1741375 - Proxy DNS by default when using SOCKS v5 r=necko-reviewers,extension-reviewers,kershaw,perftest-reviewers,robwu,sparky 
Initially reported and discussed in Bug 610896.

The simple solution of just flipping the pref `network.proxy.socks_remote_dns`
is risky due to potentially breaking SOCKS4 proxy users.  Proxying
DNS on SOCKS4 isn't supported.  Therefore we speak the incompatible
SOCKS4a protocol when `socks_remote_dns` is enabled, potentially
breaking users setup.

To keep backwards compatibility on SOCKS4 proxy users, that don't have
SOCKS4a support, the pref `network.proxy.socks_remote_dns` is split into
two prefs:

* `network.proxy.socks_remote_dns`: remote DNS for SOCKS4
* `network.proxy.socks5_remote_dns`: remote DNS for SOCKS5.

This way we proxy DNS by default on SOCKS5 while keeping user settings
on SOCKS4.  This is a similar approach to the one described in
[Bug 610896 comment 17].

Proxying DNS in SOCKS4 by default is desireable (See [Bug 610896 comment 11]),
but out of scope for this patch.  [Telemetry] on proxy usage by socks
version indicated that changing the default for SOCKS4 is likely break
some users setup and needs to be taken with more care.

The default values of [proxyDNS] now defaults to true for SOCKS5 proxies.
When creating nsIProxyInfo objects of SOCKS4 proxies, the default value
false is kept.  Setting proxyDNS affects both SOCKS4 and SOCKS5 proxy by
modifying both `socks_remote_dns` and `socks5_remote_dns`.  Therefore no
extension breakage is expected.

The enterprise policy can also modify the new pref
`network.proxy.socks5_remote_dns`.

Follow up bugs filed while implementing:

* Bug 1890542 - Also disable Prefetch non-manual configurations of socks
                proxy
* Bug 1890554 - Use `ProxyInfo::TRANSPARENT_PROXY_RESOLVES_HOST` flag in
                `nsHttpChannel::GetProxyDNSStrategy`
* Bug 1890549 - nsHttpChannel implementation DNS resolve strategy for
                proxies incomplete
* Bug 1893670 - Proxy DNS by default for SOCK4 proxies. Defaulting to
                SOCKS4a

[Bug 610896 comment 17]: https://bugzilla.mozilla.org/show_bug.cgi?id=610896#c17
[Bug 610896 comment 11]: https://bugzilla.mozilla.org/show_bug.cgi?id=610896#c11
[Telemetry]: https://bugzilla.mozilla.org/show_bug.cgi?id=1741375#c27
[proxyDNS]: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/proxy/settings#proxydns

Differential Revision: https://phabricator.services.mozilla.com/D207532
2024-05-21 11:55:26 +00:00
..
aboutcheckerboard
aboutconfig Bug 1882380 - Update AccessibilityUtils to ensure clicking on a label text content for a form field is not failing a11y_checks. r=Jamie 2024-03-25 15:25:37 +00:00
aboutmemory Bug 1565089 - Make about:memory theme looks closer to the default theme r=desktop-theme-reviewers,sfoster 2024-05-17 20:51:49 +00:00
aboutprocesses Bug 1880914 - Move BrowserOpenAddonsMgr. r=Gijs,extension-reviewers,settings-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,robwu,thecount 2024-04-15 10:22:46 +00:00
aboutthirdparty Bug 1881863 - Part 1: Standardize on boolean over bool in xpidl, r=xpcom-reviewers,necko-reviewers,valentin,extension-reviewers,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,search-reviewers,anti-tracking-reviewers,places-reviewers,nalexander,emilio,zombie,sgalich,karlt,lina,Standard8 2024-04-04 18:45:21 +00:00
aboutwebauthn Bug 1845151 - Remove all code associated with the message-bar component r=hjones,desktop-theme-reviewers,reusable-components-reviewers,extension-reviewers,robwu 2024-05-07 14:01:53 +00:00
aboutwindowsmessages Bug 1864896: Autofix unused function arguments (toolkit). r=mconley,translations-reviewers,omc-reviewers,aminomancer 2024-03-19 14:59:21 +00:00
alerts Bug 1896330 - Remove plain class from labels. r=dao,desktop-theme-reviewers 2024-05-13 14:14:45 +00:00
antitracking Bug 1896701 - Register BTP Marionette tests. r=webdriver-reviewers,anti-tracking-reviewers,manuel,jdescottes 2024-05-17 12:54:57 +00:00
apppicker Bug 1878401 - part 3 - Update nsIFilePicker users in toolkit/ to pass BrowsingContext to init r=extension-reviewers,Gijs,ng,robwu 2024-02-28 21:29:38 +00:00
asyncshutdown Bug 1884623 - Update more jsm references in production code and docs in toolkit/. r=mossop,extension-reviewers,desktop-theme-reviewers,application-update-reviewers,credential-management-reviewers,places-reviewers,reusable-components-reviewers,translations-reviewers,omc-reviewers,robwu,Dexter,mconley,aminomancer,emilio,bytesized,sgalich,hjones 2024-03-14 17:42:29 +00:00
autocomplete Bug 1886064, make usage of label and comment fields in autofill items more consistent, r=credential-management-reviewers,geckoview-reviewers,reusable-components-reviewers,owlish,sgalich,tgiles 2024-05-14 15:37:32 +00:00
backgroundhangmonitor Bug 1881863 - Part 1: Standardize on boolean over bool in xpidl, r=xpcom-reviewers,necko-reviewers,valentin,extension-reviewers,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,search-reviewers,anti-tracking-reviewers,places-reviewers,nalexander,emilio,zombie,sgalich,karlt,lina,Standard8 2024-04-04 18:45:21 +00:00
backgroundtasks Backed out changeset 1db41dc8d778 (bug 1833735) for causing xpchsell failures on ensureExperimentToRolloutTransitionPerformed.js. CLOSED TREE 2024-05-18 01:31:43 +03:00
bitsdownload Bug 1889229 - Remove redundant imports from bitdownload. r=application-update-reviewers,bytesized 2024-04-03 06:48:36 +00:00
browser Bug 1895229 - Remove nsIWebBrowserChromeFocus. r=hsivonen,dom-core 2024-05-06 11:30:34 +00:00
build
captivedetect Bug 1881863 - Part 1: Standardize on boolean over bool in xpidl, r=xpcom-reviewers,necko-reviewers,valentin,extension-reviewers,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,search-reviewers,anti-tracking-reviewers,places-reviewers,nalexander,emilio,zombie,sgalich,karlt,lina,Standard8 2024-04-04 18:45:21 +00:00
cascade_bloom_filter
certviewer Bug 1880914 - Move BrowserPageInfo. r=Gijs,anti-tracking-reviewers 2024-04-08 17:21:02 +00:00
cleardata Bug 1894657 - Update tests. r=manuel,anti-tracking-reviewers 2024-05-03 17:21:35 +00:00
clearsitedata
commandlines
contentanalysis Bug 1883510 - Change Preferences to StaticPrefs in ContentAnalysis r=cmartin,gstoll,gcp 2024-05-14 13:07:01 +00:00
contentprefs Bug 1864896: Autofix unused function arguments (toolkit). r=mconley,translations-reviewers,omc-reviewers,aminomancer 2024-03-19 14:59:21 +00:00
contentrelevancy Bug 1897242 - Make it easy to run and log a single relevancy classification. r=nanj 2024-05-17 13:48:55 +00:00
contextualidentity Bug 1864896: Autofix unused function arguments (toolkit). r=mconley,translations-reviewers,omc-reviewers,aminomancer 2024-03-19 14:59:21 +00:00
cookiebanners Bug 1892152 - Expand cookie banner metrics cookie.banners.r*. r=anti-tracking-reviewers,pbz 2024-05-06 16:24:29 +00:00
crashes Bug 1885723 - Fix more jsm references in toolkit/. r=Gijs,extension-reviewers,credential-management-reviewers,places-reviewers,robwu,sgalich 2024-03-20 10:04:59 +00:00
crashmonitor Bug 1885723 - Fix more jsm references in toolkit/. r=Gijs,extension-reviewers,credential-management-reviewers,places-reviewers,robwu,sgalich 2024-03-20 10:04:59 +00:00
credentialmanagement Bug 1854510 - Remove the fail-if notation for passing a11y-checks in Core Credentials. r=timhuang 2024-03-25 15:25:37 +00:00
ctypes Bug 1885723 - Fix more jsm references in toolkit/. r=Gijs,extension-reviewers,credential-management-reviewers,places-reviewers,robwu,sgalich 2024-03-20 10:04:59 +00:00
downloads Bug 1891234, additional filename filter checks, r=Gijs,extension-reviewers 2024-05-14 17:35:05 +00:00
enterprisepolicies Bug 1881863 - Part 1: Standardize on boolean over bool in xpidl, r=xpcom-reviewers,necko-reviewers,valentin,extension-reviewers,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,search-reviewers,anti-tracking-reviewers,places-reviewers,nalexander,emilio,zombie,sgalich,karlt,lina,Standard8 2024-04-04 18:45:21 +00:00
extensions Bug 1741375 - Proxy DNS by default when using SOCKS v5 r=necko-reviewers,extension-reviewers,kershaw,perftest-reviewers,robwu,sparky 2024-05-21 11:55:26 +00:00
featuregates Backed out 2 changesets (bug 1896187) for causing xpc and py3 unit test failures. CLOSED TREE 2024-05-21 00:39:43 +03:00
finalizationwitness
find Bug 1881845 - Remove nsContentCID.h r=smaug,media-playback-reviewers,karlt 2024-03-04 23:41:05 +00:00
forgetaboutsite Bug 1864896: Autofix unused function arguments (toolkit). r=mconley,translations-reviewers,omc-reviewers,aminomancer 2024-03-19 14:59:21 +00:00
formautofill Bug 1897099 - Remove cc_form event telemetry r=credential-management-reviewers,jneuberger 2024-05-17 18:25:25 +00:00
gfx Bug 1864896: Autofix unused function arguments (toolkit). r=mconley,translations-reviewers,omc-reviewers,aminomancer 2024-03-19 14:59:21 +00:00
glean Bug 1897292 - Generate the correct event cpp name in event-into-legacy r=TravisLong 2024-05-17 13:25:49 +00:00
httpsonlyerror Bug 1864896: Autofix unused function arguments (toolkit). r=mconley,translations-reviewers,omc-reviewers,aminomancer 2024-03-19 14:59:21 +00:00
jsoncpp
kvstore Bug 1881863 - Part 1: Standardize on boolean over bool in xpidl, r=xpcom-reviewers,necko-reviewers,valentin,extension-reviewers,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,search-reviewers,anti-tracking-reviewers,places-reviewers,nalexander,emilio,zombie,sgalich,karlt,lina,Standard8 2024-04-04 18:45:21 +00:00
maintenanceservice Bug 1894689 - update pinned cert issuers in windows maintenance service. r=bhearsum,application-update-reviewers,bytesized 2024-05-03 05:10:14 +00:00
mediasniffer Bug 1864896: Autofix unused function arguments (toolkit). r=mconley,translations-reviewers,omc-reviewers,aminomancer 2024-03-19 14:59:21 +00:00
messaging-system Bug 1893341 - Change Firefox launch on login to use Windows StartupTask functions on MSIX r=nalexander,nrishel,settings-reviewers,omc-reviewers,firefox-desktop-core-reviewers ,aminomancer 2024-05-15 15:34:43 +00:00
ml Bug 1897117 - Change the request structure for the ML image-to-text pipeline - r=gregtatum 2024-05-16 16:56:18 +00:00
mozintl
mozprotocol
narrate Bug 1876432 - Added support for custom themes as its own menu in Reader View. r=reader-mode-reviewers,fluent-reviewers,desktop-theme-reviewers,hjones,accessibility-frontend-reviewers,bolsson,devtools-reviewers,sfoster,cmkm,jules,ayeddi 2024-04-02 00:08:46 +00:00
nimbus Bug 1790428 - Remove ExperimentFakes.enrollWithRollout r=chumphreys 2024-05-16 17:15:58 +00:00
normandy Bug 1275496 - Change existing uses of custom IDBFactory.open to the standard overload. r=dom-storage-reviewers,home-newtab-reviewers,janv,thecount 2024-04-22 04:46:58 +00:00
parentalcontrols
passwordmgr Bug 1897770 - Improve .sjs file environment definitions in ESLint. r=frontend-codestyle-reviewers,extension-reviewers,Gijs 2024-05-20 13:49:44 +00:00
pdfjs Bug 1897746 - Update PDF.js to new version 63b66b412cb3be6919c14436487c667a1597a732 r=pdfjs-reviewers,marco 2024-05-20 12:31:13 +00:00
pictureinpicture Bug 1803678 - enable lazy loading of ESModule based moz- custom elements r=reusable-components-reviewers,pip-reviewers,credential-management-reviewers,translations-reviewers,kpatenio,issammani,mstriemer 2024-04-24 19:16:46 +00:00
places Bug 1897148 - Disable HTTPS-First for test_page-icon_protocol.js r=freddyb,places-reviewers 2024-05-16 15:15:57 +00:00
printing Bug 1890824 - Simplify number input styles in the print dialog. r=Itiel,desktop-theme-reviewers,dao 2024-04-10 20:52:44 +00:00
printingui
processsingleton Bug 1864896: Autofix unused function arguments (toolkit). r=mconley,translations-reviewers,omc-reviewers,aminomancer 2024-03-19 14:59:21 +00:00
processtools Bug 1835983 - Update tests in toolkit/components/ to work with https-first enabled r=freddyb 2024-04-24 11:12:51 +00:00
promiseworker Bug 1864896: Autofix unused function arguments (toolkit). r=mconley,translations-reviewers,omc-reviewers,aminomancer 2024-03-19 14:59:21 +00:00
prompts Bug 1885449 - Move GV code shared between Android and iOS to a shared directory. r=geckoview-reviewers,frontend-codestyle-reviewers,nalexander,owlish 2024-05-16 22:08:51 +00:00
protobuf Bug 1874741 - Part 1: Add a protobuf implementation for parsing Google's SOCS cookie. r=anti-tracking-reviewers,pbz 2024-03-29 23:15:11 +00:00
reader Bug 1895692 - turn off import/no-unassigned-import for storybook files, r=reusable-components-reviewers,frontend-codestyle-reviewers,hjones 2024-05-15 16:08:57 +00:00
reflect
remote Bug 1896846 [Linux] Use GetDBusAppName() for DBus remote services r=emilio 2024-05-16 08:39:37 +00:00
remotebrowserutils Bug 1888992 - Remove fission.preserve_browsing_contexts pref r=nika 2024-04-02 17:16:41 +00:00
reportbrokensite Bug 1864896: Autofix unused function arguments (toolkit). r=mconley,translations-reviewers,omc-reviewers,aminomancer 2024-03-19 14:59:21 +00:00
reputationservice Bug 1881863 - Part 1: Standardize on boolean over bool in xpidl, r=xpcom-reviewers,necko-reviewers,valentin,extension-reviewers,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,search-reviewers,anti-tracking-reviewers,places-reviewers,nalexander,emilio,zombie,sgalich,karlt,lina,Standard8 2024-04-04 18:45:21 +00:00
resistfingerprinting Bug 1897506: Remove the additional telemetry data from the user characteristics pings r=chutten 2024-05-20 15:31:45 +00:00
satchel Bug 1891641 - Add label and magnifying glass icon to Megalist search bar. r=mtigley,credential-management-reviewers,ayeddi,fluent-reviewers 2024-05-17 18:40:01 +00:00
search Bug 1895960 - Only pass the queryCharset through to ParamSubstitution rather than a full engine object. r=search-reviewers,daleharvey 2024-05-13 22:10:30 +00:00
sessionstore Bug 1677190 - Introduce SessionStoreFunctions for GeckoView package and move the existing SessionStoreFunctions from toolkit to the browser package. r=geckoview-reviewers,farre,nika,owlish 2024-04-30 11:17:55 +00:00
shell
shopping Bug 1864896: Autofix unused function arguments (toolkit). r=mconley,translations-reviewers,omc-reviewers,aminomancer 2024-03-19 14:59:21 +00:00
startup Bug 1881863 - Part 1: Standardize on boolean over bool in xpidl, r=xpcom-reviewers,necko-reviewers,valentin,extension-reviewers,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,search-reviewers,anti-tracking-reviewers,places-reviewers,nalexander,emilio,zombie,sgalich,karlt,lina,Standard8 2024-04-04 18:45:21 +00:00
statusfilter
taskscheduler Bug 1864896: Autofix unused function arguments (toolkit). r=mconley,translations-reviewers,omc-reviewers,aminomancer 2024-03-19 14:59:21 +00:00
telemetry Bug 1844044 - Keep event page alive while waiting for permissions.request() r=robwu 2024-05-21 02:45:20 +00:00
terminator Bug 1879136 - Stop writing ShutdownDuration.json at shutdown. r=jstutte 2024-04-09 14:18:30 +00:00
thumbnails Bug 1864896: Autofix unused function arguments (toolkit). r=mconley,translations-reviewers,omc-reviewers,aminomancer 2024-03-19 14:59:21 +00:00
timermanager Bug 1864896: Autofix unused function arguments (toolkit). r=mconley,translations-reviewers,omc-reviewers,aminomancer 2024-03-19 14:59:21 +00:00
tooltiptext Bug 1889669 - add mozinfo to reftest sandbox. r=ahal 2024-04-11 16:29:15 +00:00
translation Bug 1889943 - use renamed Bugzilla component 'Firefox :: Translations' in moz.build files. r=translations-reviewers,nordzilla 2024-04-08 19:20:47 +00:00
translations Bug 1893288 - Update the docs for translations for 2024; r=translations-reviewers,nordzilla 2024-05-13 13:59:05 +00:00
typeaheadfind
uniffi-bindgen-gecko-js Bug 1895888 - Vendor fully-implemented Rust relevancy component r=bdk 2024-05-09 19:56:58 +00:00
uniffi-fixtures Bug 1890866 - Reorganize the UniFFI fixtures/examples. r=markh 2024-04-15 18:07:00 +00:00
uniffi-js Bug 1895888 - Vendor fully-implemented Rust relevancy component r=bdk 2024-05-09 19:56:58 +00:00
url-classifier Bug 1825179 - Added canonicalization to query parameters for Google Safe Browsing. r=timhuang 2024-03-29 00:00:29 +00:00
urlformatter
utils Bug 1864896: Autofix unused function arguments (toolkit). r=mconley,translations-reviewers,omc-reviewers,aminomancer 2024-03-19 14:59:21 +00:00
viaduct
viewsource Bug 1880914 - Move view source functions. r=Gijs 2024-04-08 17:21:01 +00:00
windowcreator Bug 1892481 - More consistently enforce noscript and builtinclass in xpidl, r=xpcom-reviewers,necko-reviewers,valentin,media-playback-reviewers,mccr8,padenot 2024-04-22 18:19:58 +00:00
windowwatcher Bug 1777509 - Don't return browsing context directly when creating new window. r=nika,geckoview-reviewers,owlish 2024-04-24 11:17:43 +00:00
workerloader Bug 1864896: Autofix unused function arguments (toolkit). r=mconley,translations-reviewers,omc-reviewers,aminomancer 2024-03-19 14:59:21 +00:00
xulstore Bug 1881863 - Part 1: Standardize on boolean over bool in xpidl, r=xpcom-reviewers,necko-reviewers,valentin,extension-reviewers,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,search-reviewers,anti-tracking-reviewers,places-reviewers,nalexander,emilio,zombie,sgalich,karlt,lina,Standard8 2024-04-04 18:45:21 +00:00
components.conf
DefaultCLH.sys.mjs
moz.build Bug 1889710 - disable building normandy for thunderbird. r=barret 2024-04-04 17:48:09 +00:00
update-jsoncpp.sh