forked from mirrors/gecko-dev
084c9b6f4c
This changes the lifecycle and API for TextureReadLock to fix file descriptor exhaustion
crashes. These changes are partially superficial and mostly align the API of TextureReadLocks
with their actual usage.
The changes are:
1. Create the TextureReadLock in the TextureClient constructor so it's available before IPC creation
a. This is superficial as EnableReadLock was always called before IPC creation
2. Send the ReadLockDescriptor in the PTextureConstructor message and close the file handle
3. Receive the ReadLockDescriptor in TextureHost and close the file handle
4. Send a boolean flag in layer transactions if the texture is read locked instead of a descriptor
5. Use a boolean flag in TextureHost to determine if the ReadLock must be unlocked instead of a nullptr
I believe that we can remove the InitReadLocks code from LayerTransaction as that was added to
prevent file descriptor limits in IPDL messages and is no longer needed with this change. But
that is a non-essential change and this patch is already big enough.
MozReview-Commit-ID: DzHujrOQejH
--HG--
extra : rebase_source : 3bdd7c9bc8edfdc386faad8a9e59ad7dc18ed91d
84 lines
2.6 KiB
C++
84 lines
2.6 KiB
C++
/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#ifndef MOZILLA_LAYERS_TEXTUREFORWARDER
|
|
#define MOZILLA_LAYERS_TEXTUREFORWARDER
|
|
|
|
#include <stdint.h> // for int32_t, uint64_t
|
|
#include "gfxTypes.h"
|
|
#include "mozilla/layers/LayersMessages.h" // for Edit, etc
|
|
#include "mozilla/layers/LayersTypes.h" // for LayersBackend
|
|
#include "mozilla/layers/TextureClient.h" // for TextureClient
|
|
#include "mozilla/layers/KnowsCompositor.h"
|
|
|
|
namespace mozilla {
|
|
namespace ipc {
|
|
class IShmemAllocator;
|
|
}
|
|
namespace layers {
|
|
|
|
/**
|
|
* An abstract interface for classes that implement the autogenerated
|
|
* IPDL actor class. Lets us check if they are still valid for IPC.
|
|
*/
|
|
class LayersIPCActor {
|
|
public:
|
|
virtual bool IPCOpen() const { return true; }
|
|
};
|
|
|
|
/**
|
|
* An abstract interface for LayersIPCActors that implement a top-level
|
|
* IPDL protocol so also have their own channel.
|
|
* Has their own MessageLoop for message dispatch, and can allocate
|
|
* shmem.
|
|
*/
|
|
class LayersIPCChannel : public LayersIPCActor
|
|
, public mozilla::ipc::IShmemAllocator {
|
|
public:
|
|
NS_INLINE_DECL_PURE_VIRTUAL_REFCOUNTING
|
|
|
|
virtual bool IsSameProcess() const = 0;
|
|
|
|
virtual bool UsesImageBridge() const { return false; }
|
|
|
|
virtual base::ProcessId GetParentPid() const = 0;
|
|
|
|
virtual MessageLoop* GetMessageLoop() const = 0;
|
|
|
|
virtual FixedSizeSmallShmemSectionAllocator* GetTileLockAllocator() { return nullptr; }
|
|
|
|
virtual void CancelWaitForRecycle(uint64_t aTextureId) = 0;
|
|
|
|
virtual wr::MaybeExternalImageId GetNextExternalImageId() { return Nothing(); }
|
|
|
|
protected:
|
|
virtual ~LayersIPCChannel() {}
|
|
};
|
|
|
|
/**
|
|
* An abstract interface for classes that can allocate PTexture objects
|
|
* across IPDL. Currently a sub-class of LayersIPCChannel for simplicity
|
|
* since all our implementations use both, but could be independant if needed.
|
|
*/
|
|
class TextureForwarder : public LayersIPCChannel {
|
|
public:
|
|
/**
|
|
* Create a TextureChild/Parent pair as as well as the TextureHost on the parent side.
|
|
*/
|
|
virtual PTextureChild* CreateTexture(
|
|
const SurfaceDescriptor& aSharedData,
|
|
const ReadLockDescriptor& aReadLock,
|
|
LayersBackend aLayersBackend,
|
|
TextureFlags aFlags,
|
|
uint64_t aSerial,
|
|
wr::MaybeExternalImageId& aExternalImageId,
|
|
nsIEventTarget* aTarget = nullptr) = 0;
|
|
};
|
|
|
|
} // namespace layers
|
|
} // namespace mozilla
|
|
|
|
#endif
|