forked from mirrors/gecko-dev
084c9b6f4c
This changes the lifecycle and API for TextureReadLock to fix file descriptor exhaustion
crashes. These changes are partially superficial and mostly align the API of TextureReadLocks
with their actual usage.
The changes are:
1. Create the TextureReadLock in the TextureClient constructor so it's available before IPC creation
a. This is superficial as EnableReadLock was always called before IPC creation
2. Send the ReadLockDescriptor in the PTextureConstructor message and close the file handle
3. Receive the ReadLockDescriptor in TextureHost and close the file handle
4. Send a boolean flag in layer transactions if the texture is read locked instead of a descriptor
5. Use a boolean flag in TextureHost to determine if the ReadLock must be unlocked instead of a nullptr
I believe that we can remove the InitReadLocks code from LayerTransaction as that was added to
prevent file descriptor limits in IPDL messages and is no longer needed with this change. But
that is a non-essential change and this patch is already big enough.
MozReview-Commit-ID: DzHujrOQejH
--HG--
extra : rebase_source : 3bdd7c9bc8edfdc386faad8a9e59ad7dc18ed91d
80 lines
2.8 KiB
C++
80 lines
2.8 KiB
C++
/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#ifndef MOZILLA_GFX_VIDEOBRIDGECHILD_H
|
|
#define MOZILLA_GFX_VIDEOBRIDGECHILD_H
|
|
|
|
#include "mozilla/layers/PVideoBridgeChild.h"
|
|
#include "ISurfaceAllocator.h"
|
|
#include "TextureForwarder.h"
|
|
|
|
namespace mozilla {
|
|
namespace layers {
|
|
|
|
class VideoBridgeChild final : public PVideoBridgeChild
|
|
, public TextureForwarder
|
|
{
|
|
public:
|
|
NS_INLINE_DECL_THREADSAFE_REFCOUNTING(VideoBridgeChild, override);
|
|
|
|
static void Startup();
|
|
static void Shutdown();
|
|
|
|
static VideoBridgeChild* GetSingleton();
|
|
|
|
// PVideoBridgeChild
|
|
PTextureChild* AllocPTextureChild(const SurfaceDescriptor& aSharedData,
|
|
const ReadLockDescriptor& aReadLock,
|
|
const LayersBackend& aLayersBackend,
|
|
const TextureFlags& aFlags,
|
|
const uint64_t& aSerial) override;
|
|
bool DeallocPTextureChild(PTextureChild* actor) override;
|
|
|
|
void ActorDestroy(ActorDestroyReason aWhy) override;
|
|
void DeallocPVideoBridgeChild() override;
|
|
|
|
|
|
// ISurfaceAllocator
|
|
bool AllocUnsafeShmem(size_t aSize,
|
|
mozilla::ipc::SharedMemory::SharedMemoryType aShmType,
|
|
mozilla::ipc::Shmem* aShmem) override;
|
|
bool AllocShmem(size_t aSize,
|
|
mozilla::ipc::SharedMemory::SharedMemoryType aShmType,
|
|
mozilla::ipc::Shmem* aShmem) override;
|
|
bool DeallocShmem(mozilla::ipc::Shmem& aShmem) override;
|
|
|
|
// TextureForwarder
|
|
PTextureChild* CreateTexture(const SurfaceDescriptor& aSharedData,
|
|
const ReadLockDescriptor& aReadLock,
|
|
LayersBackend aLayersBackend,
|
|
TextureFlags aFlags,
|
|
uint64_t aSerial,
|
|
wr::MaybeExternalImageId& aExternalImageId,
|
|
nsIEventTarget* aTarget = nullptr) override;
|
|
|
|
// ClientIPCAllocator
|
|
base::ProcessId GetParentPid() const override { return OtherPid(); }
|
|
MessageLoop * GetMessageLoop() const override { return mMessageLoop; }
|
|
void CancelWaitForRecycle(uint64_t aTextureId) override { MOZ_ASSERT(false, "NO RECYCLING HERE"); }
|
|
|
|
// ISurfaceAllocator
|
|
bool IsSameProcess() const override;
|
|
|
|
bool CanSend() { return mCanSend; }
|
|
|
|
private:
|
|
VideoBridgeChild();
|
|
~VideoBridgeChild();
|
|
|
|
RefPtr<VideoBridgeChild> mIPDLSelfRef;
|
|
MessageLoop* mMessageLoop;
|
|
bool mCanSend;
|
|
};
|
|
|
|
} // namespace layers
|
|
} // namespace mozilla
|
|
|
|
#endif
|