nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
fune/python
History
Ricky Stewart c3dc1fbe77 Bug 1658651 - When determining whether virtualenvs are up to date, don't take file size into account r=mhentges,ahal 
This check is unsound; `virtualenv` binaries are apparently not guaranteed to have the same file size as the `python` binaries used to create those `virtualenv`s, at least not with our current vendored version of the `virtualenv` library on macOS. This is trivially reproducible on my own Macbook:

```
rickystewart-a5lvdq:mozilla-unified rickystewart$ rm -rf obj-x86_64-apple-darwin19.5.0/
rickystewart-a5lvdq:mozilla-unified rickystewart$ ./mach configure
...
rickystewart-a5lvdq:mozilla-unified rickystewart$ python3 -c 'import os; print(os.path.getsize("obj-x86_64-apple-darwin19.5.0/_virtualenvs/init_py3/bin/python"))'
16644  # <- ACTUAL VIRTUALENV SIZE
rickystewart-a5lvdq:mozilla-unified rickystewart$ python3 -c 'import os; print(os.path.getsize("/usr/local/opt/python/bin/python3.7"))'
17704  # <- SIZE OF THE PYTHON USED TO CREATE THE VIRTUALENV
```

Concretely, this was causing unit tests to be very aggressive about deleting the parent `init_py3` `virtualenv` repeatedly in unit tests, resulting in failures. The removal of this check fixes the issue.

Differential Revision: https://phabricator.services.mozilla.com/D86872
2020-08-13 19:29:54 +00:00
..
devtools/migrate-l10n
docs
gdbpp/gdbpp
l10n Bug 1654177 - Remove Fluent migration recipes for Firefox 78, r=Pike 2020-07-23 08:03:48 +00:00
lldbutils Bug 1637130 - Rename visual overflow to ink overflow. r=dbaron 2020-07-20 20:17:36 +00:00
mach Bug 985141 - Allow mach commands to specify what virtualenv they should use. r=mhentges,dmajor 2020-08-13 18:26:07 +00:00
mozboot Bug 1655361: Prints a warning if Windows Defender is watching the Firefox checkout directory r=firefox-build-system-reviewers,rstewart 2020-08-11 20:59:40 +00:00
mozbuild Bug 1658651 - When determining whether virtualenvs are up to date, don't take file size into account r=mhentges,ahal 2020-08-13 19:29:54 +00:00
mozlint Bug 1657604 - [mozlint] Support multiple linters per yaml file, r=linter-reviewers,sylvestre 2020-08-07 07:12:41 +00:00
mozperftest Bug 1650363 - Performance testing of HTTP3 in Firefox using only xpcshell tests r=michal,sparky 2020-08-10 06:26:39 +00:00
mozrelease Bug 1653662: [mozrelease] Update mozrelease subcommands to python 3; r=aki 2020-07-18 01:36:36 +00:00
mozterm
mozversioncontrol Bug 1658626 - When listing files from git in mozversioncontrol, ignore empty paths r=froydnj,mhentges 2020-08-12 00:10:43 +00:00
safety Bug 1656611 - Remove objdir support from virtualenv_packages.txt handling r=mhentges,froydnj 2020-08-07 16:03:36 +00:00
mach_commands.py Bug 1657719: Don't create init_py3_py3 venv in python-test r=firefox-build-system-reviewers,rstewart 2020-08-07 22:11:41 +00:00
moz.build Bug 925350 - Remove dumbmake r=nalexander 2020-07-10 18:12:07 +00:00
README

README 

This directory contains common Python code.

The basic rule is that if Python code is cross-module (that's "module" in the
Mozilla meaning - as in "module ownership") and is MPL-compatible, it should
go here.

What should not go here:

* Vendored python modules (use third_party/python instead)
* Python that is not MPL-compatible (see other-licenses/)
* Python that has good reason to remain close to its "owning" (Mozilla)
  module (e.g. it is only being consumed from there).

Historical information can be found at
https://bugzilla.mozilla.org/show_bug.cgi?id=775243
https://bugzilla.mozilla.org/show_bug.cgi?id=1346025