forked from mirrors/gecko-dev
e930b89c34
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
39 lines
2 KiB
JavaScript
39 lines
2 KiB
JavaScript
/* -*- Mode: indent-tabs-mode: nil; js-indent-level: 2 -*- */
|
|
/* vim: set sts=2 sw=2 et tw=80: */
|
|
"use strict";
|
|
|
|
/* exported BASE_URL, SOURCE_PAGE, OPENED_PAGE,
|
|
runCreatedNavigationTargetTest, assertNoPendingCreatedNavigationTargetData */
|
|
|
|
const BASE_URL = "http://mochi.test:8888/browser/browser/components/extensions/test/browser";
|
|
const SOURCE_PAGE = `${BASE_URL}/webNav_createdTargetSource.html`;
|
|
const OPENED_PAGE = `${BASE_URL}/webNav_createdTarget.html`;
|
|
|
|
async function runCreatedNavigationTargetTest({extension, openNavTarget, expectedWebNavProps}) {
|
|
await openNavTarget();
|
|
|
|
const webNavMsg = await extension.awaitMessage("webNavOnCreated");
|
|
const createdTabId = await extension.awaitMessage("tabsOnCreated");
|
|
const completedNavMsg = await extension.awaitMessage("webNavOnCompleted");
|
|
|
|
let {sourceTabId, sourceFrameId, url} = expectedWebNavProps;
|
|
|
|
is(webNavMsg.tabId, createdTabId, "Got the expected tabId property");
|
|
is(webNavMsg.sourceTabId, sourceTabId, "Got the expected sourceTabId property");
|
|
is(webNavMsg.sourceFrameId, sourceFrameId, "Got the expected sourceFrameId property");
|
|
is(webNavMsg.url, url, "Got the expected url property");
|
|
|
|
is(completedNavMsg.tabId, createdTabId, "Got the expected webNavigation.onCompleted tabId property");
|
|
is(completedNavMsg.url, url, "Got the expected webNavigation.onCompleted url property");
|
|
}
|
|
|
|
|
|
// Test that there are no pending createdNavigationTarget messages still tracked
|
|
// in WebNavigation.jsm (to be called before the extension is unloaded, because
|
|
// once the last extension which have subscribed a webNavigation event is unloaded
|
|
// all the pending created navigation target data is completely cleared).
|
|
function assertNoPendingCreatedNavigationTargetData() {
|
|
const {Manager} = ChromeUtils.import("resource://gre/modules/WebNavigation.jsm", null);
|
|
Assert.equal(Manager.createdNavigationTargetByOuterWindowId.size, 0,
|
|
"There should be no pending createdNavigationTarget messages in WebNavigation");
|
|
}
|