forked from mirrors/gecko-dev
Tie into `code_analysis`'s `get_clang_tools()` functionality to
intelligently bootstrap clang if it either doesn't exist or is
out-of-date.
This required exposing `command_context` to the linting logic, as it's
needed to call `artifact_toolchain(...)`.
Note that this means that the standalone `runcli.py` file won't be able
to support bootstrapping `clang-format`, or other linters that lean on
`command_context` in the future.
Finally, `substs.get("HOST_BIN_SUFFIX")` was replaced with a
windows-specific `binary += ".exe"`, because not all contexts where
the tests are run will have access to populated `substs` data.
Note that this worked before without the extension because it was
only used for starting a process, in which context Windows automatically
tries all `PATHEXT` options. Since we're now doing an `isfile()` check
(to enable more intelligent failure cases when `clang-format` doesn't
exist), we need the path to be fully correct.
Differential Revision: https://phabricator.services.mozilla.com/D137335
200 lines
5.8 KiB
Python
200 lines
5.8 KiB
Python
# This Source Code Form is subject to the terms of the Mozilla Public
|
|
# License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
|
|
import os
|
|
import signal
|
|
import re
|
|
import sys
|
|
|
|
from mozboot.util import get_tools_dir
|
|
from mozlint import result
|
|
from mozlint.pathutils import expand_exclusions
|
|
from mozprocess import ProcessHandler
|
|
|
|
CLANG_FORMAT_NOT_FOUND = """
|
|
Could not find clang-format! It should've been installed automatically - \
|
|
please report a bug here:
|
|
https://bugzilla.mozilla.org/enter_bug.cgi?product=Firefox%20Build%20System&component=Lint%20and%20Formatting
|
|
""".strip()
|
|
|
|
|
|
def setup(root, mach_command_context, **lintargs):
|
|
if get_clang_format_binary():
|
|
return 0
|
|
|
|
from mozbuild.code_analysis.mach_commands import get_clang_tools
|
|
|
|
rc, _ = get_clang_tools(mach_command_context)
|
|
if rc:
|
|
return 1
|
|
|
|
|
|
def parse_issues(config, output, paths, log):
|
|
|
|
diff_line = re.compile("^(.*):(.*):(.*): warning: .*;(.*);(.*)")
|
|
results = []
|
|
for line in output:
|
|
match = diff_line.match(line)
|
|
file, line_no, col, diff, diff2 = match.groups()
|
|
log.debug(
|
|
"file={} line={} col={} diff={} diff2={}".format(
|
|
file, line_no, col, diff, diff2
|
|
)
|
|
)
|
|
d = diff + "\n" + diff2
|
|
res = {
|
|
"path": file,
|
|
"diff": d,
|
|
"level": "warning",
|
|
"lineno": line_no,
|
|
"column": col,
|
|
}
|
|
results.append(result.from_config(config, **res))
|
|
|
|
return results
|
|
|
|
|
|
class ClangFormatProcess(ProcessHandler):
|
|
def __init__(self, config, *args, **kwargs):
|
|
self.config = config
|
|
kwargs["stream"] = False
|
|
kwargs["universal_newlines"] = True
|
|
ProcessHandler.__init__(self, *args, **kwargs)
|
|
|
|
def run(self, *args, **kwargs):
|
|
orig = signal.signal(signal.SIGINT, signal.SIG_IGN)
|
|
ProcessHandler.run(self, *args, **kwargs)
|
|
signal.signal(signal.SIGINT, orig)
|
|
|
|
|
|
def run_process(config, cmd):
|
|
proc = ClangFormatProcess(config, cmd)
|
|
proc.run()
|
|
try:
|
|
proc.wait()
|
|
except KeyboardInterrupt:
|
|
proc.kill()
|
|
|
|
return proc.output
|
|
|
|
|
|
def get_clang_format_binary():
|
|
"""
|
|
Returns the path of the first clang-format binary available
|
|
if not found returns None
|
|
"""
|
|
binary = os.environ.get("CLANG_FORMAT")
|
|
if binary:
|
|
return binary
|
|
|
|
clang_tools_path = os.path.join(get_tools_dir(), "clang-tools")
|
|
bin_path = os.path.join(clang_tools_path, "clang-tidy", "bin")
|
|
binary = os.path.join(bin_path, "clang-format")
|
|
|
|
if sys.platform.startswith("win"):
|
|
binary += ".exe"
|
|
|
|
if not os.path.isfile(binary):
|
|
return None
|
|
|
|
return binary
|
|
|
|
|
|
def is_ignored_path(ignored_dir_re, topsrcdir, f):
|
|
# Remove up to topsrcdir in pathname and match
|
|
if f.startswith(topsrcdir + "/"):
|
|
match_f = f[len(topsrcdir + "/") :]
|
|
else:
|
|
match_f = f
|
|
return re.match(ignored_dir_re, match_f)
|
|
|
|
|
|
def remove_ignored_path(paths, topsrcdir, log):
|
|
path_to_third_party = os.path.join(topsrcdir, ".clang-format-ignore")
|
|
|
|
ignored_dir = []
|
|
with open(path_to_third_party, "r") as fh:
|
|
for line in fh:
|
|
# In case it starts with a space
|
|
line = line.strip()
|
|
# Remove comments and empty lines
|
|
if line.startswith("#") or len(line) == 0:
|
|
continue
|
|
# The regexp is to make sure we are managing relative paths
|
|
ignored_dir.append(r"^[\./]*" + line.rstrip())
|
|
|
|
# Generates the list of regexp
|
|
ignored_dir_re = "(%s)" % "|".join(ignored_dir)
|
|
|
|
path_list = []
|
|
for f in paths:
|
|
if is_ignored_path(ignored_dir_re, topsrcdir, f):
|
|
# Early exit if we have provided an ignored directory
|
|
log.debug("Ignored third party code '{0}'".format(f))
|
|
continue
|
|
path_list.append(f)
|
|
|
|
return path_list
|
|
|
|
|
|
def lint(paths, config, fix=None, **lintargs):
|
|
log = lintargs["log"]
|
|
paths = list(expand_exclusions(paths, config, lintargs["root"]))
|
|
|
|
# We ignored some specific files for a bunch of reasons.
|
|
# Not using excluding to avoid duplication
|
|
if lintargs.get("use_filters", True):
|
|
paths = remove_ignored_path(paths, lintargs["root"], log)
|
|
|
|
# An empty path array can occur when the user passes in `-n`. If we don't
|
|
# return early in this case, rustfmt will attempt to read stdin and hang.
|
|
if not paths:
|
|
return []
|
|
|
|
binary = get_clang_format_binary()
|
|
|
|
if not binary:
|
|
print(CLANG_FORMAT_NOT_FOUND)
|
|
if "MOZ_AUTOMATION" in os.environ:
|
|
return 1
|
|
return []
|
|
|
|
cmd_args = [binary]
|
|
|
|
base_command = cmd_args + ["--version"]
|
|
version = run_process(config, base_command)
|
|
log.debug("Version: {}".format(version))
|
|
|
|
cmd_args.append("--dry-run")
|
|
base_command = cmd_args + paths
|
|
log.debug("Command: {}".format(" ".join(cmd_args)))
|
|
output = run_process(config, base_command)
|
|
output_list = []
|
|
|
|
if len(output) % 3 != 0:
|
|
raise Exception(
|
|
"clang-format output should be a multiple of 3. Output: %s" % output
|
|
)
|
|
|
|
fixed = (int)(len(output) / 3)
|
|
if fix:
|
|
cmd_args.remove("--dry-run")
|
|
cmd_args.append("-i")
|
|
base_command = cmd_args + paths
|
|
log.debug("Command: {}".format(" ".join(cmd_args)))
|
|
output = run_process(config, base_command)
|
|
else:
|
|
fixed = 0
|
|
|
|
for i in range(0, len(output), 3):
|
|
# Merge the element 3 by 3 (clang-format output)
|
|
line = output[i]
|
|
line += ";" + output[i + 1]
|
|
line += ";" + output[i + 2]
|
|
output_list.append(line)
|
|
|
|
if fix:
|
|
# clang-format is able to fix all issues so don't bother parsing the output.
|
|
return {"results": [], "fixed": fixed}
|
|
return {"results": parse_issues(config, output_list, paths, log), "fixed": fixed}
|