forked from mirrors/gecko-dev
2c93600238
First, `EditorBase::CreateTransactionForDeleteSelection` returns an instance of `EditAggregateTransaction`. It's a base class of `PlaceholderTransaction` and `DeleteRangeTransaction` but it's also a concrete class. However, it's too generic. Therefore, this patch creates `DeleteMultipleRangesTransaction` which is a simple sub-class of it, and makes `EditAggregateTransaction` be an abstract class. Then, add `AddChild` methods to each concrete class to restrict the type of child transactions. Next, `DeleteRangeTransaction` contains only `DeleteNodeTransaction` and `DeleteTextTransaction`. Therefore, once they have a common base class, we can check the type easier. Therefore, this patch also adds `DeleteContentTransactionBase` and `EditorBase::CreateTransactionForCollapsedRange` becomes clearer what it returns. With these changes, `DeleteRangeTransaction` obviously contains only `DeleteContentTransactionBase`, `DeleteMultipleRangesTransaction` contains only `DeleteRangeTransaction`, `DeleteNodeTransaction` and `DeleteTextTransaction`. And they are guaranteed at build time (at least from outside the classes). *** fix Differential Revision: https://phabricator.services.mozilla.com/D169038
97 lines
3.7 KiB
C++
97 lines
3.7 KiB
C++
/* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#include "EditTransactionBase.h"
|
|
|
|
#include "mozilla/Logging.h"
|
|
|
|
#include "ChangeAttributeTransaction.h"
|
|
#include "ChangeStyleTransaction.h"
|
|
#include "CompositionTransaction.h"
|
|
#include "DeleteContentTransactionBase.h"
|
|
#include "DeleteMultipleRangesTransaction.h"
|
|
#include "DeleteNodeTransaction.h"
|
|
#include "DeleteRangeTransaction.h"
|
|
#include "DeleteTextTransaction.h"
|
|
#include "EditAggregateTransaction.h"
|
|
#include "InsertNodeTransaction.h"
|
|
#include "InsertTextTransaction.h"
|
|
#include "JoinNodesTransaction.h"
|
|
#include "MoveNodeTransaction.h"
|
|
#include "PlaceholderTransaction.h"
|
|
#include "ReplaceTextTransaction.h"
|
|
#include "SplitNodeTransaction.h"
|
|
|
|
#include "nsError.h"
|
|
#include "nsISupports.h"
|
|
|
|
namespace mozilla {
|
|
|
|
NS_IMPL_CYCLE_COLLECTION_CLASS(EditTransactionBase)
|
|
|
|
NS_IMPL_CYCLE_COLLECTION_UNLINK_0(EditTransactionBase)
|
|
NS_IMPL_CYCLE_COLLECTION_TRAVERSE_BEGIN(EditTransactionBase)
|
|
// We don't have anything to traverse, but some of our subclasses do.
|
|
NS_IMPL_CYCLE_COLLECTION_TRAVERSE_END
|
|
|
|
NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION(EditTransactionBase)
|
|
NS_INTERFACE_MAP_ENTRY(nsITransaction)
|
|
NS_INTERFACE_MAP_ENTRY_AMBIGUOUS(nsISupports, nsITransaction)
|
|
NS_INTERFACE_MAP_END
|
|
|
|
NS_IMPL_CYCLE_COLLECTING_ADDREF(EditTransactionBase)
|
|
NS_IMPL_CYCLE_COLLECTING_RELEASE(EditTransactionBase)
|
|
|
|
NS_IMETHODIMP EditTransactionBase::RedoTransaction() {
|
|
MOZ_LOG(GetLogModule(), LogLevel::Info, ("%p %s", this, __FUNCTION__));
|
|
return DoTransaction();
|
|
}
|
|
|
|
NS_IMETHODIMP EditTransactionBase::GetIsTransient(bool* aIsTransient) {
|
|
MOZ_LOG(GetLogModule(), LogLevel::Verbose,
|
|
("%p %s returned false", this, __FUNCTION__));
|
|
*aIsTransient = false;
|
|
return NS_OK;
|
|
}
|
|
|
|
NS_IMETHODIMP EditTransactionBase::Merge(nsITransaction* aOtherTransaction,
|
|
bool* aDidMerge) {
|
|
MOZ_LOG(GetLogModule(), LogLevel::Info,
|
|
("%p %s(aOtherTransaction=%p) returned false", this, __FUNCTION__,
|
|
aOtherTransaction));
|
|
*aDidMerge = false;
|
|
return NS_OK;
|
|
}
|
|
|
|
// static
|
|
LogModule* EditTransactionBase::GetLogModule() {
|
|
static LazyLogModule sLog("EditorTransaction");
|
|
return static_cast<LogModule*>(sLog);
|
|
}
|
|
|
|
#define NS_IMPL_EDITTRANSACTIONBASE_GETASMETHODS(aClass) \
|
|
aClass* EditTransactionBase::GetAs##aClass() { return nullptr; } \
|
|
const aClass* EditTransactionBase::GetAs##aClass() const { return nullptr; }
|
|
|
|
NS_IMPL_EDITTRANSACTIONBASE_GETASMETHODS(ChangeAttributeTransaction)
|
|
NS_IMPL_EDITTRANSACTIONBASE_GETASMETHODS(ChangeStyleTransaction)
|
|
NS_IMPL_EDITTRANSACTIONBASE_GETASMETHODS(CompositionTransaction)
|
|
NS_IMPL_EDITTRANSACTIONBASE_GETASMETHODS(DeleteContentTransactionBase)
|
|
NS_IMPL_EDITTRANSACTIONBASE_GETASMETHODS(DeleteMultipleRangesTransaction)
|
|
NS_IMPL_EDITTRANSACTIONBASE_GETASMETHODS(DeleteNodeTransaction)
|
|
NS_IMPL_EDITTRANSACTIONBASE_GETASMETHODS(DeleteRangeTransaction)
|
|
NS_IMPL_EDITTRANSACTIONBASE_GETASMETHODS(DeleteTextTransaction)
|
|
NS_IMPL_EDITTRANSACTIONBASE_GETASMETHODS(EditAggregateTransaction)
|
|
NS_IMPL_EDITTRANSACTIONBASE_GETASMETHODS(InsertNodeTransaction)
|
|
NS_IMPL_EDITTRANSACTIONBASE_GETASMETHODS(InsertTextTransaction)
|
|
NS_IMPL_EDITTRANSACTIONBASE_GETASMETHODS(JoinNodesTransaction)
|
|
NS_IMPL_EDITTRANSACTIONBASE_GETASMETHODS(MoveNodeTransaction)
|
|
NS_IMPL_EDITTRANSACTIONBASE_GETASMETHODS(PlaceholderTransaction)
|
|
NS_IMPL_EDITTRANSACTIONBASE_GETASMETHODS(ReplaceTextTransaction)
|
|
NS_IMPL_EDITTRANSACTIONBASE_GETASMETHODS(SplitNodeTransaction)
|
|
|
|
#undef NS_IMPL_EDITTRANSACTIONBASE_GETASMETHODS
|
|
|
|
} // namespace mozilla
|