forked from mirrors/gecko-dev
e6192bfc52
This commit adds hooks to the Servo style traversal to avoid traversing all the DOM for every restyle. Additionally it changes the behavior of the dirty flag to be propagated top down, to prevent extra overhead when an element is dirtied. This commit doesn't aim to change the behavior on Servo just yet, since Servo does extra job when dirtying the node related with DOM revision counters that might be necessary. CC @asajeffrey for the DOM revision counters stuff. When a node is dirty, do all its descendants really need to increment the revision counter, or is this an unintended effect? My intuition is that this is hurting performance quite a lot for servo. r? @bholley <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors <!-- Either: --> - [x] These changes do not require tests because no geckolib tests yet. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 944d371b8f0e72f6aa5465be38c0c8daeab66127
37 lines
1 KiB
Rust
37 lines
1 KiB
Rust
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
//! Implements sequential traversal over the DOM tree.
|
|
|
|
use dom::TNode;
|
|
use traversal::DomTraversalContext;
|
|
|
|
pub fn traverse_dom<N, C>(root: N,
|
|
shared: &C::SharedContext)
|
|
where N: TNode,
|
|
C: DomTraversalContext<N>
|
|
{
|
|
fn doit<'a, N, C>(context: &'a C, node: N)
|
|
where N: TNode,
|
|
C: DomTraversalContext<N>
|
|
{
|
|
debug_assert!(context.should_process(node));
|
|
context.process_preorder(node);
|
|
|
|
for kid in node.children() {
|
|
context.pre_process_child_hook(node, kid);
|
|
if context.should_process(node) {
|
|
doit::<N, C>(context, kid);
|
|
}
|
|
}
|
|
|
|
context.process_postorder(node);
|
|
}
|
|
|
|
let context = C::new(shared, root.opaque());
|
|
if context.should_process(root) {
|
|
doit::<N, C>(&context, root);
|
|
}
|
|
}
|
|
|