forked from mirrors/gecko-dev
db9e1a5ab1
The motivations for this are: 1) Apply global excludes. This merges the exclusion rules defined in tools/lint/mach_commands.py with the ones in .flake8. 2) Improve performance. Switching to a blacklist will result in a much longer runtime for linting the entire tree and flake8 handles exclusions incredibly slowly. Without this patch (and the blacklist change applied), I gave up waiting after 30 minutes. With this patch, it takes 30 seconds. Depends on D20495 Differential Revision: https://phabricator.services.mozilla.com/D20496 --HG-- rename : tools/lint/test/files/flake8/bad.py => tools/lint/test/files/flake8/subdir/exclude/bad.py extra : moz-landing-system : lando
88 lines
2.4 KiB
Python
88 lines
2.4 KiB
Python
import os
|
|
|
|
import mozunit
|
|
|
|
LINTER = 'flake8'
|
|
|
|
|
|
def test_lint_single_file(lint, paths):
|
|
results = lint(paths('bad.py'))
|
|
assert len(results) == 2
|
|
assert results[0].rule == 'F401'
|
|
assert results[1].rule == 'E501'
|
|
assert results[1].lineno == 5
|
|
|
|
# run lint again to make sure the previous results aren't counted twice
|
|
results = lint(paths('bad.py'))
|
|
assert len(results) == 2
|
|
|
|
|
|
def test_lint_custom_config_ignored(lint, paths):
|
|
results = lint(paths('custom'))
|
|
assert len(results) == 2
|
|
|
|
results = lint(paths('custom/good.py'))
|
|
assert len(results) == 2
|
|
|
|
|
|
def test_lint_fix(lint, create_temp_file):
|
|
contents = """
|
|
import distutils
|
|
|
|
def foobar():
|
|
pass
|
|
""".lstrip()
|
|
|
|
path = create_temp_file(contents, name='bad.py')
|
|
results = lint([path])
|
|
assert len(results) == 2
|
|
|
|
# Make sure the missing blank line is fixed, but the unused import isn't.
|
|
results = lint([path], fix=True)
|
|
assert len(results) == 1
|
|
|
|
# Also test with a directory
|
|
path = os.path.dirname(create_temp_file(contents, name='bad2.py'))
|
|
results = lint([path], fix=True)
|
|
# There should now be two files with 2 combined errors
|
|
assert len(results) == 2
|
|
assert all(r.rule != 'E501' for r in results)
|
|
|
|
|
|
def test_lint_fix_uses_config(lint, create_temp_file):
|
|
contents = """
|
|
foo = ['A list of strings', 'that go over 80 characters', 'to test if autopep8 fixes it']
|
|
""".lstrip()
|
|
|
|
path = create_temp_file(contents, name='line_length.py')
|
|
lint([path], fix=True)
|
|
|
|
# Make sure autopep8 reads the global config under lintargs['root']. If it
|
|
# didn't, then the line-length over 80 would get fixed.
|
|
with open(path, 'r') as fh:
|
|
assert fh.read() == contents
|
|
|
|
|
|
def test_lint_excluded_file(lint, paths, config):
|
|
# First file is globally excluded, second one is from .flake8 config.
|
|
files = paths('bad.py', 'subdir/exclude/bad.py')
|
|
config['exclude'] = paths('bad.py')
|
|
results = lint(files, config)
|
|
print(results)
|
|
assert len(results) == 0
|
|
|
|
# Make sure excludes also apply when running from a different cwd.
|
|
cwd = paths('subdir')[0]
|
|
os.chdir(cwd)
|
|
|
|
results = lint(paths('subdir/exclude'))
|
|
assert len(results) == 0
|
|
|
|
|
|
def test_lint_uses_custom_extensions(lint, paths):
|
|
assert len(lint(paths('ext'))) == 1
|
|
assert len(lint(paths('ext/bad.configure'))) == 1
|
|
|
|
|
|
if __name__ == '__main__':
|
|
mozunit.main()
|