forked from mirrors/gecko-dev
This fixes screen sizes when using mutter with fractional scaling, and shouldn't change behavior otherwise. Without this patch, mutter with scale at 150% reports: [screen.width, screen.height] == [ 1920, 1080 ] With this it reports the proper [ 2560, 1440 ]. The bug that caused us to introduce it was long fixed in gtk itself, as I understand it, and ScreenGetterGtk is also what's used everywhere else on Wayland. Re-implement GetScreenForWindow in a way that works for ScreenGetterGtk too, to avoid regressing any functionality on mutter. Depends on D186341 Differential Revision: https://phabricator.services.mozilla.com/D186342
299 lines
9.2 KiB
C++
299 lines
9.2 KiB
C++
/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#include "ScreenHelperGTK.h"
|
|
|
|
#ifdef MOZ_X11
|
|
# include <gdk/gdkx.h>
|
|
# include <X11/Xlib.h>
|
|
# include "X11UndefineNone.h"
|
|
#endif /* MOZ_X11 */
|
|
#ifdef MOZ_WAYLAND
|
|
# include <gdk/gdkwayland.h>
|
|
#endif /* MOZ_WAYLAND */
|
|
#include <dlfcn.h>
|
|
#include <gtk/gtk.h>
|
|
|
|
#include "gfxPlatformGtk.h"
|
|
#include "mozilla/dom/DOMTypes.h"
|
|
#include "mozilla/Logging.h"
|
|
#include "mozilla/WidgetUtilsGtk.h"
|
|
#include "nsGtkUtils.h"
|
|
#include "nsTArray.h"
|
|
#include "nsWindow.h"
|
|
|
|
struct wl_registry;
|
|
|
|
#ifdef MOZ_WAYLAND
|
|
# include "nsWaylandDisplay.h"
|
|
#endif
|
|
|
|
namespace mozilla::widget {
|
|
|
|
#ifdef MOZ_LOGGING
|
|
static LazyLogModule sScreenLog("WidgetScreen");
|
|
# define LOG_SCREEN(...) MOZ_LOG(sScreenLog, LogLevel::Debug, (__VA_ARGS__))
|
|
#else
|
|
# define LOG_SCREEN(...)
|
|
#endif /* MOZ_LOGGING */
|
|
|
|
using GdkMonitor = struct _GdkMonitor;
|
|
|
|
class ScreenGetterGtk final {
|
|
public:
|
|
ScreenGetterGtk() = default;
|
|
~ScreenGetterGtk();
|
|
|
|
void Init();
|
|
|
|
#ifdef MOZ_X11
|
|
Atom NetWorkareaAtom() { return mNetWorkareaAtom; }
|
|
#endif
|
|
|
|
// For internal use from signal callback functions
|
|
void RefreshScreens();
|
|
|
|
private:
|
|
GdkWindow* mRootWindow = nullptr;
|
|
#ifdef MOZ_X11
|
|
Atom mNetWorkareaAtom = 0;
|
|
#endif
|
|
};
|
|
|
|
static GdkMonitor* GdkDisplayGetMonitor(GdkDisplay* aDisplay, int aMonitorNum) {
|
|
static auto s_gdk_display_get_monitor = (GdkMonitor * (*)(GdkDisplay*, int))
|
|
dlsym(RTLD_DEFAULT, "gdk_display_get_monitor");
|
|
if (!s_gdk_display_get_monitor) {
|
|
return nullptr;
|
|
}
|
|
return s_gdk_display_get_monitor(aDisplay, aMonitorNum);
|
|
}
|
|
|
|
RefPtr<Screen> ScreenHelperGTK::GetScreenForWindow(nsWindow* aWindow) {
|
|
LOG_SCREEN("GetScreenForWindow() [%p]", aWindow);
|
|
|
|
static auto s_gdk_display_get_monitor_at_window =
|
|
(GdkMonitor * (*)(GdkDisplay*, GdkWindow*))
|
|
dlsym(RTLD_DEFAULT, "gdk_display_get_monitor_at_window");
|
|
|
|
if (!s_gdk_display_get_monitor_at_window) {
|
|
LOG_SCREEN(" failed, missing Gtk helpers");
|
|
return nullptr;
|
|
}
|
|
|
|
GdkWindow* gdkWindow = gtk_widget_get_window(aWindow->GetGtkWidget());
|
|
if (!gdkWindow) {
|
|
LOG_SCREEN(" failed, can't get GdkWindow");
|
|
return nullptr;
|
|
}
|
|
|
|
GdkDisplay* display = gdk_display_get_default();
|
|
GdkMonitor* monitor = s_gdk_display_get_monitor_at_window(display, gdkWindow);
|
|
if (!monitor) {
|
|
LOG_SCREEN(" failed, can't get monitor for GdkWindow");
|
|
return nullptr;
|
|
}
|
|
|
|
int index = -1;
|
|
while (GdkMonitor* m = GdkDisplayGetMonitor(display, ++index)) {
|
|
if (m == monitor) {
|
|
return ScreenManager::GetSingleton().CurrentScreenList().SafeElementAt(
|
|
index);
|
|
}
|
|
}
|
|
|
|
LOG_SCREEN(" Couldn't find monitor %p", monitor);
|
|
return nullptr;
|
|
}
|
|
|
|
static UniquePtr<ScreenGetterGtk> gScreenGetter;
|
|
|
|
static void monitors_changed(GdkScreen* aScreen, gpointer aClosure) {
|
|
LOG_SCREEN("Received monitors-changed event");
|
|
auto* self = static_cast<ScreenGetterGtk*>(aClosure);
|
|
self->RefreshScreens();
|
|
}
|
|
|
|
static void screen_resolution_changed(GdkScreen* aScreen, GParamSpec* aPspec,
|
|
ScreenGetterGtk* self) {
|
|
self->RefreshScreens();
|
|
}
|
|
|
|
static GdkFilterReturn root_window_event_filter(GdkXEvent* aGdkXEvent,
|
|
GdkEvent* aGdkEvent,
|
|
gpointer aClosure) {
|
|
#ifdef MOZ_X11
|
|
ScreenGetterGtk* self = static_cast<ScreenGetterGtk*>(aClosure);
|
|
XEvent* xevent = static_cast<XEvent*>(aGdkXEvent);
|
|
|
|
switch (xevent->type) {
|
|
case PropertyNotify: {
|
|
XPropertyEvent* propertyEvent = &xevent->xproperty;
|
|
if (propertyEvent->atom == self->NetWorkareaAtom()) {
|
|
LOG_SCREEN("Work area size changed");
|
|
self->RefreshScreens();
|
|
}
|
|
} break;
|
|
default:
|
|
break;
|
|
}
|
|
#endif
|
|
|
|
return GDK_FILTER_CONTINUE;
|
|
}
|
|
|
|
void ScreenGetterGtk::Init() {
|
|
LOG_SCREEN("ScreenGetterGtk created");
|
|
GdkScreen* defaultScreen = gdk_screen_get_default();
|
|
if (!defaultScreen) {
|
|
// Sometimes we don't initial X (e.g., xpcshell)
|
|
MOZ_LOG(sScreenLog, LogLevel::Debug,
|
|
("defaultScreen is nullptr, running headless"));
|
|
return;
|
|
}
|
|
mRootWindow = gdk_get_default_root_window();
|
|
MOZ_ASSERT(mRootWindow);
|
|
|
|
g_object_ref(mRootWindow);
|
|
|
|
// GDK_PROPERTY_CHANGE_MASK ==> PropertyChangeMask, for PropertyNotify
|
|
gdk_window_set_events(mRootWindow,
|
|
GdkEventMask(gdk_window_get_events(mRootWindow) |
|
|
GDK_PROPERTY_CHANGE_MASK));
|
|
|
|
g_signal_connect(defaultScreen, "monitors-changed",
|
|
G_CALLBACK(monitors_changed), this);
|
|
// Use _after to ensure this callback is run after gfxPlatformGtk.cpp's
|
|
// handler.
|
|
g_signal_connect_after(defaultScreen, "notify::resolution",
|
|
G_CALLBACK(screen_resolution_changed), this);
|
|
#ifdef MOZ_X11
|
|
gdk_window_add_filter(mRootWindow, root_window_event_filter, this);
|
|
if (GdkIsX11Display()) {
|
|
mNetWorkareaAtom = XInternAtom(GDK_WINDOW_XDISPLAY(mRootWindow),
|
|
"_NET_WORKAREA", X11False);
|
|
}
|
|
#endif
|
|
RefreshScreens();
|
|
}
|
|
|
|
ScreenGetterGtk::~ScreenGetterGtk() {
|
|
if (mRootWindow) {
|
|
g_signal_handlers_disconnect_by_data(gdk_screen_get_default(), this);
|
|
|
|
gdk_window_remove_filter(mRootWindow, root_window_event_filter, this);
|
|
g_object_unref(mRootWindow);
|
|
mRootWindow = nullptr;
|
|
}
|
|
}
|
|
|
|
static uint32_t GetGTKPixelDepth() {
|
|
GdkVisual* visual = gdk_screen_get_system_visual(gdk_screen_get_default());
|
|
return gdk_visual_get_depth(visual);
|
|
}
|
|
|
|
static already_AddRefed<Screen> MakeScreenGtk(GdkScreen* aScreen,
|
|
gint aMonitorNum) {
|
|
gint gdkScaleFactor = ScreenHelperGTK::GetGTKMonitorScaleFactor(aMonitorNum);
|
|
|
|
// gdk_screen_get_monitor_geometry / workarea returns application pixels
|
|
// (desktop pixels), so we need to convert it to device pixels with
|
|
// gdkScaleFactor.
|
|
gint geometryScaleFactor = gdkScaleFactor;
|
|
|
|
LayoutDeviceIntRect rect;
|
|
|
|
gint refreshRate = [&] {
|
|
// Since gtk 3.22
|
|
static auto s_gdk_monitor_get_refresh_rate = (int (*)(GdkMonitor*))dlsym(
|
|
RTLD_DEFAULT, "gdk_monitor_get_refresh_rate");
|
|
|
|
if (!s_gdk_monitor_get_refresh_rate) {
|
|
return 0;
|
|
}
|
|
GdkMonitor* monitor =
|
|
GdkDisplayGetMonitor(gdk_display_get_default(), aMonitorNum);
|
|
if (!monitor) {
|
|
return 0;
|
|
}
|
|
// Convert to Hz.
|
|
return NSToIntRound(s_gdk_monitor_get_refresh_rate(monitor) / 1000.0f);
|
|
}();
|
|
|
|
GdkRectangle workarea;
|
|
gdk_screen_get_monitor_workarea(aScreen, aMonitorNum, &workarea);
|
|
LayoutDeviceIntRect availRect(workarea.x * geometryScaleFactor,
|
|
workarea.y * geometryScaleFactor,
|
|
workarea.width * geometryScaleFactor,
|
|
workarea.height * geometryScaleFactor);
|
|
if (GdkIsX11Display()) {
|
|
GdkRectangle monitor;
|
|
gdk_screen_get_monitor_geometry(aScreen, aMonitorNum, &monitor);
|
|
rect = LayoutDeviceIntRect(monitor.x * geometryScaleFactor,
|
|
monitor.y * geometryScaleFactor,
|
|
monitor.width * geometryScaleFactor,
|
|
monitor.height * geometryScaleFactor);
|
|
} else {
|
|
// We use Gtk workarea on Wayland as it matches our needs (Bug 1732682).
|
|
rect = availRect;
|
|
}
|
|
|
|
uint32_t pixelDepth = GetGTKPixelDepth();
|
|
|
|
// Use per-monitor scaling factor in gtk/wayland, or 1.0 otherwise.
|
|
DesktopToLayoutDeviceScale contentsScale(1.0);
|
|
#ifdef MOZ_WAYLAND
|
|
if (GdkIsWaylandDisplay()) {
|
|
contentsScale.scale = gdkScaleFactor;
|
|
}
|
|
#endif
|
|
|
|
CSSToLayoutDeviceScale defaultCssScale(gdkScaleFactor);
|
|
|
|
float dpi = 96.0f;
|
|
gint heightMM = gdk_screen_get_monitor_height_mm(aScreen, aMonitorNum);
|
|
if (heightMM > 0) {
|
|
dpi = rect.height / (heightMM / MM_PER_INCH_FLOAT);
|
|
}
|
|
|
|
LOG_SCREEN(
|
|
"New monitor %d size [%d,%d -> %d x %d] depth %d scale %f CssScale %f "
|
|
"DPI %f refresh %d ]",
|
|
aMonitorNum, rect.x, rect.y, rect.width, rect.height, pixelDepth,
|
|
contentsScale.scale, defaultCssScale.scale, dpi, refreshRate);
|
|
return MakeAndAddRef<Screen>(rect, availRect, pixelDepth, pixelDepth,
|
|
refreshRate, contentsScale, defaultCssScale, dpi,
|
|
Screen::IsPseudoDisplay::No);
|
|
}
|
|
|
|
void ScreenGetterGtk::RefreshScreens() {
|
|
LOG_SCREEN("ScreenGetterGtk::RefreshScreens()");
|
|
AutoTArray<RefPtr<Screen>, 4> screenList;
|
|
|
|
GdkScreen* defaultScreen = gdk_screen_get_default();
|
|
gint numScreens = gdk_screen_get_n_monitors(defaultScreen);
|
|
LOG_SCREEN("GDK reports %d screens", numScreens);
|
|
|
|
for (gint i = 0; i < numScreens; i++) {
|
|
screenList.AppendElement(MakeScreenGtk(defaultScreen, i));
|
|
}
|
|
|
|
ScreenManager::Refresh(std::move(screenList));
|
|
}
|
|
|
|
gint ScreenHelperGTK::GetGTKMonitorScaleFactor(gint aMonitorNum) {
|
|
GdkScreen* screen = gdk_screen_get_default();
|
|
return gdk_screen_get_monitor_scale_factor(screen, aMonitorNum);
|
|
}
|
|
|
|
ScreenHelperGTK::ScreenHelperGTK() {
|
|
gScreenGetter = MakeUnique<ScreenGetterGtk>();
|
|
gScreenGetter->Init();
|
|
}
|
|
|
|
ScreenHelperGTK::~ScreenHelperGTK() { gScreenGetter = nullptr; }
|
|
|
|
} // namespace mozilla::widget
|