fune/netwerk/system/netlink/NetlinkService.h
Valentin Gosu 1a1f42da37 Bug 1714307 - Run modernize-use-default-member-init --fix check on netwerk r=necko-reviewers,kershaw
This changeset is the result of adding modernize-use-default-member-init to
tools/clang-tidy/config.yaml then proceeding to run
`./mach static-analysis check netwerk/ --fix`
I then went through the resulting fix and manually updated all of the member
variables which were missed due to them having a non-trivial constructor.

Note that the tool was only run on Linux, so code that only runs on some
platforms may have been missed.

The member variables that are still initialized in the contructor definition
are:
  - bitfields (not all currently supported compilers allow default-member-init
  - variables that are initialized via a parameter
  - variables that use code not visible in the header file

There are a few advantages to landing this change:
- fewer lines of code - now declaration is in the same place as initialization
  this also makes it easier to see when looking at the header.
- it makes it harder to miss initializing a member when adding a new contructor
- variables that depend on an include guard look much nicer now

Additionally I removed some unnecessary reinitialization of NetAddr members
(it has a constructor that does that now), and changed nsWifiScannerDBus to
use the thread-safe strtok_r instead of strtok.

Differential Revision: https://phabricator.services.mozilla.com/D116980
2021-06-11 07:10:41 +00:00

169 lines
5.1 KiB
C++

/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim:set et sw=2 ts=4: */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#ifndef NETLINKSERVICE_H_
#define NETLINKSERVICE_H_
#include <netinet/in.h>
#include <linux/netlink.h>
#include "nsIRunnable.h"
#include "nsThreadUtils.h"
#include "nsCOMPtr.h"
#include "mozilla/Mutex.h"
#include "mozilla/TimeStamp.h"
#include "nsClassHashtable.h"
#include "mozilla/SHA1.h"
#include "mozilla/UniquePtr.h"
#include "nsTArray.h"
#include "mozilla/net/DNS.h"
namespace mozilla {
namespace net {
class NetlinkAddress;
class NetlinkNeighbor;
class NetlinkLink;
class NetlinkRoute;
class NetlinkMsg;
class NetlinkServiceListener : public nsISupports {
public:
virtual void OnNetworkChanged() = 0;
virtual void OnNetworkIDChanged() = 0;
virtual void OnLinkUp() = 0;
virtual void OnLinkDown() = 0;
virtual void OnLinkStatusKnown() = 0;
virtual void OnDnsSuffixListUpdated() = 0;
protected:
virtual ~NetlinkServiceListener() = default;
};
class NetlinkService : public nsIRunnable {
virtual ~NetlinkService();
public:
NS_DECL_THREADSAFE_ISUPPORTS
NS_DECL_NSIRUNNABLE
NetlinkService();
nsresult Init(NetlinkServiceListener* aListener);
nsresult Shutdown();
void GetNetworkID(nsACString& aNetworkID);
void GetIsLinkUp(bool* aIsUp);
nsresult GetDnsSuffixList(nsTArray<nsCString>& aDnsSuffixList);
nsresult GetResolvers(nsTArray<NetAddr>& aResolvers);
private:
void EnqueueGenMsg(uint16_t aMsgType, uint8_t aFamily);
void EnqueueRtMsg(uint8_t aFamily, void* aAddress);
void RemovePendingMsg();
mozilla::Mutex mMutex{"NetlinkService::mMutex"};
void OnNetlinkMessage(int aNetlinkSocket);
void OnLinkMessage(struct nlmsghdr* aNlh);
void OnAddrMessage(struct nlmsghdr* aNlh);
void OnRouteMessage(struct nlmsghdr* aNlh);
void OnNeighborMessage(struct nlmsghdr* aNlh);
void OnRouteCheckResult(struct nlmsghdr* aNlh);
void UpdateLinkStatus();
void TriggerNetworkIDCalculation();
int GetPollWait();
void GetGWNeighboursForFamily(uint8_t aFamily,
nsTArray<NetlinkNeighbor*>& aGwNeighbors);
bool CalculateIDForFamily(uint8_t aFamily, mozilla::SHA1Sum* aSHA1);
void CalculateNetworkID();
void ExtractDNSProperties();
nsCOMPtr<nsIThread> mThread;
bool mInitialScanFinished{false};
// A pipe to signal shutdown with.
int mShutdownPipe[2]{-1, -1};
// IP addresses that are used to check the route for public traffic.
struct in_addr mRouteCheckIPv4 {};
struct in6_addr mRouteCheckIPv6 {};
pid_t mPid;
uint32_t mMsgId{0};
bool mLinkUp{true};
// Flag indicating that network ID could change and should be recalculated.
// Calculation is postponed until we receive responses to all enqueued
// messages.
bool mRecalculateNetworkId{false};
// Flag indicating that network change event needs to be sent even if
// network ID hasn't changed.
bool mSendNetworkChangeEvent{false};
// Time stamp of setting mRecalculateNetworkId to true
mozilla::TimeStamp mTriggerTime;
nsCString mNetworkId;
nsTArray<nsCString> mDNSSuffixList;
nsTArray<NetAddr> mDNSResolvers;
class LinkInfo {
public:
explicit LinkInfo(UniquePtr<NetlinkLink>&& aLink);
virtual ~LinkInfo();
// Updates mIsUp according to current mLink and mAddresses. Returns true if
// the value has changed.
bool UpdateStatus();
// NetlinkLink structure for this link
UniquePtr<NetlinkLink> mLink;
// All IPv4/IPv6 addresses on this link
nsTArray<UniquePtr<NetlinkAddress>> mAddresses;
// All neighbors on this link, key is an address
nsClassHashtable<nsCStringHashKey, NetlinkNeighbor> mNeighbors;
// Default IPv4/IPv6 routes
nsTArray<UniquePtr<NetlinkRoute>> mDefaultRoutes;
// Link is up when it's running, it's not a loopback and there is
// a non-local address associated with it.
bool mIsUp;
};
bool CalculateIDForEthernetLink(uint8_t aFamily,
NetlinkRoute* aRouteCheckResult,
uint32_t aRouteCheckIfIdx,
LinkInfo* aRouteCheckLinkInfo,
mozilla::SHA1Sum* aSHA1);
bool CalculateIDForNonEthernetLink(uint8_t aFamily,
NetlinkRoute* aRouteCheckResult,
nsTArray<nsCString>& aLinkNamesToHash,
uint32_t aRouteCheckIfIdx,
LinkInfo* aRouteCheckLinkInfo,
mozilla::SHA1Sum* aSHA1);
nsClassHashtable<nsUint32HashKey, LinkInfo> mLinks;
// Route for mRouteCheckIPv4 address
UniquePtr<NetlinkRoute> mIPv4RouteCheckResult;
// Route for mRouteCheckIPv6 address
UniquePtr<NetlinkRoute> mIPv6RouteCheckResult;
nsTArray<UniquePtr<NetlinkMsg>> mOutgoingMessages;
RefPtr<NetlinkServiceListener> mListener;
};
} // namespace net
} // namespace mozilla
#endif /* NETLINKSERVICE_H_ */