nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
fune/browser/base/content
History
Gijs Kruitbosch f7af2c33b1 Bug 1742801 - do not consume the user gesture from ClickHandlerChild if ClickHandlerParent will ignore the click anyway, r=edgar 
This commit does a couple of things:
- move whereToOpenLink and getRootEvent implementations into BrowserUtils,
  so they can be used from the child process.
- forward callers in utilityOverlay.js to the BrowserUtils ones
  (bug 1742889 will get rid of the forwarding and update all the callers;
   we might be able to get this and bug 1739929 into beta if risk is low
   enough, and touching a bunch of extra files really doesn't help with
   that)
- move the lazy-load of BrowserUtils from browser.js to utilityOverlay.js
  This is safe because everywhere that loads browser.js also loads
  utilityOverlay.js. It's needed because there are some places that use
  utilityOverlay.js but not browser.js, and so now they need access to
  BrowserUtils.jsm.
- use whereToOpenLink to determine if we should avoid consuming the transient
  user gesture activation in the child click handling code.
- add an automated test based on the testcase in the bug.

When working on this, I initially put the check using whereToOpenLink in
the toplevel of the function, and then when I ran places test to check that
I hadn't broken any places consumers of whereToOpenLink or getRootEvent,
realized that I had broken `browser_markPageAsFollowedLink.js`, because it
relies on "normal" (ie no modifier key, left button) link clicks making it
to ClickHandlerParent.jsm . I filed bug 1742894 about this. I've not tried
to fix that here, instead I've tried to ensure that paths through this
function are as untouched as possible while still fixing bug 1739929 and
bug 1742801.

Differential Revision: https://phabricator.services.mozilla.com/D132102
2021-11-25 22:49:00 +00:00
..
certerror Bug 1742696 - Opt-in a bunch of about:pages to dark system colors / form controls. r=Gijs,preferences-reviewers,webcompat-reviewers,twisniewski 2021-11-25 21:24:43 +00:00
docs/tabbrowser
logos Bug 1728238 - Implement VPN promo UI look, r=Mardak 2021-09-04 01:25:34 +00:00
overrides
pageinfo Bug 1731687 - Remove browser-doctype.inc. r=emalysz 2021-09-30 20:01:03 +00:00
test Bug 502258 - lint fix r=fix CLOSED TREE 2021-11-26 02:23:17 +02:00
.eslintrc.js
aboutDialog-appUpdater.js
aboutDialog.css Bug 1704383 - Remove light strip at bottom of about dialog. r=jaws 2021-11-11 19:51:10 +00:00
aboutDialog.js
aboutDialog.xhtml Bug 1731687 - Remove browser-doctype.inc. r=emalysz 2021-09-30 20:01:03 +00:00
aboutFrameCrashed.html Bug 1742696 - Opt-in a bunch of about:pages to dark system colors / form controls. r=Gijs,preferences-reviewers,webcompat-reviewers,twisniewski 2021-11-25 21:24:43 +00:00
aboutRestartRequired.js
aboutRestartRequired.xhtml Bug 1742696 - Opt-in a bunch of about:pages to dark system colors / form controls. r=Gijs,preferences-reviewers,webcompat-reviewers,twisniewski 2021-11-25 21:24:43 +00:00
aboutRobots-icon.png
aboutRobots.css
aboutRobots.js
aboutRobots.xhtml Bug 1742696 - Opt-in a bunch of about:pages to dark system colors / form controls. r=Gijs,preferences-reviewers,webcompat-reviewers,twisniewski 2021-11-25 21:24:43 +00:00
aboutTabCrashed.css
aboutTabCrashed.js
aboutTabCrashed.xhtml Bug 1742696 - Opt-in a bunch of about:pages to dark system colors / form controls. r=Gijs,preferences-reviewers,webcompat-reviewers,twisniewski 2021-11-25 21:24:43 +00:00
appmenu-viewcache.inc.xhtml Bug 1706650 - Split localization item for update banner label for each notification. r=zbraniecki,fluent-reviewers,Gijs 2021-10-26 18:32:36 +00:00
blockedSite.js
blockedSite.xhtml Bug 1742696 - Opt-in a bunch of about:pages to dark system colors / form controls. r=Gijs,preferences-reviewers,webcompat-reviewers,twisniewski 2021-11-25 21:24:43 +00:00
browser-a11yUtils.js
browser-addons.js
browser-allTabsMenu.inc.xhtml
browser-allTabsMenu.js Bug 1730415 -Show pinned tabs on the all tabs menu only if the browser.tabs.tabmanager.enabled pref is enabled r=dao 2021-09-14 15:13:22 +00:00
browser-box.inc.xhtml Bug 1728458 - Migrate browser-box.inc.xhtml to Fluent. r=emalysz,fluent-reviewers,flod 2021-09-02 21:34:14 +00:00
browser-captivePortal.js Bug 1690390, change appendNotification to take a smaller number of arguments: the string type value, a dictionary containing the notification details, and the button list, r=mstriemer 2021-09-17 09:04:59 +00:00
browser-context.inc Bug 502258 - Add a Show Password button to <input type=password> controls. r=Gijs 2021-11-25 20:12:05 +00:00
browser-ctrlTab.js
browser-customization.js
browser-data-submission-info-bar.js Bug 1690390, change appendNotification to take a smaller number of arguments: the string type value, a dictionary containing the notification details, and the button list, r=mstriemer 2021-09-17 09:04:59 +00:00
browser-development-helpers.js
browser-fullScreenAndPointerLock.js Bug 1739091, r=Gijs 2021-11-22 16:11:45 +00:00
browser-fullZoom.js
browser-gestureSupport.js
browser-graphics-utils.js Bug 1726118 - Prefix all webrender debug prefs with gfx.webrender.debug. r=gfx-reviewers,jrmuizel 2021-09-01 17:08:36 +00:00
browser-menubar.inc Bug 1732375 - Update file menu close tab item to reflect multiple tabs selected r=jhirsch,fluent-reviewers 2021-10-26 20:00:26 +00:00
browser-pageActions.js
browser-places.js Bug 1672486 - Remove browser.toolbars.bookmarks.2h2020 pref from browser/customizableui/places r=mak 2021-10-14 07:51:14 +00:00
browser-safebrowsing.js
browser-sets.inc Bug 1725430: disable screenshot shortcut for extension when screenshots.browser.component.enabled is true. r=emalysz,fluent-reviewers,flod 2021-09-28 20:01:35 +00:00
browser-sidebar.js
browser-siteIdentity.js Bug 1567443 - Added flag for indicating secure Chrome UI in nsIAboutModule. r=pbz,webcompat-reviewers,twisniewski 2021-10-26 13:32:31 +00:00
browser-sitePermissionPanel.js Bug 1706534 - Fix up popup notification link alignment and button focus rings, and clean up how we set the link color for dark themes. r=harry 2021-10-13 16:37:56 +00:00
browser-siteProtections.js Bug 1731739 part 2 - Use site as key for 3rdPartyStorage permissions, rather than origin r=anti-tracking-reviewers,pbz,timhuang 2021-11-23 18:25:58 +00:00
browser-sync.js Bug 1728460 - Migrate appmenu-viewcache.inc.xhtml to Fluent. r=mtigley,fluent-reviewers,flod 2021-09-07 17:46:19 +00:00
browser-tabsintitlebar.js Bug 1739539 - Rename titlebar pref and add migration from old pref. r=mconley 2021-11-10 21:17:32 +00:00
browser-thumbnails.js
browser-toolbarKeyNav.js
browser-webrtc.js
browser.css Bug 1719938 - Removed remaining (non-negated) -moz-proton media queries. r=mhowell,mtigley,emilio 2021-11-22 22:10:33 +00:00
browser.js Bug 1742801 - do not consume the user gesture from ClickHandlerChild if ClickHandlerParent will ignore the click anyway, r=edgar 2021-11-25 22:49:00 +00:00
browser.xhtml Bug 1725430: disable screenshot shortcut for extension when screenshots.browser.component.enabled is true. r=emalysz,fluent-reviewers,flod 2021-09-28 20:01:35 +00:00
contentTheme.js Bug 1730562 - White flash before about:home/newtab themed background is rendered. r=mconley,dao 2021-10-07 18:57:27 +00:00
fullscreen-and-pointerlock.inc.xhtml
global-scripts.inc
hiddenWindowMac.xhtml Bug 1731687 - Remove browser-doctype.inc. r=emalysz 2021-09-30 20:01:03 +00:00
history-swipe-arrow.svg
macWindow.inc.xhtml Bug 1731687 - Remove browser-doctype.inc. r=emalysz 2021-09-30 20:01:03 +00:00
main-popupset.inc.xhtml Bug 1735614 - Building initial save visible / save full page UI in the tab modal. r=sfoster 2021-11-04 17:57:29 +00:00
metrics.yaml Bug 1741674 - Advise in each metrics.yaml that we have docs for adding metrics r=TravisLong,nalexander 2021-11-22 20:07:38 +00:00
moz.build Bug 1722087 - Save 1.4M in omnijar by removing unused theme images; r=desktop-theme-reviewers,harry 2021-08-02 17:03:02 +00:00
navigator-toolbox.inc.xhtml Bug 1736807 - Use --toolbar-field-icon-fill-attention for login icon and remove login-icon class. r=desktop-theme-reviewers,dao 2021-11-02 19:29:11 +00:00
nonbrowser-mac.js
nsContextMenu.js Bug 502258 - Add a Show Password button to <input type=password> controls. r=Gijs 2021-11-25 20:12:05 +00:00
popup-notifications.inc Bug 1731035 - Highlight the primary button in the Messaging System doorhager r=pdahiya 2021-10-12 09:19:34 +00:00
robot.ico
safeMode.css
safeMode.js
safeMode.xhtml
sanitize.xhtml Bug 1721474 - use sentence case in the clear recent history dialog, r=mconley,fluent-reviewers,flod 2021-08-14 17:43:14 +00:00
sanitizeDialog.css Bug 1723679 - Align Selection Button with other items. r=Gijs 2021-10-20 10:09:22 +00:00
sanitizeDialog.js Bug 1718435 - fix clear recent history dialog when there are no open windows, r=mconley 2021-08-06 22:18:35 +00:00
spotlight.html Bug 1735841 - Update template with hidden text that is shown on a link click for Total Cookie Protection r=andreio 2021-10-28 14:24:59 +00:00
spotlight.js Bug 1735841 - Update template with hidden text that is shown on a link click for Total Cookie Protection r=andreio 2021-10-28 14:24:59 +00:00
static-robot.png
tabbrowser-tab.js Bug 1684876 - Separate Play and Mute tab menu icons and functionality r=Gijs,alwu,flod 2021-10-26 16:33:10 +00:00
tabbrowser-tabs.js Bug 1635018 - Part 2: Replace dragexit with dragleave in browser/ r=Gijs,mak 2021-08-05 14:33:39 +00:00
tabbrowser.css
tabbrowser.js Backed out 11 changesets (bug 1721217) for bc failures on browser_scrollPositions.js . CLOSED TREE 2021-11-26 01:51:03 +02:00
titlebar-items.inc.xhtml Bug 1735318 - Unify "native" vs. "fullscreen" window controls. r=desktop-theme-reviewers,dao 2021-10-12 13:20:13 +00:00
upgradeDialog.html Bug 1728853 - Update upgrade spotlight for MR2 themes r=pdahiya,fluent-reviewers,flod 2021-10-03 03:56:10 +00:00
upgradeDialog.js Bug 1736038 - Remove -moz-toolbar-prefers-color-scheme. r=dao 2021-10-15 16:53:08 +00:00
utilityOverlay.js Bug 1742801 - do not consume the user gesture from ClickHandlerChild if ClickHandlerParent will ignore the click anyway, r=edgar 2021-11-25 22:49:00 +00:00
webext-panels.js
webext-panels.xhtml Bug 1737044 - Add an id to the content-select dropdown menupopup. r=stransky 2021-10-21 14:02:30 +00:00
webrtcIndicator.js
webrtcIndicator.xhtml
webrtcLegacyIndicator.js
webrtcLegacyIndicator.xhtml