forked from mirrors/gecko-dev
1a1f42da37
This changeset is the result of adding modernize-use-default-member-init to tools/clang-tidy/config.yaml then proceeding to run `./mach static-analysis check netwerk/ --fix` I then went through the resulting fix and manually updated all of the member variables which were missed due to them having a non-trivial constructor. Note that the tool was only run on Linux, so code that only runs on some platforms may have been missed. The member variables that are still initialized in the contructor definition are: - bitfields (not all currently supported compilers allow default-member-init - variables that are initialized via a parameter - variables that use code not visible in the header file There are a few advantages to landing this change: - fewer lines of code - now declaration is in the same place as initialization this also makes it easier to see when looking at the header. - it makes it harder to miss initializing a member when adding a new contructor - variables that depend on an include guard look much nicer now Additionally I removed some unnecessary reinitialization of NetAddr members (it has a constructor that does that now), and changed nsWifiScannerDBus to use the thread-safe strtok_r instead of strtok. Differential Revision: https://phabricator.services.mozilla.com/D116980
111 lines
3.3 KiB
C++
111 lines
3.3 KiB
C++
/* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#ifndef nsLoadGroup_h__
|
|
#define nsLoadGroup_h__
|
|
|
|
#include "nsILoadGroup.h"
|
|
#include "nsILoadGroupChild.h"
|
|
#include "nsIObserver.h"
|
|
#include "nsCOMPtr.h"
|
|
#include "nsWeakReference.h"
|
|
#include "nsISupportsPriority.h"
|
|
#include "PLDHashTable.h"
|
|
#include "mozilla/TimeStamp.h"
|
|
|
|
class nsIRequestContext;
|
|
class nsIRequestContextService;
|
|
class nsITimedChannel;
|
|
|
|
namespace mozilla {
|
|
namespace net {
|
|
|
|
class nsLoadGroup : public nsILoadGroup,
|
|
public nsILoadGroupChild,
|
|
public nsIObserver,
|
|
public nsISupportsPriority,
|
|
public nsSupportsWeakReference {
|
|
public:
|
|
NS_DECL_ISUPPORTS
|
|
|
|
////////////////////////////////////////////////////////////////////////////
|
|
// nsIRequest methods:
|
|
NS_DECL_NSIREQUEST
|
|
|
|
////////////////////////////////////////////////////////////////////////////
|
|
// nsILoadGroup methods:
|
|
NS_DECL_NSILOADGROUP
|
|
|
|
////////////////////////////////////////////////////////////////////////////
|
|
// nsILoadGroupChild methods:
|
|
NS_DECL_NSILOADGROUPCHILD
|
|
|
|
////////////////////////////////////////////////////////////////////////////
|
|
// nsISupportsPriority methods:
|
|
NS_DECL_NSISUPPORTSPRIORITY
|
|
|
|
////////////////////////////////////////////////////////////////////////////
|
|
// nsIObserver methods:
|
|
NS_DECL_NSIOBSERVER
|
|
|
|
////////////////////////////////////////////////////////////////////////////
|
|
// nsLoadGroup methods:
|
|
|
|
nsLoadGroup();
|
|
|
|
nsresult Init();
|
|
nsresult InitWithRequestContextId(const uint64_t& aRequestContextId);
|
|
|
|
void SetGroupObserver(nsIRequestObserver* aObserver,
|
|
bool aIncludeBackgroundRequests);
|
|
|
|
protected:
|
|
virtual ~nsLoadGroup();
|
|
|
|
nsresult MergeLoadFlags(nsIRequest* aRequest, nsLoadFlags& flags);
|
|
nsresult MergeDefaultLoadFlags(nsIRequest* aRequest, nsLoadFlags& flags);
|
|
|
|
private:
|
|
void TelemetryReport();
|
|
void TelemetryReportChannel(nsITimedChannel* timedChannel,
|
|
bool defaultRequest);
|
|
|
|
nsresult RemoveRequestFromHashtable(nsIRequest* aRequest, nsresult aStatus);
|
|
nsresult NotifyRemovalObservers(nsIRequest* aRequest, nsresult aStatus);
|
|
|
|
protected:
|
|
uint32_t mForegroundCount{0};
|
|
uint32_t mLoadFlags{LOAD_NORMAL};
|
|
uint32_t mDefaultLoadFlags{0};
|
|
int32_t mPriority{PRIORITY_NORMAL};
|
|
|
|
nsCOMPtr<nsILoadGroup> mLoadGroup; // load groups can contain load groups
|
|
nsCOMPtr<nsIInterfaceRequestor> mCallbacks;
|
|
nsCOMPtr<nsIRequestContext> mRequestContext;
|
|
nsCOMPtr<nsIRequestContextService> mRequestContextService;
|
|
|
|
nsCOMPtr<nsIRequest> mDefaultLoadRequest;
|
|
PLDHashTable mRequests;
|
|
|
|
nsWeakPtr mObserver;
|
|
nsWeakPtr mParentLoadGroup;
|
|
|
|
nsresult mStatus{NS_OK};
|
|
bool mIsCanceling{false};
|
|
bool mDefaultLoadIsTimed{false};
|
|
bool mBrowsingContextDiscarded{false};
|
|
bool mExternalRequestContext{false};
|
|
bool mNotifyObserverAboutBackgroundRequests{false};
|
|
|
|
/* Telemetry */
|
|
mozilla::TimeStamp mDefaultRequestCreationTime;
|
|
uint32_t mTimedRequests{0};
|
|
uint32_t mCachedRequests{0};
|
|
};
|
|
|
|
} // namespace net
|
|
} // namespace mozilla
|
|
|
|
#endif // nsLoadGroup_h__
|