fune/browser/components/downloads/content/downloadsContextMenu.inc.xhtml
Gijs Kruitbosch 1e1ef247f3 Bug 1628255 - do not add a label/accesskey attribute to the button in the about:downloads and library downloads views, r=mconley,flod,fluent-reviewers
As noted by Jamie, accessible labels for richlistitem elements come from the
label elements that have value attributes within them.

In bug 1608202, we accidentally reused the same fluent message for the buttons
in about:downloads and the library download view (DownloadsViewUI.jsm) and
the context menuitems that do the same thing. This meant that
those menuitems gained a tooltip they shouldn't have, and the buttons gained
a label and accesskey they shouldn't have. The latter caused the
accessibility regression described in the bug.

This patch separates out the two usecases for the same string. I also checked
the other l10nIds used in DownloadsViewUI.jsm, and as far as I can tell this
is the only one that is reused in this way.

Differential Revision: https://phabricator.services.mozilla.com/D70219

--HG--
extra : moz-landing-system : lando
2020-04-08 21:39:14 +00:00

43 lines
1.5 KiB
HTML

# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this file,
# You can obtain one at http://mozilla.org/MPL/2.0/.
<menupopup id="downloadsContextMenu" class="download-state">
<linkset>
<html:link rel="localization" href="browser/downloads.ftl" />
</linkset>
<menuitem command="downloadsCmd_pauseResume"
class="downloadPauseMenuItem"
data-l10n-id="downloads-cmd-pause"/>
<menuitem command="downloadsCmd_pauseResume"
class="downloadResumeMenuItem"
data-l10n-id="downloads-cmd-resume"/>
<menuitem command="downloadsCmd_unblock"
class="downloadUnblockMenuItem"
data-l10n-id="downloads-cmd-unblock"/>
<menuitem command="downloadsCmd_show"
class="downloadShowMenuItem"
#ifdef XP_MACOSX
data-l10n-id="downloads-cmd-show-menuitem-mac"
#else
data-l10n-id="downloads-cmd-show-menuitem"
#endif
/>
<menuseparator class="downloadCommandsSeparator"/>
<menuitem command="downloadsCmd_openReferrer"
data-l10n-id="downloads-cmd-go-to-download-page"/>
<menuitem command="cmd_copy"
data-l10n-id="downloads-cmd-copy-download-link"/>
<menuseparator/>
<menuitem command="cmd_delete"
class="downloadRemoveFromHistoryMenuItem"
data-l10n-id="downloads-cmd-remove-from-history"/>
<menuitem command="downloadsCmd_clearDownloads"
data-l10n-id="downloads-cmd-clear-downloads"/>
</menupopup>