nagai/kernel
3
0
Fork 0
forked from mirrors/linux
Code Pull requests Activity

wifi: mac80211: fix error path key leak

Browse source 
In the previous key leak fix for the other error
paths, I meant to unify all of them to the same
place, but used the wrong label, which I noticed
when doing the merge into wireless-next. Fix it.

Fixes: d097ae01eb ("wifi: mac80211: fix potential key leak")
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
This commit is contained in:
Johannes Berg 2023-10-05 23:09:18 +02:00
parent 91d20ab9d9
commit 02e0e426a2
1 changed files with 1 additions and 2 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

3
net/mac80211/key.c
View file

@ -912,7 +912,7 @@ int ieee80211_key_link(struct ieee80211_key *key,
*/ */
if (ieee80211_key_identical(sdata, old_key, key)) { if (ieee80211_key_identical(sdata, old_key, key)) {
ret = -EALREADY; ret = -EALREADY;
goto unlock; goto out;
} }
key->local = sdata->local; key->local = sdata->local;
@ -940,7 +940,6 @@ int ieee80211_key_link(struct ieee80211_key *key,
out: out:
ieee80211_key_free_unused(key); ieee80211_key_free_unused(key);
unlock:
mutex_unlock(&sdata->local->key_mtx); mutex_unlock(&sdata->local->key_mtx);
return ret; return ret;