nagai/kernel
3
0
Fork 0
forked from mirrors/linux
Code Pull requests Activity

net: ipv4: fix listify ip_rcv_finish in case of forwarding

Browse source 
In commit 5fa12739a5 ("net: ipv4: listify ip_rcv_finish") calling
dst_input(skb) was split-out.  The ip_sublist_rcv_finish() just calls
dst_input(skb) in a loop.

The problem is that ip_sublist_rcv_finish() forgot to remove the SKB
from the list before invoking dst_input().  Further more we need to
clear skb->next as other parts of the network stack use another kind
of SKB lists for xmit_more (see dev_hard_start_xmit).

A crash occurs if e.g. dst_input() invoke ip_forward(), which calls
dst_output()/ip_output() that eventually calls __dev_queue_xmit() +
sch_direct_xmit(), and a crash occurs in validate_xmit_skb_list().

This patch only fixes the crash, but there is a huge potential for
a performance boost if we can pass an SKB-list through to ip_forward.

Fixes: 5fa12739a5 ("net: ipv4: listify ip_rcv_finish")
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Acked-by: Edward Cree <ecree@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Jesper Dangaard Brouer 2018-07-11 17:01:20 +02:00 committed by David S. Miller
parent 51bef926be
commit 0761680d52
1 changed files with 7 additions and 1 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

8
net/ipv4/ip_input.c
View file

@ -530,8 +530,14 @@ static void ip_sublist_rcv_finish(struct list_head *head)
{ {
struct sk_buff *skb, *next; struct sk_buff *skb, *next;
list_for_each_entry_safe(skb, next, head, list) list_for_each_entry_safe(skb, next, head, list) {
list_del(&skb->list);
/* Handle ip{6}_forward case, as sch_direct_xmit have
* another kind of SKB-list usage (see validate_xmit_skb_list)
*/
skb->next = NULL;
dst_input(skb); dst_input(skb);
}
} }
static void ip_list_rcv_finish(struct net *net, struct sock *sk, static void ip_list_rcv_finish(struct net *net, struct sock *sk,