forked from mirrors/linux
		
	netlink: specs: don't allow version to be specified for genetlink
There is no good reason to specify the version for new protocols. Forbid it in genetlink schema. If the future proves me wrong, this restriction could be easily lifted. Move the version definition in between legacy properties in genetlink-legacy. Suggested-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Jiri Pirko <jiri@nvidia.com> Link: https://lore.kernel.org/r/20231010074810.191177-1-jiri@resnulli.us Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
		
							parent
							
								
									9b47243cc2
								
							
						
					
					
						commit
						0f07415ebb
					
				
					 3 changed files with 4 additions and 12 deletions
				
			
		| 
						 | 
				
			
			@ -26,10 +26,6 @@ properties:
 | 
			
		|||
    type: string
 | 
			
		||||
  doc:
 | 
			
		||||
    type: string
 | 
			
		||||
  version:
 | 
			
		||||
    description: Generic Netlink family version. Default is 1.
 | 
			
		||||
    type: integer
 | 
			
		||||
    minimum: 1
 | 
			
		||||
  protocol:
 | 
			
		||||
    description: Schema compatibility level. Default is "genetlink".
 | 
			
		||||
    enum: [ genetlink, genetlink-c ]
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -26,10 +26,6 @@ properties:
 | 
			
		|||
    type: string
 | 
			
		||||
  doc:
 | 
			
		||||
    type: string
 | 
			
		||||
  version:
 | 
			
		||||
    description: Generic Netlink family version. Default is 1.
 | 
			
		||||
    type: integer
 | 
			
		||||
    minimum: 1
 | 
			
		||||
  protocol:
 | 
			
		||||
    description: Schema compatibility level. Default is "genetlink".
 | 
			
		||||
    enum: [ genetlink, genetlink-c, genetlink-legacy ] # Trim
 | 
			
		||||
| 
						 | 
				
			
			@ -53,6 +49,10 @@ properties:
 | 
			
		|||
      Defines if the input policy in the kernel is global, per-operation, or split per operation type.
 | 
			
		||||
      Default is split.
 | 
			
		||||
    enum: [ split, per-op, global ]
 | 
			
		||||
  version:
 | 
			
		||||
    description: Generic Netlink family version. Default is 1.
 | 
			
		||||
    type: integer
 | 
			
		||||
    minimum: 1
 | 
			
		||||
  # End genetlink-legacy
 | 
			
		||||
 | 
			
		||||
  definitions:
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -26,10 +26,6 @@ properties:
 | 
			
		|||
    type: string
 | 
			
		||||
  doc:
 | 
			
		||||
    type: string
 | 
			
		||||
  version:
 | 
			
		||||
    description: Generic Netlink family version. Default is 1.
 | 
			
		||||
    type: integer
 | 
			
		||||
    minimum: 1
 | 
			
		||||
  protocol:
 | 
			
		||||
    description: Schema compatibility level. Default is "genetlink".
 | 
			
		||||
    enum: [ genetlink ]
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
		Reference in a new issue