nagai/kernel
3
0
Fork 0
forked from mirrors/linux
Code Pull requests Activity

usb: phy: propagate __of_usb_find_phy()'s error on failure

Browse source 
When __of_usb_find_phy() fails, it returns -ENODEV - its
error code has to be returned by devm_usb_get_phy_by_phandle().
Only when the former function succeeds and try_module_get()
fails should -EPROBE_DEFER be returned.

[ balbi@ti.com : remove trailing whitespace ]

Signed-off-by: Arjun Sreedharan <arjun024@gmail.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
This commit is contained in:
Arjun Sreedharan 2014-11-20 21:23:36 +05:30 committed by Felipe Balbi
parent 62c606978a
commit 1290a958d4
1 changed files with 3 additions and 1 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/usb/phy/phy.c
View file

@ -191,7 +191,9 @@ struct usb_phy *devm_usb_get_phy_by_phandle(struct device *dev,
phy = __of_usb_find_phy(node);
if (IS_ERR(phy) || !try_module_get(phy->dev->driver->owner)) {
phy = ERR_PTR(-EPROBE_DEFER);
if (!IS_ERR(phy))
phy = ERR_PTR(-EPROBE_DEFER);
devres_free(ptr);
goto err1;
}