nagai/kernel
3
0
Fork 0
forked from mirrors/linux
Code Pull requests Activity

net/mlx5e: Fix use after free in mlx5e_fs_init()

Browse source 
Call mlx5e_fs_vlan_free(fs) before kvfree(fs).

Fixes: af8bbf7300 ("net/mlx5e: Convert mlx5e_flow_steering member of mlx5e_priv to pointer")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
This commit is contained in:
Dan Carpenter 2022-08-04 17:43:21 +03:00 committed by Saeed Mahameed
parent 6514210b6d
commit 21234e3a84
1 changed files with 3 additions and 2 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

5
drivers/net/ethernet/mellanox/mlx5/core/en_fs.c
View file

@ -1395,10 +1395,11 @@ struct mlx5e_flow_steering *mlx5e_fs_init(const struct mlx5e_profile *profile,
} }
return fs; return fs;
err_free_fs:
kvfree(fs);
err_free_vlan: err_free_vlan:
mlx5e_fs_vlan_free(fs); mlx5e_fs_vlan_free(fs);
err_free_fs:
kvfree(fs);
err: err:
return NULL; return NULL;
} }