nagai/kernel
3
0
Fork 0
forked from mirrors/linux
Code Pull requests Activity

drm/sched: memset() 'job' in drm_sched_job_init()

Browse source 
drm_sched_job_init() has no control over how users allocate struct
drm_sched_job. Unfortunately, the function can also not set some struct
members such as job->sched.

This could theoretically lead to UB by users dereferencing the struct's
pointer members too early.

It is easier to debug such issues if these pointers are initialized to
NULL, so dereferencing them causes a NULL pointer exception.
Accordingly, drm_sched_entity_init() does precisely that and initializes
its struct with memset().

Initialize parameter "job" to 0 in drm_sched_job_init().

Signed-off-by: Philipp Stanner <pstanner@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241021105028.19794-2-pstanner@redhat.com
Reviewed-by: Christian König <christian.koenig@amd.com>
This commit is contained in:
Philipp Stanner 2024-10-21 12:50:28 +02:00
parent df606be44c
commit 2320c9e6a7
1 changed files with 8 additions and 0 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

8
drivers/gpu/drm/scheduler/sched_main.c
View file

@ -796,6 +796,14 @@ int drm_sched_job_init(struct drm_sched_job *job,
return -EINVAL;
}
/*
* We don't know for sure how the user has allocated. Thus, zero the
* struct so that unallowed (i.e., too early) usage of pointers that
* this function does not set is guaranteed to lead to a NULL pointer
* exception instead of UB.
*/
memset(job, 0, sizeof(*job));
job->entity = entity;
job->credits = credits;
job->s_fence = drm_sched_fence_alloc(entity, owner);