nagai/kernel
3
0
Fork 0
forked from mirrors/linux
Code Pull requests Activity

iommu/amd: WARN when __[attach|detach]_device are called with irqs enabled

Browse source 
These functions rely on being called with IRQs disabled. Add
a WARN_ON to detect early when its not.

Signed-off-by: Joerg Roedel <jroedel@suse.de>
This commit is contained in:
Joerg Roedel 2015-10-20 17:33:37 +02:00
parent f1dd0a8bcd
commit 272e4f99e9
1 changed files with 12 additions and 0 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

12
drivers/iommu/amd_iommu.c
View file

@ -2030,6 +2030,12 @@ static int __attach_device(struct iommu_dev_data *dev_data,
{ {
int ret; int ret;
/*
* Must be called with IRQs disabled. Warn here to detect early
* when its not.
*/
WARN_ON(!irqs_disabled());
/* lock domain */ /* lock domain */
spin_lock(&domain->lock); spin_lock(&domain->lock);
@ -2190,6 +2196,12 @@ static void __detach_device(struct iommu_dev_data *dev_data)
{ {
struct protection_domain *domain; struct protection_domain *domain;
/*
* Must be called with IRQs disabled. Warn here to detect early
* when its not.
*/
WARN_ON(!irqs_disabled());
if (WARN_ON(!dev_data->domain)) if (WARN_ON(!dev_data->domain))
return; return;