nagai/kernel
3
0
Fork 0
forked from mirrors/linux
Code Pull requests Activity

rtc: recycle id when unloading a rtc driver

Browse source 
When calling rtc_device_unregister, we are not freeing the id used by the
driver.  So when doing a unload/load cycle for a RTC driver (e.g.  rmmod
rtc_cmos && modprobe rtc_cmos), its id is incremented by one.  As a
consequence, we no longer have neither an rtc0 driver nor a
/proc/driver/rtc (as it only exists for the first driver).

Signed-off-by: Vincent Palatin <vpalatin@chromium.org>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Vincent Palatin 2012-10-04 17:13:52 -07:00 committed by Linus Torvalds
parent 179a502f8c
commit 2830a6d201
1 changed files with 1 additions and 0 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

1
drivers/rtc/class.c
View file

@ -238,6 +238,7 @@ void rtc_device_unregister(struct rtc_device *rtc)
rtc_proc_del_device(rtc); rtc_proc_del_device(rtc);
device_unregister(&rtc->dev); device_unregister(&rtc->dev);
rtc->ops = NULL; rtc->ops = NULL;
ida_simple_remove(&rtc_ida, rtc->id);
mutex_unlock(&rtc->ops_lock); mutex_unlock(&rtc->ops_lock);
put_device(&rtc->dev); put_device(&rtc->dev);
} }