nagai/kernel
3
0
Fork 0
forked from mirrors/linux
Code Pull requests Activity

pppoe: fix reference counting in PPPoE proxy

Browse source 
Drop reference on the relay_po socket when __pppoe_xmit() succeeds.
This is already handled correctly in the error path.

Signed-off-by: Guillaume Nault <g.nault@alphalink.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Guillaume Nault 2016-02-15 17:01:10 +01:00 committed by David S. Miller
parent 705bcdda81
commit 29e73269aa
1 changed files with 2 additions and 0 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/net/ppp/pppoe.c
View file

@ -395,6 +395,8 @@ static int pppoe_rcv_core(struct sock *sk, struct sk_buff *skb)
if (!__pppoe_xmit(sk_pppox(relay_po), skb)) if (!__pppoe_xmit(sk_pppox(relay_po), skb))
goto abort_put; goto abort_put;
sock_put(sk_pppox(relay_po));
} else { } else {
if (sock_queue_rcv_skb(sk, skb)) if (sock_queue_rcv_skb(sk, skb))
goto abort_kfree; goto abort_kfree;